X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org DE0E53896837
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1610475406;
	bh=vktR4O8zZqx8GQbiLByNf/7VCnkiGxGlh6zc564VokU=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	From;
	b=Tt+way0yRi6v7BAFyRGyfF2g59drQ/O/wyN/aCvExzmRxajmbGf+dLRe2ZAgTyqcg
	MH//GSOR15SUIZ/YfRFmQ2EiI/2MBtw9hhpL0L0kmw74P5hn4EE62Bo5iA2V9rpx7n
	S8DI6ocqQLF8vKRwaBlu/Rjj9Z8qcSFEMWgapTrw=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 0766F386F013
Date:	Tue, 12 Jan 2021 19:16:40 +0100
To:	cygwin AT cygwin DOT com
Subject:	Re: tar 1.33 symlinks : Cannot change mode to...
Message-ID:	<20210112181640.GI59030@calimero.vinschen.de>
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<PU1PR04MB25507BD8BECC57FABE96DC8590AB0 AT PU1PR04MB2550 DOT apcprd04 DOT prod DOT outlook DOT com>
	<1dff3bac-a82e-f30a-a86d-a4dcc08c849b AT cornell DOT edu>
	<3a435fba-bdd2-535d-2161-f2fb75e2a4af AT cornell DOT edu>
	<20210112171505 DOT GH59030 AT calimero DOT vinschen DOT de>
	<14bf8400-89bd-095e-f60d-0a422e53c3a5 AT cornell DOT edu>
MIME-Version:	1.0
In-Reply-To:	<14bf8400-89bd-095e-f60d-0a422e53c3a5@cornell.edu>
X-Provags-ID:	V03:K1:9yJU/SDbjIeXYyY8jjI3Y9p5A/a1h+q4kc7MlwGmMId7q1vsJer
	KJI7Vdzpqzz1TZNkaXeBLAz5MVswLWfIGza1qbTF6nXav1X9YTWfwcdvuTXQ0CuSJzF5IUL
	Qe1IcjAuqORFUeJ2rQYVYuBsoStnDlUDW4Y2nXv4aZHCGRcmDCQvGHQX4KgPvbzoyLt9Dpg
	QzWJDLWENVIJ5LoMWgR+Q==
X-UI-Out-Filterresults:	notjunk:1;V03:K0:+Dvb7z6hBF8=:asCi56I1JnhVXmwtODEw49
	kH1lWUrdwauqtsyS/xqhTqwwy6kyow8q3x8aQvvPGQozFRZJz6GtHc0WHmSaLRsAzQmBG2aKL
	ayFdyJa+Tz335dUdB/ykDYd6S2SD18ieCx5ScTTDkSNMXhAmYF2noppkWMLD+ASEovwd8CCgX
	25dVPNwVBmC9gHVDmE8Giwwq8/r+SACE13tylGqzPy49s3hAg3g8RMrKbeX4DH+224cMrV+UG
	7YFhXsKJq7HF5aKT3HGxSUc2Fbiy0kwAdEZYYgkpDDao+xdDvH04NYxfVQKGK+I9RKoF2t8Dm
	rrZWrbFXMLGm6hEJdjpbjh/GL9qtAwSPpLiYivbvcTRxW+AIlf5gZzZkTvDxE5xL/zhmgfsFz
	wzEDgXMABqxK0ZtMyFEpD7uGbUpxt4vWmIXlAWc83vKZkOcm5BvMwyd1pOEDvPvVgxlIaZOXV
	DV9x9ioPRQ==
X-Spam-Status:	No, score=-100.8 required=5.0 tests=BAYES_00,
	GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL,
	TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	cygwin AT cygwin DOT com
Cc:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

On Jan 12 12:49, Ken Brown via Cygwin wrote:
> On 1/12/2021 12:15 PM, Corinna Vinschen wrote:
> > On Jan 12 11:55, Ken Brown via Cygwin wrote:
> > > [...]
> > > This appears to be a bug in fstat in 32-bit Cygwin.  Here's what I'm seeing
> > > in gdb, using an unoptimized build of cygwin1.dll.  There is a call to
> > > fstatat in the tar source file gnu/fchmodat.c:87.  This ultimately leads to
> > > a call to fstat, whose definition in syscalls.cc is the following in the
> > > 32-bit case:
> > 
> > No, wait.  struct stat == struct _stat64 since Cygwin 1.5.0!
> > 
> > With Cygwin 1.5.0, the old entry point fstat was only retained to serve
> > old 32 bit applications buil.t under Cygwin 1.3.x or earlier.
> > 
> > Consequentially, newer 32 bit apps, built with Cygwin 1.5.0 or later,
> > are redirected to fstat64, see NEW_FUNCTIONS in Makefile.in.
> > 
> > If tar is actually calling fstat, something fishy is going on.
> 
> It's not tar that's calling fstat, it's Cygwin's fstatat at
> syscalls.cc:4855. This appears to be a bug that I introduced in commit
> 84252946.  I'll fix it.

Oh, right, this code should call fstat64, or resolve to an fhandler
and call its fstat method.

> Thanks for setting me straight.

Never mind, shit happens.


Corinna
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -