X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 4CEF43896C20
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1610473793;
	bh=Hgsdqf5GhzrS8mFu/xfADBAOPRtlW12I3k3HQTrwcdw=;
	h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=T8gics/Hq3g6DdB7Wvx+SBIplzMrAPwGSMAuYv2luo0ClhcsFRdZ/qQjiAgPAd/iP
	B6kazkc/OPAgdl86Npfrmbn71kb8qOxgPbTaH318XSNoEshnzzBVYmO5qZ113ldY5D
	Rvl7RgANoRtOHc6Bd0hPNzsCDJ4ELUiBvV3c7820=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 6171E386F036
ARC-Seal:	i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
	b=KXACXo6S4PAzfO3AeK92OoDiN0mEOyQD3rjJiEDFmH9jKJ7c+MQiegefsyEfRaFYsB7m64HjlQYADwP3YbqdqeHu9X0Jr4maqczKdI190i0IqWFfQJbfynJimqc943rHXfdLBl/o1l1WwUJruE3vL/+7l4d5Ev2vtJYEx0stidu3CLPL4AWadgVrZkIsCRrxcPv4zCEPZkR9njiR6DOWu5ZHK+HhQvFfU5qumIrfX+wiCNYvtj4+eTMsG+lt9F2p8ZyGjKNAjClzA6a5RQr9Pmb5AqO0F+sZblJsgB5wuJD5FIbmGdMx3f/Irmra5b2ZHXiuMsMk/Prmm9gxrlVKWg==
ARC-Message-Signature:	i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
	s=arcselector9901;
	h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
	bh=r5JLyeNVllx1iG+hBBVLALAVw61Q2OTQ47+LuKyz8mA=;
	b=N6w7fG6/K41gJX/nBGOBTXLK7POc0l2g1HLMXpR8jMCK2Cvv0g56mJyl1rXqtA/lw+M2o9oi+H036EV3X6N1aQO8KSIqTqvlmR/3CrbUFCb80q9zhcuy7pmBmEJfcPPHVdsmvZe88dqQZyulzT1jhQI0PUGhkO7ejwmMZV+5lXCbKWnTp3vt/pOztr9g/AhNqAhATmrUPF07IzVvBP25cRAd7jfrnFFfBVPnZcC0qp2a4Y3l0xw+t7envj0Wgo6GzaeY/XiJeUU8o+xDExag+dTcfhCJZzCEJZLyIFXqgUdu1k5gsM4NoZhQeR9SioRDP8/hhRUhafbp7JBaEgtHpw==
ARC-Authentication-Results:	i=1; mx.microsoft.com 1; spf=pass
	smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu;
	dkim=pass header.d=cornell.edu; arc=none
Subject:	Re: tar 1.33 symlinks : Cannot change mode to...
To:	cygwin AT cygwin DOT com
References:	<PU1PR04MB25507BD8BECC57FABE96DC8590AB0 AT PU1PR04MB2550 DOT apcprd04 DOT prod DOT outlook DOT com>
	<1dff3bac-a82e-f30a-a86d-a4dcc08c849b AT cornell DOT edu>
	<3a435fba-bdd2-535d-2161-f2fb75e2a4af AT cornell DOT edu>
	<20210112171505 DOT GH59030 AT calimero DOT vinschen DOT de>
Message-ID:	<14bf8400-89bd-095e-f60d-0a422e53c3a5@cornell.edu>
Date:	Tue, 12 Jan 2021 12:49:47 -0500
User-Agent:	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
	Thunderbird/78.5.1
In-Reply-To:	<20210112171505.GH59030@calimero.vinschen.de>
X-Originating-IP:	[65.112.130.200]
X-ClientProxiedBy:	BN1PR14CA0013.namprd14.prod.outlook.com
	(2603:10b6:408:e3::18) To BN7PR04MB4388.namprd04.prod.outlook.com
	(2603:10b6:406:f8::19)
MIME-Version:	1.0
X-MS-Exchange-MessageSentRepresentingType:	1
X-MS-PublicTrafficType:	Email
X-MS-Office365-Filtering-Correlation-Id:	c7ac6292-68a0-4b60-da29-08d8b72274dc
X-MS-TrafficTypeDiagnostic:	BN8PR04MB6386:
X-Microsoft-Antispam-PRVS:	<BN8PR04MB6386DDE56A98E4ADDC3A05B1D8AA0 AT BN8PR04MB6386 DOT namprd04 DOT prod DOT outlook DOT com>
X-MS-Oob-TLC-OOBClassifiers:	OLM:5236;
X-MS-Exchange-SenderADCheck:	1
X-Microsoft-Antispam:	BCL:0;
X-Microsoft-Antispam-Message-Info:	PTfrxadG8ZcWOK6wQijT20bicuVq5KDqgZ0fmO+vlpm7eZjGc+DYd4mPvU54ALAWlqcpyaBhwIUWuvhmm82CF28v2pK0JVh75YcrpzvalziCE/bQxj/7rmBhz5N4iOkfLKtHOGFWnQ/vvlueFxaUQjvmY9lfcC7tivNkkrAzm5STg3nPtNlvgSSIEG98U/DetqSLcowhwxdf3T+bkMGbYpT20/fXJX1JTZYlZVkRerPVuSZix1NTFNjEm1ZIhamsEytqQscLvxUdIGxt7rNXCg/BF1rAVvn/AKR9XZ0XBVLBqwOwCKAll/ZYKl28yEaqArqppWylmQCR6n3xOpyC5HQFhySaOuV2uOPqOqNxEn4QqX5JP+WS6xRNyceh4t6qHhei85k6PmzBmMwjTff+bCj2I2rqyI68QDTwKCYDuDmCJBYBvdoZe7Qmjx+yqXQok+bqlpIYY1SVwXLRftDS1pfOTzBaRBxaJ9wN4x7DKUswQ20IWDr5QWKrXJw307SAfLN8zfLcBOpzR/guttK/5ktgmF0T/KHTnngIMAPrP0vWktn0DlMuEcNFHJB2hQGR
X-Forefront-Antispam-Report:	CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
	IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE;
	SFS:(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(316002)(16526019)(956004)(2616005)(53546011)(8936002)(5660300002)(86362001)(186003)(52116002)(16576012)(6486002)(786003)(31686004)(66476007)(31696002)(75432002)(26005)(6916009)(66946007)(83380400001)(36756003)(2906002)(66556008)(966005)(478600001)(8676002)(43740500002)(45980500001);
	DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData:	=?Windows-1252?Q?SXI+W31Ge13pvn972rjWdnVo+tBCAMid5DIOnDs/UFr+wuUwiU7sn6w0?=
	=?Windows-1252?Q?5qV9n/Ii+pjQlGD7WQjuqkLY94pouLM4btWp1qAZzmRceZd8wB6zR87a?=
	=?Windows-1252?Q?QMs6REsMU3ijzSGlmcMTl6kzkFWEM72Fx4AjyPmXdluTLRuC7KwMhXZK?=
	=?Windows-1252?Q?FOBde/Rq2SvDF2AzEcEUiwh4aSBluQI1hFPJyOoW70S9MIScIb/Ya1Nr?=
	=?Windows-1252?Q?eNfXxeoDyeezf2J1sLBHa1f9UGn6UQnED6BXAAKHOhUtY1G74+Ik8IDW?=
	=?Windows-1252?Q?tygALXGAj+XENRIQxn4pqPga4LGTWLtyLdY5mIE7Qkifd4Ydr/aXiEgQ?=
	=?Windows-1252?Q?kpwa3yuChz3PJ/aoYWmXeEQf5dGtXCSTwP/oq+BcHLgtuI4Bajcd2IcD?=
	=?Windows-1252?Q?AKk7cQOXQi1lkr6BE0fPrw/3FbsvMrUJ9WxrF8icVEBzTV9aL5Ko37v0?=
	=?Windows-1252?Q?1iLVX97PhQjJtEUVcJZ8ByVZI5eUUvMWcGzkIPdm7/FrYOJOuXwhKOHt?=
	=?Windows-1252?Q?fh9zmXjUKZWNfHJaxGbzdN7aD09rQaZxPlHT1ZHkEAT25pT4jOvY9Nqo?=
	=?Windows-1252?Q?qfwVFubMTRJ/psNtrRdZRPpIIoCl9lu2dJtX0qoI9RI5Ejn99UZBDhAV?=
	=?Windows-1252?Q?DsPRX+yP46zKZcQsHmJ6s0QZR2bkX9VNlvfmbBHwhuRjDvXAB2JEwqEY?=
	=?Windows-1252?Q?ienKMS7u0wmG54PnePeNNdMtLsqeMrHTjgYF102w8QfcessFHftxe9Zt?=
	=?Windows-1252?Q?JLxqygaXR5Ut/JI++1/A0wBrWOglIZ4jms/1IFZoY4q5BLbsHXe0QcN6?=
	=?Windows-1252?Q?sLu8ZpfN+K2UB0PI+cmT6kSrOlaBdENSWOVWz/btNIrMonyNVZq+/Fsa?=
	=?Windows-1252?Q?ddJLOt13wpaWxq74pgNeenUsqhsDRo8fH1gWOHmTB9GbALK6NdKKSKn8?=
	=?Windows-1252?Q?VJmUBfsWwPymhtH36YvgfRQ799KezTkfWa7SPm/rBUnn4CZ/XjIiOdbZ?=
	=?Windows-1252?Q?1hBU5hMttGvsB73gzsdL4lMPvYmv25pRKNh2oYwGcNkchTBJD656QPBc?=
	=?Windows-1252?Q?i0t9kOJpSyFY2EFo?=
X-OriginatorOrg:	cornell.edu
X-MS-Exchange-CrossTenant-AuthSource:	BN7PR04MB4388.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs:	Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime:	12 Jan 2021 17:49:48.8937 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader:	Hosted
X-MS-Exchange-CrossTenant-Id:	5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-Network-Message-Id:	c7ac6292-68a0-4b60-da29-08d8b72274dc
X-MS-Exchange-CrossTenant-MailboxType:	HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName:	HeYi+mVN8i2bNLP3HNaFPhi6odCdG0Yh2TnMRobGCA2qxrXpRRWQnhYjOcjuCbBH9T/M064uyYGF0LpBaf0h1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped:	BN8PR04MB6386
X-Spam-Status:	No, score=1.3 required=5.0 tests=BAYES_00, BODY_8BITS,
	DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER,
	NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS,
	TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Level:	*
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Ken Brown <kbrown AT cornell DOT edu>
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>
X-MIME-Autoconverted:	from quoted-printable to 8bit by delorie.com id 10CHoKlE027648

On 1/12/2021 12:15 PM, Corinna Vinschen wrote:
> On Jan 12 11:55, Ken Brown via Cygwin wrote:
>> On 1/11/2021 6:50 PM, Ken Brown via Cygwin wrote:
>>> On 1/11/2021 2:57 PM, Morgan King via Cygwin wrote:
>>>> Hello,
>>>>
>>>> I am experiencing the same issue with tar and I am able to reproduce
>>>> it following the steps at:
>>>> https://lists.gnu.org/archive/html/bug-tar/2011-08/msg00006.html
>>>>
>>>> This issue only appears to occur when using 32-bit Cygwin, I am
>>>> unable to reproduce it using 64-bit Cygwin.
>>>
>>> I can confirm this.  Running the tar command under gdb shows a problem
>>> at gnu/fchmodat.c:94:
>>>
>>> 94            if (S_ISLNK (st.st_mode))
>>>
>>> Here st is a stat structure for directory/1, so S_ISLNK() should be
>>> true.  It is indeed true on 64-bit Cygwin but not on 32-bit Cygwin.
>>> Someone needs to look more closely and find out why this happened.  I'll
>>> try to do it tomorrow if no one beats me to it.
>>
>> This appears to be a bug in fstat in 32-bit Cygwin.  Here's what I'm seeing
>> in gdb, using an unoptimized build of cygwin1.dll.  There is a call to
>> fstatat in the tar source file gnu/fchmodat.c:87.  This ultimately leads to
>> a call to fstat, whose definition in syscalls.cc is the following in the
>> 32-bit case:
> 
> No, wait.  struct stat == struct _stat64 since Cygwin 1.5.0!
> 
> With Cygwin 1.5.0, the old entry point fstat was only retained to serve
> old 32 bit applications buil.t under Cygwin 1.3.x or earlier.
> 
> Consequentially, newer 32 bit apps, built with Cygwin 1.5.0 or later,
> are redirected to fstat64, see NEW_FUNCTIONS in Makefile.in.
> 
> If tar is actually calling fstat, something fishy is going on.

It's not tar that's calling fstat, it's Cygwin's fstatat at syscalls.cc:4855. 
This appears to be a bug that I introduced in commit 84252946.  I'll fix it. 
Thanks for setting me straight.

Ken
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -