X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 3B9703857C75
Authentication-Results:	sourceware.org; dmarc=none (p=none dis=none)
	header.from=SystematicSw.ab.ca
Authentication-Results:	sourceware.org;
	spf=none smtp.mailfrom=brian DOT inglis AT systematicsw DOT ab DOT ca
X-Authority-Analysis:	v=2.4 cv=Q4RsX66a c=1 sm=1 tr=0 ts=5fda8fe2
	a=kiZT5GMN3KAWqtYcXc+/4Q==:117 a=kiZT5GMN3KAWqtYcXc+/4Q==:17
	a=r77TgQKjGQsHNAKrUKIA:9 a=uYT-Tk0qkVT609LjNaIA:9 a=QEXdDO2ut3YA:10
	a=tZm1DIR2umDfxGAvsy4A:9 a=B2y7HmGcmWMA:10 a=3y54CN4IUQMWsJZ1kNIA:9
To:	cygwin AT cygwin DOT com
References:	<1def9bc2-8e19-575d-547c-fa44a5c61f26 AT gmail DOT com>
	<95dbf69b-97ff-f465-477b-856bae857179 AT SystematicSw DOT ab DOT ca>
	<f75d6a4c-4283-ad56-65a0-7ff3e0346781 AT gmail DOT com>
From:	Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
Organization:	Systematic Software
Subject:	Re: cygwin-doc post install script failures
Message-ID:	<8d1f0f76-097c-12b0-691d-d677793abd34@SystematicSw.ab.ca>
Date:	Wed, 16 Dec 2020 15:53:20 -0700
User-Agent:	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
	Thunderbird/78.5.1
MIME-Version:	1.0
In-Reply-To:	<f75d6a4c-4283-ad56-65a0-7ff3e0346781@gmail.com>
X-CMAE-Envelope:	MS4xfIGf0eJOHwehIT7UEbHvwufo8v9dVUQKK6Ce20UCfhBTWCYsOCE7oMOQYQdJvuSAmpnsguvBBmQRpPy7OwwGJ9eQ4qsMFMH/riASYAu8OBIlGWYb/+0K
	swa/w2K93p+FJpnE46Vn3h7Q5rhkbfVaYolGdBfmuNglMktsU0qYuFzS4BEkzkSPM53lT0thWZsDn2vstc//0JuZrpHaHgUKKxI=
X-Spam-Status:	No, score=-10.6 required=5.0 tests=BAYES_00, BODY_8BITS,
	GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A,
	RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE,
	TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To:	cygwin AT cygwin DOT com
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

This is a multi-part message in MIME format.
--------------AFF59DB24E5C992A56C9933E
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 2020-12-15 13:51, Marco Atzeri via Cygwin wrote:
> On 15.12.2020 21:03, Brian Inglis wrote:
>> On 2020-12-15 01:43, Marco Atzeri via Cygwin wrote:
>>> Not a recent bug but annoying anyway
>>>
>>> It seems the post-install script is not considering that the
>>> installation can be in a disk different from C: , properly
>>> in this case D:
>>
>> The post-install script does not care as mkshortcut uses POSIX paths.
>> Could you please check your paths with:
>>
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$ which -a mkshortcut
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/usr/bin/mkshortcut
>=20
> all same
>=20
>>
>>> 2020/12/15 08:40:13 running: d:\cygwin32\bin\bash.exe --norc --noprof=
ile=20
>>> "/etc/postinstall/cygwin-doc.sh"
>>> mkshortcut: Saving "/cygdrive/c/ProgramData/Microsoft/Windows/Start=20
>>> Menu/Programs/D:/cygwin32/Cygwin (32-bit)/User Guide (PDF).lnk" faile=
d; does=20
>>> the target directory exist?
>>> mkshortcut: Saving "/cygdrive/c/ProgramData/Microsoft/Windows/Start=20
>>> Menu/Programs/D:/cygwin32/Cygwin (32-bit)/User Guide (HTML).lnk" fail=
ed; does=20
>>> the target directory exist?
>>
>> Please try:
>>
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$ sh --version
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0GNU bash, version 4.4.12(3)-release (x86=
_64-unknown-cygwin)
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0...
>>
>> Could you please try rerunning the p-i script under sh -vx and post th=
e=20
>> output, as I can not see any way to rearrange the inputs and outputs t=
o get=20
>> that result, unless read or mkshortcut are damaged!
>>
>>> $ ls "/cygdrive/c/ProgramData/Microsoft/Windows/Start Menu/Programs/"=
 | grep=20
>>> Cygwin
>>> Cygwin
>>> Cygwin (32-bit)
>>
>> $ ll "$(cygpath -A -P -U)"/Cygwin*
>>
>=20
> It works, but it is different from running under setup, as it is using
>=20
> /proc/cygdrive/c/Users/Marco/AppData/Roaming/Microsoft/Windows/Start=20
> Menu/Programs/Cygwin (32-bit)/

Thanks Marco,

Looks like problem may be memory allocation in mkshortcut.c(xstrndup), so=
 have=20
attached patches to apply to that source (from cygport? or amnually), and=
 to p-i=20
script to get strace.

So could you please apply the attached patch to /etc/postinstall/cygwin-d=
oc.sh,=20
and retry your manual p-i script rerun prefixed with CYGWINFORALL=3D-A=20
/etc/postinstall/cygwin-doc.sh (may need elevated admin rights), and save=
 that=20
strace output; then retry your cygwin-doc setup, and save that strace out=
put;=20
then apply the attached mkshortcut.c patch, rebuild mkshortcut, retry you=
r=20
cygwin-doc setup, and save that strace output.

Hopefully the last try will no longer fail, otherwise I will have to set =
up my=20
environment to reproduce the error.

--=20
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]

--------------AFF59DB24E5C992A56C9933E
Content-Type: text/plain; charset=UTF-8;
 name="etc.postinstall.cygwin-doc.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="etc.postinstall.cygwin-doc.patch"

LS0tIGEvZXRjL3Bvc3RpbnN0YWxsL2N5Z3dpbi1kb2Muc2gJMjAyMC0wNy0wNyAwNDozMDoz
Mi44Njg0NDU5MDAgLTA2MDAKKysrIGIvZXRjL3Bvc3RpbnN0YWxsL2N5Z3dpbi1kb2Muc2gJ
MjAyMC0xMi0xNiAxNTozODowMy4zMTg4NzA4MDAgLTA3MDAKQEAgLTUzLDcgKzUzLDggQEAg
ZmkKICMgY3JlYXRlIFVzZXIgR3VpZGUgYW5kIEFQSSBQREYgYW5kIEhUTUwgc2hvcnRjdXRz
CiB3aGlsZSByZWFkIHRhcmdldCBuYW1lIGRlc2MKIGRvCi0JWyAtciAiJHRhcmdldCIgXSAm
JiAkbWtzICRDWUdXSU5GT1JBTEwgLVAgLW4gIkN5Z3dpbiR7d293NjR9LyRuYW1lIiAtZCAi
JGRlc2MiIC0tICR0YXJnZXQKKwlbIC13IC90bXAvbWtzaG9ydGN1dC5zdHJhY2UgXSAmJiB0
cmFjZT0nJyB8fCB0cmFjZT0nL2Jpbi9zdHJhY2UgLW8gL3RtcC9ta3Nob3J0Y3V0LnN0cmFj
ZScKKwlbIC1yICIkdGFyZ2V0IiBdICYmICR0cmFjZSAkbWtzICRDWUdXSU5GT1JBTEwgLVAg
LW4gIkN5Z3dpbiR7d293NjR9LyRuYW1lIiAtZCAiJGRlc2MiIC0tICR0YXJnZXQKIGRvbmUg
PDxFT0YKICRkb2MvY3lnd2luLXVnLW5ldC5wZGYJCVVzZXJcIEd1aWRlXCBcKFBERlwpICBD
eWd3aW5cIFVzZXJcIEd1aWRlXCBQREYKICRodG1sL2N5Z3dpbi11Zy1uZXQvaW5kZXguaHRt
bAlVc2VyXCBHdWlkZVwgXChIVE1MXCkgQ3lnd2luXCBVc2VyXCBHdWlkZVwgSFRNTAo=
--------------AFF59DB24E5C992A56C9933E
Content-Type: text/plain; charset=UTF-8;
 name="mkshortcut.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="mkshortcut.patch"

ZGlmZiAtLWdpdCBhL3NyYy9ta3Nob3J0Y3V0L21rc2hvcnRjdXQuYyBiL3NyYy9ta3Nob3J0
Y3V0L21rc2hvcnRjdXQuYwppbmRleCA2NzA3ZWI0M2UzZDAuLmY0ZWExY2MzOGI3YiAxMDA2
NDQKLS0tIG9yaWdzcmMvbWtzaG9ydGN1dC9ta3Nob3J0Y3V0LmMKKysrIHNyYy9ta3Nob3J0
Y3V0L21rc2hvcnRjdXQuYwpAQCAtMzgyLDcgKzM4Miw3IEBAIGV4aXQ6CiBzdGF0aWMgY2hh
ciAqCiB4c3RybmR1cCAoY29uc3QgY2hhciAqc3RyaW5nLCBzaXplX3QgbikKIHsKLSAgY2hh
ciAqcyA9IHN0cm5kdXAgKHN0cmluZywgbik7CisgIGNoYXIgKnMgPSBzdHJuZHVwIChzdHJp
bmcsIG4gKyAxKTsKICAgaWYgKCFzKQogICB7CiAgICAgZnByaW50ZiAoc3RkZXJyLCAiJXM6
IG91dCBvZiBtZW1vcnlcbiIsIHByb2dyYW1fbmFtZSk7CkBAIC0zOTUsNyArMzk1LDcgQEAg
c3RhdGljIGNoYXIgKgogeHN0cm5jYXQgKGNoYXIgKipkZXN0LCBjb25zdCBjaGFyICphZGQs
IHNpemVfdCBuKQogewogICBzaXplX3QgbGVuID0gc3RybGVuICgqZGVzdCkgKyBuICsgMTsK
LSAgY2hhciAqcyA9IChjaGFyICopIHJlYWxsb2MgKCpkZXN0LCBsZW4gKiBzaXplb2YgKGNo
YXIpKTsKKyAgY2hhciAqcyA9IHJlYWxsb2MgKCpkZXN0LCBsZW4pOwogICBpZiAoIXMpCiAg
IHsKICAgICBmcHJpbnRmIChzdGRlcnIsICIlczogb3V0IG9mIG1lbW9yeVxuIiwgcHJvZ3Jh
bV9uYW1lKTsK
--------------AFF59DB24E5C992A56C9933E
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--------------AFF59DB24E5C992A56C9933E--

- Raw text -