X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org B54DB396E455
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1599033275;
	bh=CDCfwTM3KiHMOnKW5IFfMvh3rrMRk4cZfE0I0nX3LHI=;
	h=Date:From:To:Subject:References:In-Reply-To:List-Id:
	List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	Reply-To:From;
	b=QGqNCnftMpof5LFyLLkA9PN7VFJfveHyzpPQn/ablsE/t66klMFOEMXucSKSr6QQh
	fHa3us2XxzJRs7XvKMpMDdrqgEg5QSlRNtejwCxSscLFC1FzDy+kN5ZWN+brB23Sp5
	ccsAY9Bl+kOfgGiTNFxgtFqxLv+vXZVKaxAiZH9I=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 375353846035
Authentication-Results:	sourceware.org;
	dmarc=none (p=none dis=none) header.from=cygwin.com
Authentication-Results:	sourceware.org;
	spf=fail smtp.mailfrom=corinna-cygwin AT cygwin DOT com
Date:	Wed, 2 Sep 2020 09:54:29 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: cpp /usr/include/threads.h fails; modfl segfaults
Message-ID:	<20200902075429.GE4127@calimero.vinschen.de>
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<02b16d2e-9d51-de58-807b-3b31b2565b59 DOT ref AT aol DOT com>
	<02b16d2e-9d51-de58-807b-3b31b2565b59 AT aol DOT com>
	<20200830130005 DOT GR3272 AT calimero DOT vinschen DOT de>
	<eba28e06-139b-0d01-afb5-81a67ba1ad16 AT SystematicSw DOT ab DOT ca>
	<20200831073500 DOT GU3272 AT calimero DOT vinschen DOT de>
	<36f6cc1b-1944-f1b6-b832-33205c08bbae AT SystematicSw DOT ab DOT ca>
	<20200831184517 DOT GF3272 AT calimero DOT vinschen DOT de>
	<140d7709-7db0-6935-15c1-786d392d0f53 AT SystematicSw DOT ab DOT ca>
	<20200831194153 DOT GH3272 AT calimero DOT vinschen DOT de>
	<e36b9548-58b5-b2f7-e5de-7a061c5f38ac AT SystematicSw DOT ab DOT ca>
MIME-Version:	1.0
In-Reply-To:	<e36b9548-58b5-b2f7-e5de-7a061c5f38ac@SystematicSw.ab.ca>
X-Provags-ID:	V03:K1:a8m/2/xqWvvjgyJcXpD9O6utbNyo0RAiRSEDvoiOnTfg9+Jmtbb
	eY29u5Km/lyH7w/qIYl5OeuabD4W8G5R/zdSbOxrMQuQ9SgO/Ako/9qXgmkr/s2MFOK9chY
	CCS4sFBAZNaAgHIBKsD/tJbdPRcZ+r+9o3cbjiogZfjIPh0RR2wRRftzdsRz3ep+87KkStd
	rnca5dLB0PVy/A3xXFXzA==
X-UI-Out-Filterresults:	notjunk:1;V03:K0:Q6wc3QX1/gs=:5XLcYy/ZQYJsX/rv6wwfI1
	Otd8BTNfjACwie5n6eM9Z/zZDMDKDwx3nlc//CiTMZ5XhmQaEvwkZ2GILpxi0rdB5scVGtV3v
	OkHNlNwwDAi/bOfP+WtiTBquvfbJeJdDQuRdrAuKQR2JVEcOHZ0RcVhrkt0faria3Ks+TTOs/
	FDr4BVJTRnAV1e/kJOF5j7mEn9z7r5mKZ91NuzHD+qqH0J2VpQcIWmJjPb4eDofRWcOj4+lE0
	nTY0d7MQR2PQCuGy5w5YmbtXXnDe2Nnllfh3ab9GnPcrif7N9j5d3FeWk0erBjaox2x8dVAPs
	iQTHFTzJvMxcA8DJQYuBg+uk873/dwAq0sskwnbciaBN5HAG8B7stawQtavk9f7Mhu4tJKuZz
	VEpRM+wnCKpqgRPnTwwMDe3Jom+f3zbVE3L/aiCm6w0ULepjsxgP7ORIAAAfnOHonkzoieiI4
	Tc4NW6nzN85lMi26qpTmRE7W+YVw9j4dLba4wYfgfhyLGv1tQNXzNUU2xLRUlTBpbBD4Je4pI
	68enOax1iyjDG6pVMmHhZN/7XSILe8JJ5Wf6kPmB4xg8wHWbRHX9GQZLX1aPQD5azD9OwiwZh
	Y//+SuuBR2niUJMtPQTrj5qtiS2ztDj8FTbVTS06xxgvHBsdukn7wdwwKu8CRl1nGMmfmCHFx
	ue0MtxbgTk8adEOAgsbg3A+xJWgLne2l5CHXi7frMadaXvJIZQKpr6/6n3T0nB9/D8PKGGAfC
	DfDV7JcCXbV6fx3bHu6xt3YcCYsSFjzcLhdKop0k3w7j7aAh/fj6dTxNZUh1az2aTMEaEBdGh
	MZY4KYyV57H0vDpUcZK9pkXVRPVP4ZBSs8SBCD6qJe5U4OcRJD/VC6V/+By/+/04lAKtSMkZW
	J6as0hC8rr6d1YYColqA==
X-Spam-Status:	No, score=-100.5 required=5.0 tests=BAYES_00,
	GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL,
	TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To:	cygwin AT cygwin DOT com
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

On Sep  1 11:28, Brian Inglis wrote:
> On 2020-08-31 13:41, Corinna Vinschen wrote:
> > On Aug 31 13:24, Brian Inglis wrote:
> >>>> The upstream patch changed only amd64/x86_64 code sequences for multiple modules
> >>>> including modfl, and left i386/x86 untouched for those modules.
> >>
> >> Just pointing out that they only modify their amd64/x86_64 code which doesn't
> >> push/pop rax/eax:
> > 
> > Where are you looking at?  As you could see from my output, I was
> > looking at the master branch of the upstream repo.
> 
> Sorry I didn't see your point there as I wasn't aware there were SF repos.
> 
> > This lengthy discussion for a minor asm snippet doesn't make any sense.
> > If you think this is wrong, send patches to cygwin-patches and explain
> > where you got it from, preferrably as a git patch from the upstream
> > repo.
> 
> Sorry for wasting your time.
> I was looking at the bug/patch content and didn't realize someone later added a
> bogus clobber on their x86 code path.

No, really, patches are super great and *I* know *you* know how it works.

Given this code is at least questionable, what about sending a patch to
upstream and a matching patch to cygwin-patches?  The upstream mailing
list is at mingw-w64-public AT lists DOT sourceforge DOT net.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -