X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 426883850438
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1598902918;
	bh=3Ea6L5OHDZzvIZOYLtjmR8rMfFWXHjB+xWAQ0sCjz0w=;
	h=Date:From:To:Subject:References:In-Reply-To:List-Id:
	List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	Reply-To:From;
	b=K0Onj9tr5B/Uk9QX9TSoDi/Alk3XTtmjTkzsw15DBSSfhnY+fu9KcuJAUBTGXhiGa
	PYGeKrExcMKoXjSqkL/gSBnI2D9mKm7jbWGsUnf5AWmmi7Ijh4DP2pC6nO9wmyz9pe
	ye73VsxPEVpx4Q2V5YL3TjBi65NxatjLEI/W4NC8=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 87B49385783C
Authentication-Results:	sourceware.org;
	dmarc=none (p=none dis=none) header.from=cygwin.com
Authentication-Results:	sourceware.org;
	spf=fail smtp.mailfrom=corinna-cygwin AT cygwin DOT com
Date:	Mon, 31 Aug 2020 21:41:53 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: cpp /usr/include/threads.h fails; modfl segfaults
Message-ID:	<20200831194153.GH3272@calimero.vinschen.de>
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<02b16d2e-9d51-de58-807b-3b31b2565b59 DOT ref AT aol DOT com>
	<02b16d2e-9d51-de58-807b-3b31b2565b59 AT aol DOT com>
	<20200830130005 DOT GR3272 AT calimero DOT vinschen DOT de>
	<eba28e06-139b-0d01-afb5-81a67ba1ad16 AT SystematicSw DOT ab DOT ca>
	<20200831073500 DOT GU3272 AT calimero DOT vinschen DOT de>
	<36f6cc1b-1944-f1b6-b832-33205c08bbae AT SystematicSw DOT ab DOT ca>
	<20200831184517 DOT GF3272 AT calimero DOT vinschen DOT de>
	<140d7709-7db0-6935-15c1-786d392d0f53 AT SystematicSw DOT ab DOT ca>
MIME-Version:	1.0
In-Reply-To:	<140d7709-7db0-6935-15c1-786d392d0f53@SystematicSw.ab.ca>
X-Provags-ID:	V03:K1:M2EDILts1hujxQJ2+oa/KseKIw34r1Oar9B9KV1PqxE65cF8fk7
	dZ8rmUkUIkic0xpZ2XvFyH+on2XSiKIKs4R9GbcK7nJDac8zHSgmEFT8vH+SBZmOzUsIKPt
	vdWyCi6/Gi+PyE+hGm385KBudtrM7Ovqd7rIkSEV7qwk0MpTbV4hkmXyFiJKUpfp9yn6i8G
	mOvMY4zBqq1hqJzLJxKQQ==
X-UI-Out-Filterresults:	notjunk:1;V03:K0:qmXXPpbJzIQ=:9maB6mqNI5kt/WDKCAeFZm
	RMNyGPydcfUboQz9UOvHtKpKgGftXKjvIhx9QghRx6UCvAu9UWnGWRpA4jIzbZT+vXk95iVfc
	klK4YyU5nCJCdevbW4vlHNDkuUMuCo3R5GZTfMkgHhU4/mcNXc55/PROcXLRwytWV5SdcaCn4
	6UNH53G4IMZF5G6q9IHxXmHGGqiURb3EBO722l+6M6U1+/GoVCwGdSntiPKSW7XRexEMBuG9T
	SsmQA7/VvdFZVcuwrTRuvybDoLEt6jaAnVxQG4k0btUyCi1Vi3cQoam/73ReqkXWlXhdcwmaf
	prJ7yYNCt5aDYo2r+6XQl8gSVWICqZzVc6InPR4PeaZOq7B6OUqxElXrXY5xBi4MAIttzm5tm
	XbnCJ6rA14uaEmn05NgSsWfhBzTmYBxs3KrXRonJGik86cN42biM8XpR0ANtpyDA+JTsVh0VK
	1QFWToN6pH01SUkM4+Yba4PlNorql64rq3BCaIC4Irg48JqzJKGQ5WXJUK44pcjlxhmCLX6s0
	cb0CC3tW9xobvyggPT42ku+Dlkzlf2xtFo9nmkVNvflG1CB+jT2sdT9eApXOf9yCE0NY3Xkv1
	ya2LTkezTRbozFSkMeAk5eq8YLKVJEESmSTt7uRMrGHqh55bJDoXtKLmuJnTPlQQRO9gLB2tA
	Pm21r+0mn6FxFuz1owKOlci1twCEksQOptSTIL/rJNp43tR6biNlKuE48CvK57p667rNN9qs1
	zTM71psM62p5AGREoIXzwKs6W6TnBDE/VFjaus2B9GDYlHMWrebA1rR+LWfuvejw7n1xQ61yJ
	BpmyJKpvjvpBWFmKJsT3u9l0iPZcYpkQpFr9G42hQF92qg0qkaucy6o9/NHPsvDKo+N4DiUBx
	9K/A9kux2Cz+dniLa1lA==
X-Spam-Status:	No, score=-100.3 required=5.0 tests=BAYES_00,
	GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS,
	RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL,
	TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To:	cygwin AT cygwin DOT com
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>
X-MIME-Autoconverted:	from base64 to 8bit by delorie.com id 07VJgOOM002000

On Aug 31 13:24, Brian Inglis wrote:
> On 2020-08-31 12:45, Corinna Vinschen wrote:
> > On Aug 31 09:37, Brian Inglis wrote:
> >> On 2020-08-31 01:35, Corinna Vinschen wrote:
> >>> On Aug 30 14:39, Brian Inglis wrote:
> >>>> On 2020-08-30 07:00, Corinna Vinschen wrote:
> >>>>> On Aug 29 08:52, airplanemath via Cygwin wrote:
> >>>>>> I have two reports.  A brief description of the system:
> >>>>>> $ uname -a | sed "s/${HOSTNAME}/\${HOSTNAME}/g"
> >>>>>> CYGWIN_NT-10.0 ${HOSTNAME} 3.1.7(0.340/5/3) 2020-08-22 17:48 x86_64 Cygwin
> >>>> ...
> >>>>>> $ cat test.c
> >>>>>> #include <math.h>
> >>>>>> #include <stdio.h>
> >>>>>> #include <stdlib.h>
> >>>>>>
> >>>>>> int main(int argc, char *argv[]) {
> >>>>>>   long double a, b, c;
> >>>>>>   char *num_end = NULL;
> >>>>>>   a = b = c = 0.0L;
> >>>>>>   if (argc != 2) {
> >>>>>>     fprintf(stderr, "Usage: %s NUMBER\n", argv[0]);
> >>>>>>     exit(1);
> >>>>>>   }
> >>>>>>   a = strtold(argv[1], &num_end);
> >>>>>>   b = modfl(a, &c);
> >>>>>>   printf("%Lf %Lf %Lf\n", a, b, c);
> >>>>>>   return 0;
> >>>>>> }
> >>>>>
> >>>>> This is a bug in the assembler code taken from Mingw-w64.  The bug has
> >>>>> been fixed upstream, so I just pulled in the upstream fixes.
> >>>>
> >>>> The 64 bit fix doesn't pop eax but *now* flags eax as clobbered, whereas the 32
> >>>> bit fix both pops and *now* flags eax as clobbered, which it really doesn't need
> >>>> to do. Is this inconsistent treatment correct?
> >>>
> >>> You may be right that this is not necessary on i686, but it doesn't
> >>> hurt either and I'd like to stick to the upstream code if possible.
> >>
> >> The upstream patch changed only amd64/x86_64 code sequences for multiple modules
> >> including modfl, and left i386/x86 untouched for those modules.
> 
> Just pointing out that they only modify their amd64/x86_64 code which doesn't
> push/pop rax/eax:

Where are you looking at?  As you could see from my output, I was
looking at the master branch of the upstream repo.

This lengthy discussion for a minor asm snippet doesn't make any sense.
If you think this is wrong, send patches to cygwin-patches and explain
where you got it from, preferrably as a git patch from the upstream
repo.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -