X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 61B2E3851C18
Authentication-Results:	sourceware.org; dmarc=none (p=none dis=none)
	header.from=SystematicSw.ab.ca
Authentication-Results:	sourceware.org;
	spf=none smtp.mailfrom=brian DOT inglis AT systematicsw DOT ab DOT ca
X-Authority-Analysis:	v=2.3 cv=OubUNx3t c=1 sm=1 tr=0
	a=kiZT5GMN3KAWqtYcXc+/4Q==:117 a=kiZT5GMN3KAWqtYcXc+/4Q==:17
	a=r77TgQKjGQsHNAKrUKIA:9 a=RZ24vCjvlsqmbDxLIRQA:9 a=ckTiJ0K9ZgkC0Hdy:21
	a=Uy8aXEpxEN2xdHnw:21 a=QEXdDO2ut3YA:10 a=OoxchlZzcn1IBCVA_1YA:9
	a=B2y7HmGcmWMA:10
Subject:	Re: cpp /usr/include/threads.h fails; modfl segfaults
To:	cygwin AT cygwin DOT com
References:	<02b16d2e-9d51-de58-807b-3b31b2565b59 DOT ref AT aol DOT com>
	<02b16d2e-9d51-de58-807b-3b31b2565b59 AT aol DOT com>
	<20200830130005 DOT GR3272 AT calimero DOT vinschen DOT de>
	<eba28e06-139b-0d01-afb5-81a67ba1ad16 AT SystematicSw DOT ab DOT ca>
	<20200831073500 DOT GU3272 AT calimero DOT vinschen DOT de>
	<36f6cc1b-1944-f1b6-b832-33205c08bbae AT SystematicSw DOT ab DOT ca>
	<20200831184517 DOT GF3272 AT calimero DOT vinschen DOT de>
From:	Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
Autocrypt:	addr=Brian DOT Inglis AT SystematicSw DOT ab DOT ca; prefer-encrypt=mutual;
	keydata=
	mDMEXopx8xYJKwYBBAHaRw8BAQdAnCK0qv/xwUCCZQoA9BHRYpstERrspfT0NkUWQVuoePa0
	LkJyaWFuIEluZ2xpcyA8QnJpYW4uSW5nbGlzQFN5c3RlbWF0aWNTdy5hYi5jYT6IlgQTFggA
	PhYhBMM5/lbU970GBS2bZB62lxu92I8YBQJeinHzAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQW
	AgMBAh4BAheAAAoJEB62lxu92I8Y0ioBAI8xrggNxziAVmr+Xm6nnyjoujMqWcq3oEhlYGAO
	WacZAQDFtdDx2koSVSoOmfaOyRTbIWSf9/Cjai29060fsmdsDLg4BF6KcfMSCisGAQQBl1UB
	BQEBB0Awv8kHI2PaEgViDqzbnoe8B9KMHoBZLS92HdC7ZPh8HQMBCAeIfgQYFggAJhYhBMM5
	/lbU970GBS2bZB62lxu92I8YBQJeinHzAhsMBQkJZgGAAAoJEB62lxu92I8YZwUBAJw/74rF
	IyaSsGI7ewCdCy88Lce/kdwX7zGwid+f8NZ3AQC/ezTFFi5obXnyMxZJN464nPXiggtT9gN5
	RSyTY8X+AQ==
Organization:	Systematic Software
Message-ID:	<140d7709-7db0-6935-15c1-786d392d0f53@SystematicSw.ab.ca>
Date:	Mon, 31 Aug 2020 13:24:13 -0600
User-Agent:	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
	Thunderbird/68.12.0
MIME-Version:	1.0
In-Reply-To:	<20200831184517.GF3272@calimero.vinschen.de>
X-CMAE-Envelope:	MS4wfFu5mRj3YdDbuLX+McHQ/BdXtSksaXAMpcvYPcg/iZdZCElQAsDPG1a67JtOnlGoX4wQb3m/F7fV/owdzBAYQquMeiB6J08F+hCfBv/LaMRdHCBFItrG
	a7taV2mYNcFBMzBS7b9VsdOl3w4laqN8myJ1LEWTyEhvPnlgAwdHEm9/hWGPqyZfaqc+h46WdQ8rKg==
X-Spam-Status:	No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0,
	KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_LOW,
	SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To:	cygwin AT cygwin DOT com
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

This is a multi-part message in MIME format.
--------------E415FD69CD272F70E35301E3
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2020-08-31 12:45, Corinna Vinschen wrote:
> On Aug 31 09:37, Brian Inglis wrote:
>> On 2020-08-31 01:35, Corinna Vinschen wrote:
>>> On Aug 30 14:39, Brian Inglis wrote:
>>>> On 2020-08-30 07:00, Corinna Vinschen wrote:
>>>>> On Aug 29 08:52, airplanemath via Cygwin wrote:
>>>>>> I have two reports.=C2=A0 A brief description of the system:
>>>>>> $ uname -a | sed "s/${HOSTNAME}/\${HOSTNAME}/g"
>>>>>> CYGWIN_NT-10.0 ${HOSTNAME} 3.1.7(0.340/5/3) 2020-08-22 17:48 x86_6=
4 Cygwin
>>>> ...
>>>>>> $ cat test.c
>>>>>> #include <math.h>
>>>>>> #include <stdio.h>
>>>>>> #include <stdlib.h>
>>>>>>
>>>>>> int main(int argc, char *argv[]) {
>>>>>> =C2=A0 long double a, b, c;
>>>>>> =C2=A0 char *num_end =3D NULL;
>>>>>> =C2=A0 a =3D b =3D c =3D 0.0L;
>>>>>> =C2=A0 if (argc !=3D 2) {
>>>>>> =C2=A0=C2=A0=C2=A0 fprintf(stderr, "Usage: %s NUMBER\n", argv[0]);
>>>>>> =C2=A0=C2=A0=C2=A0 exit(1);
>>>>>> =C2=A0 }
>>>>>> =C2=A0 a =3D strtold(argv[1], &num_end);
>>>>>> =C2=A0 b =3D modfl(a, &c);
>>>>>> =C2=A0 printf("%Lf %Lf %Lf\n", a, b, c);
>>>>>> =C2=A0 return 0;
>>>>>> }
>>>>>
>>>>> This is a bug in the assembler code taken from Mingw-w64.  The bug =
has
>>>>> been fixed upstream, so I just pulled in the upstream fixes.
>>>>
>>>> The 64 bit fix doesn't pop eax but *now* flags eax as clobbered, whe=
reas the 32
>>>> bit fix both pops and *now* flags eax as clobbered, which it really =
doesn't need
>>>> to do. Is this inconsistent treatment correct?
>>>
>>> You may be right that this is not necessary on i686, but it doesn't
>>> hurt either and I'd like to stick to the upstream code if possible.
>>
>> The upstream patch changed only amd64/x86_64 code sequences for multip=
le modules
>> including modfl, and left i386/x86 untouched for those modules.

Just pointing out that they only modify their amd64/x86_64 code which doe=
sn't
push/pop rax/eax:

diff -ru mingw-w64-v4.0.2/mingw-w64-crt/math/modfl.c
mingw-w64-v4.0.2-patched/mingw-w64-crt/math/modfl.c
--- mingw-w64-v4.0.2/mingw-w64-crt/math/modfl.c	2015-04-11 11:37:30.00000=
0000 -0400
+++ mingw-w64-v4.0.2-patched/mingw-w64-crt/math/modfl.c	2015-05-07
11:05:57.000000000 -0400
@@ -21,7 +21,7 @@
     "fldcw (%%rsp)\n"
     "frndint\n"
     "fldcw 4(%%rsp)\n"
-    "addq $8, %%rsp\n" : "=3Dt" (int_part) : "0" (value)); /* round */
+    "addq $8, %%rsp\n" : "=3Dt" (int_part) : "0" (value) : "eax"); /* ro=
und */
 #elif defined(_X86_) || defined(__i386__)
   asm ("push %%eax\n\tsubl $8, %%esp\n"
     "fnstcw 4(%%esp)\n"

and their other patches do exactly the same for modf.c and modff.c, and n=
ot
their i386/x86 code which pushes/pops eax; where you do (adding lines bac=
k for
context) mark eax as clobbered after a pop in x86 patch:

> diff --git a/mingw-w64-crt/math/modfl.c b/mingw-w64-crt/math/modfl.c
> index af75a8b8cf60..ef1ab16ce256 100644
> --- a/mingw-w64-crt/math/modfl.c
> +++ b/mingw-w64-crt/math/modfl.c
#if defined(_AMD64_) || defined(__x86_64__)
     asm volatile ("subq $8, %%rsp\n"
       "fnstcw 4(%%rsp)\n"
       "movzwl 4(%%rsp), %%eax\n"
       "orb $12, %%ah\n"
       "movw %%ax, (%%rsp)\n"
> @@ -21,7 +21,7 @@ modfl (long double value, long double* iptr)
>      "fldcw (%%rsp)\n"
>      "frndint\n"
>      "fldcw 4(%%rsp)\n"
> -    "addq $8, %%rsp\n" : "=3Dt" (int_part) : "0" (value)); /* round */
> +    "addq $8, %%rsp\n" : "=3Dt" (int_part) : "0" (value) : "eax"); /* =
round */
>  #elif defined(_X86_) || defined(__i386__)
>    asm ("push %%eax\n\tsubl $8, %%esp\n"
>      "fnstcw 4(%%esp)\n"
       "movzwl 4(%%esp), %%eax\n"
       "orb $12, %%ah\n"
       "movw %%ax, (%%esp)\n"
> @@ -31,7 +31,7 @@ modfl (long double value, long double* iptr)
>      "fldcw (%%esp)\n"
>      "frndint\n"
>      "fldcw 4(%%esp)\n"
> -    "addl $8, %%esp\n\tpop %%eax\n" : "=3Dt" (int_part) : "0" (value))=
; /* round */
> +    "addl $8, %%esp\n\tpop %%eax\n" : "=3Dt" (int_part) : "0" (value) =
: "eax"); /* round */

--=20
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]

--------------E415FD69CD272F70E35301E3
Content-Type: text/plain; charset=UTF-8;
 name="mingw-w64-v4.0.2.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="mingw-w64-v4.0.2.patch"

ZGlmZiAtcnUgbWluZ3ctdzY0LXY0LjAuMi9taW5ndy13NjQtY3J0L21hdGgvbW9kZmwuYyBt
aW5ndy13NjQtdjQuMC4yLXBhdGNoZWQvbWluZ3ctdzY0LWNydC9tYXRoL21vZGZsLmMKLS0t
IG1pbmd3LXc2NC12NC4wLjIvbWluZ3ctdzY0LWNydC9tYXRoL21vZGZsLmMJMjAxNS0wNC0x
MSAxMTozNzozMC4wMDAwMDAwMDAgLTA0MDAKKysrIG1pbmd3LXc2NC12NC4wLjItcGF0Y2hl
ZC9taW5ndy13NjQtY3J0L21hdGgvbW9kZmwuYwkyMDE1LTA1LTA3IDExOjA1OjU3LjAwMDAw
MDAwMCAtMDQwMApAQCAtMjEsNyArMjEsNyBAQAogICAgICJmbGRjdyAoJSVyc3ApXG4iCiAg
ICAgImZybmRpbnRcbiIKICAgICAiZmxkY3cgNCglJXJzcClcbiIKLSAgICAiYWRkcSAkOCwg
JSVyc3BcbiIgOiAiPXQiIChpbnRfcGFydCkgOiAiMCIgKHZhbHVlKSk7IC8qIHJvdW5kICov
CisgICAgImFkZHEgJDgsICUlcnNwXG4iIDogIj10IiAoaW50X3BhcnQpIDogIjAiICh2YWx1
ZSkgOiAiZWF4Iik7IC8qIHJvdW5kICovCiAjZWxpZiBkZWZpbmVkKF9YODZfKSB8fCBkZWZp
bmVkKF9faTM4Nl9fKQogICBhc20gKCJwdXNoICUlZWF4XG5cdHN1YmwgJDgsICUlZXNwXG4i
CiAgICAgImZuc3RjdyA0KCUlZXNwKVxuIgpkaWZmIC1ydSBtaW5ndy13NjQtdjQuMC4yL21p
bmd3LXc2NC1jcnQvbWF0aC9tb2RmLmMgbWluZ3ctdzY0LXY0LjAuMi1wYXRjaGVkL21pbmd3
LXc2NC1jcnQvbWF0aC9tb2RmLmMKLS0tIG1pbmd3LXc2NC12NC4wLjIvbWluZ3ctdzY0LWNy
dC9tYXRoL21vZGYuYwkyMDE1LTA0LTExIDExOjM3OjMwLjAwMDAwMDAwMCAtMDQwMAorKysg
bWluZ3ctdzY0LXY0LjAuMi1wYXRjaGVkL21pbmd3LXc2NC1jcnQvbWF0aC9tb2RmLmMJMjAx
NS0wNS0wNyAxMTowNTo1Ny4wMDAwMDAwMDAgLTA0MDAKQEAgLTIxLDcgKzIxLDcgQEAKICAg
ICAiZmxkY3cgKCUlcnNwKVxuIgogICAgICJmcm5kaW50XG4iCiAgICAgImZsZGN3IDQoJSVy
c3ApXG4iCi0gICAgImFkZHEgJDgsICUlcnNwXG4iIDogIj10IiAoaW50X3BhcnQpIDogIjAi
ICh2YWx1ZSkpOyAvKiByb3VuZCAqLworICAgICJhZGRxICQ4LCAlJXJzcFxuIiA6ICI9dCIg
KGludF9wYXJ0KSA6ICIwIiAodmFsdWUpIDogImVheCIpOyAvKiByb3VuZCAqLwogI2VsaWYg
ZGVmaW5lZChfWDg2XykgfHwgZGVmaW5lZChfX2kzODZfXykKICAgYXNtICgicHVzaCAlJWVh
eFxuXHRzdWJsICQ4LCAlJWVzcFxuIgogICAgICJmbnN0Y3cgNCglJWVzcClcbiIKZGlmZiAt
cnUgbWluZ3ctdzY0LXY0LjAuMi9taW5ndy13NjQtY3J0L21hdGgvbW9kZmYuYyBtaW5ndy13
NjQtdjQuMC4yLXBhdGNoZWQvbWluZ3ctdzY0LWNydC9tYXRoL21vZGZmLmMKLS0tIG1pbmd3
LXc2NC12NC4wLjIvbWluZ3ctdzY0LWNydC9tYXRoL21vZGZmLmMJMjAxNS0wNC0xMSAxMToz
NzozMC4wMDAwMDAwMDAgLTA0MDAKKysrIG1pbmd3LXc2NC12NC4wLjItcGF0Y2hlZC9taW5n
dy13NjQtY3J0L21hdGgvbW9kZmYuYwkyMDE1LTA1LTA3IDExOjA1OjU3LjAwMDAwMDAwMCAt
MDQwMApAQCAtMjIsNyArMjIsNyBAQAogICAgICJmbGRjdyAoJSVyc3ApXG4iCiAgICAgImZy
bmRpbnRcbiIKICAgICAiZmxkY3cgNCglJXJzcClcbiIKLSAgICAiYWRkcSAkOCwgJSVyc3Bc
biIgOiAiPXQiIChpbnRfcGFydCkgOiAiMCIgKHZhbHVlKSk7IC8qIHJvdW5kICovCisgICAg
ImFkZHEgJDgsICUlcnNwXG4iIDogIj10IiAoaW50X3BhcnQpIDogIjAiICh2YWx1ZSkgOiAi
ZWF4Iik7IC8qIHJvdW5kICovCiAjZWxpZiBkZWZpbmVkKF9YODZfKSB8fCBkZWZpbmVkKF9f
aTM4Nl9fKQogICBhc20gKCJwdXNoICUlZWF4XG5cdHN1YmwgJDgsICUlZXNwXG4iCiAgICAg
ImZuc3RjdyA0KCUlZXNwKVxuIgo=
--------------E415FD69CD272F70E35301E3
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--------------E415FD69CD272F70E35301E3--

- Raw text -