X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 2FF603858D37
Authentication-Results:	sourceware.org;
	dmarc=none (p=none dis=none) header.from=dinwoodie.org
Authentication-Results:	sourceware.org;
	spf=pass smtp.mailfrom=adam AT dinwoodie DOT org
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=dinwoodie.org; s=google;
	h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
	bh=SYRUpOid23hFcWjckcyZrOc0anBRGb9w96C7DDQdXRg=;
	b=MBftOhDHbz9RQ5cLOm59NRbQAj42dkIb8rzmDiAS/H0Keqkf5CebEnW/4G9+AhvgO0
	siyAMlittHc4Ae1pIEbKMZHa8m+aUM61uxbPW7hvT5GPBt8520NB8fURUqSCTyynv1d+
	7ITeOwzDC7FuNv1Elt7yB9qcm8GXDtuWntA1E=
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:references:in-reply-to:from:date
	:message-id:subject:to;
	bh=SYRUpOid23hFcWjckcyZrOc0anBRGb9w96C7DDQdXRg=;
	b=QRVHXWWDA7Z+dugoIk1nIHsVW2nKQHr8JSwtNSvFHJWzgheipNmHb6vsYl31v4v931
	e5JQEk/17nNJkZv9YIPUaInw+nCekCe07Eaja20VCq9saE/+ba+Vm8nlEhdGiKmmIqVO
	zh8ozLOunRLhrrEsba0K4djXP0lXX6+jFkqyY+jfs+js4rh0/BKwv9zNnR1d5xyd8JG9
	sVRwgtHs6kHFSc2LyGkcyOphOifNtilVds15dEdRGYO6QZM/6XmWiYmDdRxFNl2qhxwR
	7fd+D1eRZXWKQN4Om4yMKMzisB+KTK4h/L/meGYxMlpfQ7Urt0acTGUC18gDHtMYNOyU
	Dh5g==
X-Gm-Message-State:	AOAM533uadw7Nxc10d8A5Eu1lq2N8YRYo/gTGNMxbgsa+d4pO60hRfwe
	4AKb9SweHCKaXMVg2mR0Q+V1Ha7ERVlxUCHUahL0MCyoTsbOVw==
X-Google-Smtp-Source:	ABdhPJyCD7QOQq6uekVx2059EqFPxNWGk0x6zrcjWFHNqYDAt5ZzJeIMiiOM2oPbkNrnlUTSJV5lViOgFj7aphnVoew=
X-Received:	by 2002:ab0:298d:: with SMTP id u13mr5987505uap.50.1597606162300;
	Sun, 16 Aug 2020 12:29:22 -0700 (PDT)
MIME-Version:	1.0
References:	<announce DOT c4e534c5-4c2e-9c35-3674-5f652695d778 AT SystematicSw DOT ab DOT ca>
	<CA+kUOa=-AJxr_2TaZoNerOquMGR8FCzi7hg3DyuvntuQqpAVOg AT mail DOT gmail DOT com>
	<CA+kUOakEVPde-W_8jocGZBwNw=wRodKBySRgxAE7_AU8As7FDA AT mail DOT gmail DOT com>
	<4f1d6241-c86b-f2f9-7b49-a9f5b998b0eb AT SystematicSw DOT ab DOT ca>
	<53c7f2a7-3bd8-f90c-b574-969d6b31f300 AT cornell DOT edu>
	<b66aea8b-2764-357c-8602-0a2e780bc90f AT SystematicSw DOT ab DOT ca>
	<d66364d2-06c4-3f8e-4989-2426ec9fde9d AT cornell DOT edu>
	<71031f78-b1be-aec2-4e54-72ff49e07543 AT SystematicSw DOT ab DOT ca>
	<11d99d00-55fb-f6a2-893d-f5ebb6e7a14b AT cornell DOT edu>
	<CA+kUOakP-dfBOfMJ+HrN2cfUfmzWOidO08ios+7kBCbmP+Yo6A AT mail DOT gmail DOT com>
	<8c14a6d0-7c52-ee29-5026-a306166c2e87 AT SystematicSw DOT ab DOT ca>
	<241cc39e-9c9b-58a4-c09d-778b3b84f455 AT SystematicSw DOT ab DOT ca>
In-Reply-To:	<241cc39e-9c9b-58a4-c09d-778b3b84f455@SystematicSw.ab.ca>
From:	Adam Dinwoodie <adam AT dinwoodie DOT org>
Date:	Sun, 16 Aug 2020 20:28:46 +0100
Message-ID:	<CA+kUOan3Td8gQCJrQDRVsTBDU5=8j2diaZ6=No-ZnW4s15U=bw@mail.gmail.com>
Subject:	Re: [ANNOUNCEMENT] Updated: curl 7.71.1-2
To:	cygwin AT cygwin DOT com
X-Spam-Status:	No, score=-0.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE,
	SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

On Sat, 15 Aug 2020 at 23:45, Brian Inglis wrote:
>
> On 2020-08-11 16:00, Brian Inglis wrote:
> > On 2020-08-11 05:27, Adam Dinwoodie wrote:
> >> On Tue, 11 Aug 2020 at 12:14, Ken Brown via Cygwin wrote:
> >>>> In that case, it looks to me as if the generated curl-config --libs statements:
> >>>>
> >>>>          if test "Xyes" = "Xno" -o "Xyes" = "Xyes"; then
> >>>>            echo ${CURLLIBDIR}-lcurl -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto
> >>>> -lldap -llber -lbrotlidec -lbrotlidec -lz
> >>>>
> >>>> based on curl-config.in:
> >>>>
> >>>>          if test "X AT ENABLE_SHARED@" = "Xno" -o "X AT REQUIRE_LIB_DEPS@" = "Xyes"; then
> >>>>            echo ${CURLLIBDIR}-lcurl @LIBCURL_LIBS@
> >>>>
> >>>> REQUIRE_LIB_DEPS should be no, derived from configure.ac:
> >>>>
> >>>> if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" = "Xno"
> >>>> then
> >>>>      REQUIRE_LIB_DEPS=no
> >>>> else
> >>>>      REQUIRE_LIB_DEPS=yes
> >>>> fi
> >>>> AC_SUBST(REQUIRE_LIB_DEPS)
> >>>> AM_CONDITIONAL(USE_EXPLICIT_LIB_DEPS, test x$REQUIRE_LIB_DEPS = xyes)
> >>>>
> >>>> but for Cygwin link_all_deplibs remains defaulted to unknown, so either that
> >>>> variable should be set in configure, or that condition should perhaps be changed
> >>>> to:
> >>>>
> >>>> if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" != "Xyes"
> >>>>
> >>>> with appropriate bug reports and changes to be made upstream if possible.
> >>>
> >>> If you want to look into ways of fixing curl-config different from what Yaakov
> >>> did, that's fine; you're the maintainer.  All I did was look at Yaakov's patch
> >>> and port it to curl 7.71.1, that being a quick and easy way to fix the reported
> >>> problem.
> >>
> >> Someone else did raise this problem upstream at
> >> https://github.com/curl/curl/issues/5793, and the comments there imply
> >> they'd be interested in integrating patches Cygwin uses into the
> >> upstream code, although the upstream maintainers aren't going to do
> >> that without someone proactively submitting the patch to them.
> >
> > I'll copy these comments and suggestions and follow up there, as that appears to
> > be the official bug tracker, and they appear receptive to discussing and fixing
> > issues.
> >
> >> For my part, I'm not particularly fussed whether this is fixed with an
> >> upstream patch or a Cygwin patch; I just want my use cases to work,
> >> and as of 7.71.1-1 they don't. That said, my experience of being a
> >> package maintainer would lead me to want to submit patches upstream if
> >> at all possible, just to reduce the need to handle these sorts of
> >> problems. My inclination would be to restore the patched behaviour
> >> with Ken's new patch as a short-term fix, then get this submitted
> >> upstream so that in the long-term this patch can be retired.
> >
> > I did not see or get your original email, and could not reproduce your issue
> > using the current git source package, curl package, and cygport.
> > That could be due to two missing perl modules (solved in another sub-thread by
> > Achim).
> > Any suggestions as to what may be required to get curl-config to act up in a
> > build would be appreciated.
> > It is always easier to check if a problem is actually fixed when you can perform
> > an in situ regression test.
> > Running curl-config and reading the docs, it does not appear to me to be clearly
> > specified why and when dynamic and static library parameters are either built in
> > or generated, whereas the conditions for reproducing the output are well
> > specified for pkgconf/pkg-config.
> > That may become more apparent in follow ups on the bug tracker.
>
> Got help from Ken Brown on Github curl/curl autotools file patches and applied
> to upgraded curl 7.71.1-2 which fix the curl-config --libs issues and a make
> check test library build issue.
> Please update your curl and libcurl-devel packages and retry your builds.
> Patches should be applied upstream and included in next official curl release,
> so we should be able to drop local Cygwin patches, allowing you to more easily
> build your own Cygwin curl releases from upstream sources should you so desire.
> Also cygport update, patches, etc. are in the source package and have also been
> pushed to:
>
>         https://cygwin.com/git/?p=git/cygwin-packages/curl.git;a=summary
>
> FYI and if you want to plan any customizations to Cygwin sources.

Confirmed this resolves the Git build issues. Thank you!
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -