X-Recipient:	archive-cygwin AT delorie DOT com
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 2147A3857C5A
Authentication-Results:	sourceware.org;
	dmarc=none (p=none dis=none) header.from=ncsu.edu
Authentication-Results:	sourceware.org;
	spf=pass smtp.mailfrom=josh_thompson AT ncsu DOT edu
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncsu.edu; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version; bh=a4nLOcf+0fi3xqCPLqhXIxsGiBVWNU3Bxca8hBWxx7c=;
	b=E1yHjJMY8vaon6ErbJwSZ9BlOxF4mGbPGHjPAmD8AYlVNn5yTRRQRp6x3Elefo2ChZ
	Wx8ir/1nmO+kQ8rtKNTKqMPaL/ZTDXc28CkNTWoAblZ/YOyyXapeJsuUzcKGQHx7NDnX
	QXIgm1pUeAHVm74qqmpFqJktf++6DVZgbkujZKPTVL1bkbSz5wTcFuyqxwvaSD3JGABb
	foEFNEr9Hei0otZkQiecfeJ4fdJnyPyQ2sccasQVyTTOHWM7nls4e06PAxNXGgNFl7GN
	2dkSjQ3/M28dGn4JnSqpLMRKdj5TRYFA4Eq4+bZrnZdyOD02jIJ87MX/2rEmMLpiC2tu
	fszA==
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version;
	bh=a4nLOcf+0fi3xqCPLqhXIxsGiBVWNU3Bxca8hBWxx7c=;
	b=jbE6OZeukk+3PHkltVFJW1WvXJ8/c0dL/pRHEsSmfxOmoxj38XlkT9g3NIvuloMEtj
	p++68IJ84p+Gx+o26Gt9ZnDu28Lt2yMgrlF/NhwhiUpUftjpia/rSFx2NhB0g4xStcF8
	LmCsQb5/sj5Nte+LKPaC1b+sqanGz1TIyBvLQiy34jirF4FrjjQzpok/grIrPSiWYUdI
	+Kgqivt5pfiolpAGydKpwnvhSWq5wUXVYRag52wG9oslM5Sr+lSrT6bSM8+GA31p+XWT
	Kv4in/pQLjpblIMquB3vMzcCqCf7UAZHNt8sZLPUBf8MBV2iHsn5Yz4Enae0YftjOyOP
	dL4A==
X-Gm-Message-State:	AOAM5329Ia/aIpBIXzsQL3jcmUnHNTv5VmkVUApPVVLxUjr0iNTBe/qB
	J2/z1hTHzH+jpxZeo3hxblWxfxRyZfZrSdJNe3SnudLhbWV+fuxCneftuMXFbMz2FbPeBbuOjlo
	7fp44ZOw3BgNDYm6qDjIUq5CC/ac8wxy5vIan7aIGU902ZW/FLfSjeSNrZsQlYxY6tA==
X-Google-Smtp-Source:	ABdhPJxiewpKga7X/iM/B2DggAH6GdIwKRZjyH2epKRvNHvIgSdOyOamDetf3asdVkTaMDrZePmvXA==
X-Received:	by 2002:ac8:734b:: with SMTP id q11mr3862034qtp.176.1594044860861;
	Mon, 06 Jul 2020 07:14:20 -0700 (PDT)
From:	Josh Thompson <josh_thompson AT ncsu DOT edu>
To:	cygwin AT cygwin DOT com
Subject:	Re: change in handling quotes in cygwin package from 3.1.4-1 to
	3.1.5-1
Date:	Mon, 06 Jul 2020 10:14:12 -0400
Message-ID:	<3197699.QRb4To3urE@dvr>
In-Reply-To:	<20200706112247.GD514059@calimero.vinschen.de>
References:	<3394273 DOT JRUgpOGd2y AT dvr> <2825592 DOT AUrzYYFGSl AT dvr>
	<20200706112247 DOT GD514059 AT calimero DOT vinschen DOT de>
MIME-Version:	1.0
X-Spam-Status:	No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
	DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE,
	SPF_HELO_NONE, SPF_PASS,
	TVD_PH_BODY_ACCOUNTS_PRE autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<http://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<http://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Cc:	dev AT vcl DOT apache DOT org
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

--===============2926230496764487193==
Content-Type: multipart/signed; boundary="nextPart1897375.qy90bnlcM9"; micalg="pgp-sha1"; protocol="application/pgp-signature"

--nextPart1897375.qy90bnlcM9
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

> > On Monday, June 22, 2020 4:11:35 PM EDT Ken Brown wrote:
> > > On 6/15/2020 12:21 PM, Josh Thompson wrote:
> > > > We recently noticed a change in double quote (") handling that is
> > > > causing
> > > > a
> > > 
> > > > command we issue to fail.  The command is:
> > > [...]
> > > 
> > > > 3.1.4:
> > > > $ cmd.exe /c "echo \""
> > > > "
> > > > 
> > > > 3.1.5:
> > > > $ cmd.exe /c "echo \""
> > > > \"
> > > 
> > > I can confirm this change in behavior, and I thought it would be
> > > completely
> > > trivial to do a bisection to find the commit that caused it. 
> > > Unfortunately, it seems that the issue is somehow tied up with the fact
> > > that the toolchain used for building the cygwin package was upgraded
> > > shortly after the release of 3.1.4.
> > > 
> > > An attempt to rebuild 3.1.4 with the current toolchain fails because of
> > > some gcc/binutils changes.  So I applied the attached patches, which
> > > were applied to the Cygwin git master shortly after the release of
> > > 3.1.4, in order to make the build succeed.
> > > 
> > > After installing the rebuilt 3.1.4, however, the cmd.exe call above
> > > exhibits the "3.1.5" behavior rather than the "3.1.4" behavior.  I
> > > can't see anything in the patches that would explain this.  I thought
> > > maybe it was a compiler optimization problem, but rebuilding without
> > > optimization doesn't change anything.
> > > 
> > > I'm stumped.
> > > 
> > > Ken
> > 
> > Hi Ken,
> > 
> > Thanks for your testing on this and for following up.  How strange - I
> > totally wouldn't have expected a toolchain upgrade to have changed how
> > quotes get handled.
> > 
> > It sounds like it will be difficult to change the quote behavior.  So,
> > we'll work to get VCL updated to handle the new behavior.
> 
> I have a fix for that.  It's a long standing bug, a buffer overrun,
> which seem to have had no effect pre-3.1.5 only because the older GCC
> toolchain had a subtily different stack allocation strategy.
> 
> I uploaded developer snapshots to https://cygwin.com/snapshots/
> for testing.  Please give this a try and report back.
> 
> If this fixes your problem, the bug is serious enough to qualify for
> a Cygwin 3.1.6 RSN.
> 
> 
> Thanks,
> Corinna

Hi Corinna,

Thank you for this!  I can confirm that replacing cygwin1.dll with the 
cygwin1-20200706.dll that you uploaded to the snapshot site fixes the quote 
issue.

I upgraded an installation I had to 3.1.5-1 and tested that I was seeing the 
problem by running

cmd.exe /c "echo \""
\"

Next, I downloaded, uncompressed, and overwrote cygwin1.dll with 
cygwin1-20200706.dll and tested again

cmd.exe /c "echo \""
"

Great job working through that issue.

Josh
-- 
-------------------------------
Josh Thompson
Systems Programmer
Virtual Computing Lab (VCL)
North Carolina State University

Josh_Thompson AT ncsu DOT edu
919-515-5323

my GPG/PGP key can be found on pool.sks-keyservers.net

All electronic mail messages in connection with State business which
are sent to or received by this account are subject to the NC Public
Records Law and may be disclosed to third parties.
--nextPart1897375.qy90bnlcM9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRMIdRtWXideTZDK31X8tBw1209AwUCXwMxtAAKCRBX8tBw1209
A1VXAJoDUEusMAHvtr14kY/hTYAlRhpmhQCePIoIZ11M3khJ+JFktC+FOw2LekM=
=ydwv
-----END PGP SIGNATURE-----

--nextPart1897375.qy90bnlcM9--




--===============2926230496764487193==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--===============2926230496764487193==--

- Raw text -