X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org D8BB93857C68
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1594034586;
	bh=2onkNpkt6sRNG1hzC0+fT6mY1FyUsUX11LFCYY+YwDo=;
	h=Date:From:To:Subject:References:In-Reply-To:List-Id:
	List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	Reply-To:Cc:From;
	b=JInLxwjdoC/fpX6zuu6G8h3hW4E2OaFUEqWXB1pl7XD/jiPzJDsD1G52rZF48TlyJ
	MuH6EzEr5juDwcjmpH5cGFjXMZ5XZWcS9cu253efJu9j5wxdd4dTLPEGyt6kRexI5n
	Vgs4I//qz/2Qe9WJQcghBCak+1gXwe+EJOUFPpC4=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.3.2 sourceware.org 01F233858D35
Authentication-Results:	sourceware.org;
	dmarc=none (p=none dis=none) header.from=cygwin.com
Authentication-Results:	sourceware.org;
	spf=fail smtp.mailfrom=corinna-cygwin AT cygwin DOT com
Date:	Mon, 6 Jul 2020 13:22:47 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	Josh Thompson <josh_thompson AT ncsu DOT edu>
Subject:	Re: change in handling quotes in cygwin package from 3.1.4-1 to
	3.1.5-1
Message-ID:	<20200706112247.GD514059@calimero.vinschen.de>
Mail-Followup-To:	Josh Thompson <josh_thompson AT ncsu DOT edu>,
	Ken Brown <kbrown AT cornell DOT edu>, cygwin AT cygwin DOT com,
	dev AT vcl DOT apache DOT org
References:	<3394273 DOT JRUgpOGd2y AT dvr>
	<cd0e8a9f-6d61-5813-b2ae-c6fdbf1d9ed7 AT cornell DOT edu>
	<2825592 DOT AUrzYYFGSl AT dvr>
MIME-Version:	1.0
In-Reply-To:	<2825592.AUrzYYFGSl@dvr>
X-Provags-ID:	V03:K1:dqOjkTSdP5FZTimE9onz5WhRBX6VGw7uEOOSzIy33CmFh6dUtJ0
	CE0hs9Hd9/bNUjaSpdZ/9yyx1fyCEB6EAv3t0AWUtHrl3LQKrnjaKl831yxR8QUYM5Ftsa/
	KrXvOqXzXi9ghI3sl94jh21eCky4Z2iDkfz7WaF2O9BjfE2qwLvplab/1zAoCipbuYgPFVZ
	AOB5Zy+0iggIx8239eWRA==
X-UI-Out-Filterresults:	notjunk:1;V03:K0:B2gFC/7Qiwg=:M2bLM0tjSRXA6n6atI9kCB
	HZR35DosYK83cY7sjIr/GjT+PwFc+4Ncl0pOLnBGwQkt0MYVco0AWiD6eZTf7kmbu4a+vWKls
	NaTeFaZmn0Kysp97pLF5+dTmu5NJzOMyQ6+9quHAhU2LyIRdxTrGzSXPMcAtvMiUcYkynX3hG
	XmBv3gCm4QhCL4abXtfUQvOWkiAmtF0uoXoVfGumkqOIwMpa0cC43v7fj+Oa9n9PNYEIgy9ET
	RGsspPh6Bj91QxxF94DuClnImaTXs/iblBDp6Cm2DDMJbG2866I470388f+CafwCqy6f1HlZm
	dvQ/hAoeqHTWhCN6iiOAx2KKOj8zI84cpy/p/KqZUeSGUbiaAoPGvfcqODMStfRc8aulGEEc+
	r4h6XUo12iYX2e1YdeJUg/hl/oWSVsmNFTPHNdRoacRMDD2TmkeLLLDhURBg8vKXl87epvmY8
	yCTJZBjcYx8C4gT92zJ7SmKFV/qGV6lWmuVAlrGCdm1VCBKTBmhVQHhgLoViswKyp7wmXx/HO
	nQebJTXi4REjCpvhs4j/ASQa5GxfAJ//4eVj2d1XPZwCHGAB3psF/1LlfWQTqtl8M3ypcuZTB
	GC8g72tOGK8ip6nt1fG/niiXWXi56FdPbvy12VVTnOBZqh/xzonDkRa9iN+8aG+47PssbKIfW
	rY+XwEj1RW//WN05ciUkXXngxa0B3M174ByIIsVvN3IbxNdy8S8E7YV70r4Ta7gDneB/86l0p
	veBPs64mMVc2GA+O0DNX/jqGwrdm/y66sdGEOrd4sIQRMJLkcLbuVHnTj2saKN77eJ1pjEydm
	a2tya3/8osTlKPKuxlfClb+fpsn51XSUStKO/1cds1DpAmB+Vnz6qPWy0Laut4Yy1JiQ75w
X-Spam-Status:	No, score=-97.5 required=5.0 tests=BAYES_00,
	GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_NUMSUBJECT,
	RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL,
	TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version:	SpamAssassin 3.4.2 (2018-09-13) on
	server2.sourceware.org
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.29
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<http://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<http://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To:	cygwin AT cygwin DOT com
Cc:	cygwin AT cygwin DOT com, dev AT vcl DOT apache DOT org
Errors-To:	cygwin-bounces AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces AT cygwin DOT com>

On Jun 24 13:26, Josh Thompson wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Monday, June 22, 2020 4:11:35 PM EDT Ken Brown wrote:
> > On 6/15/2020 12:21 PM, Josh Thompson wrote:
> > > We recently noticed a change in double quote (") handling that is causing
> > > a
> > 
> > > command we issue to fail.  The command is:
> > [...]
> > 
> > > 3.1.4:
> > > $ cmd.exe /c "echo \""
> > > "
> > > 
> > > 3.1.5:
> > > $ cmd.exe /c "echo \""
> > > \"
> > 
> > I can confirm this change in behavior, and I thought it would be completely
> > trivial to do a bisection to find the commit that caused it.  Unfortunately,
> > it seems that the issue is somehow tied up with the fact that the toolchain
> > used for building the cygwin package was upgraded shortly after the release
> > of 3.1.4.
> > 
> > An attempt to rebuild 3.1.4 with the current toolchain fails because of some
> > gcc/binutils changes.  So I applied the attached patches, which were
> > applied to the Cygwin git master shortly after the release of 3.1.4, in
> > order to make the build succeed.
> > 
> > After installing the rebuilt 3.1.4, however, the cmd.exe call above exhibits
> > the "3.1.5" behavior rather than the "3.1.4" behavior.  I can't see
> > anything in the patches that would explain this.  I thought maybe it was a
> > compiler optimization problem, but rebuilding without optimization doesn't
> > change anything.
> > 
> > I'm stumped.
> > 
> > Ken
> 
> Hi Ken,
> 
> Thanks for your testing on this and for following up.  How strange - I totally 
> wouldn't have expected a toolchain upgrade to have changed how quotes get 
> handled.
> 
> It sounds like it will be difficult to change the quote behavior.  So, we'll 
> work to get VCL updated to handle the new behavior.

I have a fix for that.  It's a long standing bug, a buffer overrun,
which seem to have had no effect pre-3.1.5 only because the older GCC
toolchain had a subtily different stack allocation strategy.

I uploaded developer snapshots to https://cygwin.com/snapshots/
for testing.  Please give this a try and report back.

If this fixes your problem, the bug is serious enough to qualify for
a Cygwin 3.1.6 RSN.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -