X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=oS5vmHsfrpcMisuETufUfUbyhdCuIYPCNKN0x/MTgBGEpcfPVAyzu
	nwt9Gy5LXfxp5NplNLEvspcW8MNFgPKH1csOBEI6DxtGQ9IIk+vKMGH/vujR2QPa
	NZOtpcCPdyijL+0RoVdcLPT+pjXJ7LTieFi+SzRdt17SRzkx3G3VRE=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=3iIkcN01Vt5MYIJ63XfyJHf9YRo=; b=vAlBwYVnxDRWk6YJfhh6WB6kiLVj
	I/TdiuvMmgVqYd8+dg16f6Q9WWma5AKZGoJJMPIw6125yqjVJ7/rZ/+5DdWi4slA
	cX/cXF2s/BMW4H4Fe8yIGq2dfftK7c1vFfmh+Ct+TO+3/tj9idb2NY0H307CzzHl
	ZeoXhArSS2XA6gQ=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-107.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=his
X-HELO:	mout.kundenserver.de
Date:	Mon, 9 Dec 2019 14:05:12 +0100
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: 3.0.7(0.338/5/3): Possible reference to Developer's instances of dev files in deployed build
Message-ID:	<20191209130512.GH3499@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<20191206045537 DOT GA22631 AT shackleton DOT labs DOT net> <20191206110709 DOT GB3499 AT calimero DOT vinschen DOT de> <20191206143457 DOT GC3499 AT calimero DOT vinschen DOT de> <fe61ad0a-1c5e-120c-94ab-746ff839b426 AT cornell DOT edu> <20191209091728 DOT GE3499 AT calimero DOT vinschen DOT de> <284a5954-82d4-2661-f738-0eaa2c09b802 AT cornell DOT edu>
MIME-Version:	1.0
In-Reply-To:	<284a5954-82d4-2661-f738-0eaa2c09b802@cornell.edu>
User-Agent:	Mutt/1.12.1 (2019-06-15)

--NY6JkbSqL3W9mApi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Dec  9 12:47, Ken Brown wrote:
> On 12/9/2019 4:17 AM, Corinna Vinschen wrote:
> > On Dec  7 21:03, Ken Brown wrote:
> >> I don't have any words of wisdom here, but I need to correct something=
 I said
> >> earlier.
> >>
> >> On 12/4/2019 3:50 PM, Ken Brown wrote:
> >>> The assertion fails because 'Z:' doesn't contain a backslash.
> >>
> >> This is not quite right.  It's true that path_conv::check strips the t=
railing
> >> backslash from Z:\, but then it adds it back before calling symlink_in=
fo::check:
> >>
> >>         /* If path is only a drivename, Windows interprets it as the
> >> 	 current working directory on this drive instead of the root
> >> 	 dir which is what we want. So we need the trailing backslash
> >> 	 in this case. */
> >>         if (full_path[0] && full_path[1] =3D=3D ':' && full_path[2] =
=3D=3D '\0')
> >> 	{
> >> 	  full_path[2] =3D '\\';
> >> 	  full_path[3] =3D '\0';
> >> 	}
> >>
> >> Thus symlink_info::check is in fact called on Z:\, but the assertion f=
ails
> >> because the code at path.cc:2905 is looking for a backslash prior to t=
he
> >> trailing backslash.  So maybe the right fix for the assertion failure =
is the
> >> following:
> >>
> >> --- a/winsup/cygwin/path.cc
> >> +++ b/winsup/cygwin/path.cc
> >> @@ -2895,7 +2895,8 @@ restart:
> >>                slow down normal operation.  This extra check only kick=
s in if
> >>                we encountered a STATUS_OBJECT_NAME_NOT_FOUND *and* we =
didn't
> >>                already attach a suffix. */
> >> -         if (!restarted && !*ext_here && !(mount_flags & MOUNT_DOS))
> >> +         if (!restarted && !*ext_here && ext_here[-1] !=3D '\\'
> >> +             && !(mount_flags & MOUNT_DOS))
> >>               {
> >>                 /* Check for trailing dot or space or leading space in
> >>                    last component. */
> >=20
> > Ok, please push that.  I'll create a snapshot so Wilfed can test this.
>=20
> Done.  I'll document it once Wilfed verifies that it fixes his problem.

Great!  I created new snapshots.

Wilfed, please test if the latest snapshot from
https://cygwin.com/snapshots/ fixes your problem.


Thanks,
Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--NY6JkbSqL3W9mApi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl3uRogACgkQ9TYGna5E
T6B2Wg/8DnFl1WNcKfhprE1Bxk+9hIw52/sORfhgVyGqz7adr7sHyPxIRaCjlzM5
fhwT9Yo65xt45Ap/1gQLblg2/+IM8XdwZnJ9mb4yX1L61CpqwSH5Ba1+hMzgmNGG
IdAZg8LmDnqXpcPsiNhXuYGpaKRWqivPCn/tlV1TBniQRviuXjekCzwFMKKlDf/V
jZlV7K/GOnl9agMx7CUGmgd/mF87ohbWIOZbUpYULGWVp5RnvQgMrjw7h/cjaLo0
46UPJN5ShgEnVielDend2B/BNgAblt6f0xwPy5ZvsHQdmI2lIYCi5BqElEz85yoG
WK5UCv4qyXkcf5vTr9+ffMcdc8f3ogmv1I+lizxPFbZnOLd0HExwbo6/a8UNWK/t
tqJFpqd4bmS3B4uk94aA/UA83nTyxpRmvBFnSSHZWWie3CljGEJAnlGzjRfxFhqh
KIhPvdtTNFWpBQ8+lFebbxhEjejZh7eLMxunDIPn0ZeayZEc5IE7XM1sPEXdD4e3
gVwF2Ng4jRwXfcFczY8IsyeBCUixw9dI8TyTq4iXC8gPj7VHmcKbk7KI0Ylq5x8s
Op9JF16vbiWeodnv3nFeYALwVhfcfjlYuhwpjKKoV0nFQAuxJK11dLf+6CAgB4Be
iOICcWvxqFpEpCYHktTGWnmyU0K/cWgcqkLKfFEYEipJljTNvM4=
=NkSf
-----END PGP SIGNATURE-----

--NY6JkbSqL3W9mApi--

- Raw text -