X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=jGlAEbVi0zB41uYI8BfrfTzGLKpcnZIL1GkvIqBT9sCa+QuW0DKwv
	72YSlFQtDctx0cz3/4wKC/JmBkDBTl9Zap4CEMoqdNrfgkUQhB0GlHeHNYeDSiBd
	Zhpg7LmamGV3A7F7EesjP8vCwgo9np0eH0hpa+0+4I9ybM2NBH3q+8=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=HNvdczUlC7kKpBey9ZECflQDMxg=; b=fb9tKDKDf3Q6ZqdcxSir6hs3IVI7
	Xv0fwK3sqnIJxzXAISDYflOTRBQghZZvg+1h/GfVtKyM6LniUgAqLFyafGMVnPfO
	v6M1QCpKM856B2TRY4VV/VhhTRZ7peeP3Znf4a+nFYipcZ0J2RzXnT1RoQBbqoe2
	t72L+yJ5OQ/yd4g=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-114.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO:	mout.kundenserver.de
Date:	Fri, 30 Aug 2019 10:10:50 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Cc:	Eric Blake <eblake AT redhat DOT com>
Subject:	Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ...
Message-ID:	<20190830081050.GC27273@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com, Eric Blake <eblake AT redhat DOT com>
References:	<bc3df101ab93c20b86c3ab7fa7d3ea4f AT xs4all DOT nl> <20190827152549 DOT GY11632 AT calimero DOT vinschen DOT de> <a47cc167b725c08e6f1c914166fabcaf AT smtp-cloud8 DOT xs4all DOT net> <3E262D05-F393-453A-9E43-B248DDE50812 AT solidrocksystems DOT com> <b97e4dbe952154efc68412540514ae81 AT smtp-cloud8 DOT xs4all DOT net> <20190828125939 DOT GL11632 AT calimero DOT vinschen DOT de> <421ac447-b249-da21-1ca5-228041cfc884 AT redhat DOT com> <20190828141556 DOT GM11632 AT calimero DOT vinschen DOT de> <20190828142220 DOT GN11632 AT calimero DOT vinschen DOT de> <ee1138b29ee4be60d62d86d59f581b2e AT smtp-cloud8 DOT xs4all DOT net>
MIME-Version:	1.0
In-Reply-To:	<ee1138b29ee4be60d62d86d59f581b2e@smtp-cloud8.xs4all.net>
User-Agent:	Mutt/1.12.1 (2019-06-15)

--DSayHWYpDlRfCAAQ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Eric?


On Aug 29 17:05, Houder wrote:
> On Wed, 28 Aug 2019 16:22:20, Corinna Vinschen  wrote:
>=20
> > > As simple as that?
> > >
> > > diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
> > > index b757851d5c7f..747b1582af50 100644
> > > --- a/winsup/cygwin/dir.cc
> > > +++ b/winsup/cygwin/dir.cc
> > > @@ -314,13 +314,13 @@ mkdir (const char *dir, mode_t mode)
> > >  	  set_errno (ENOENT);
> > >  	  __leave;
> > >  	}
> > > -      if (isdirsep (dir[strlen (dir) - 1]))
> > > +      if (dir[strlen (dir) - 1] =3D3D=3D3D '/')
> > >  	{
> > >  	  /* This converts // to /, but since both give EEXIST, we're okay.=
  */
> > >  	  char *buf;
> > >  	  char *p =3D3D stpcpy (buf =3D3D tp.c_get (), dir) - 1;
> > >  	  dir =3D3D buf;
> > > -	  while (p > dir && isdirsep (*p))
> > > +	  while (p > dir && *p =3D3D=3D3D '/')
> > >  	    *p-- =3D3D '\0';
> > >  	}
> > >        if (!(fh =3D3D build_fh_name (dir, PC_SYM_NOFOLLOW)))
> >=20
> > One problem here is, what to do about border cases like
> >=20
> >   $ mkdir a\/\/\/
> >=20
> > In theory slashes and backslashes should both be treated as dir
> > separators.  Handling a case like this so that all expectations
> > are satisfied is next to impossible, I guess.
>=20
> How about dropping Eric's code snippet in winsup/cygwin/dir.cc ?????
>=20
> Subdirectory 'a' is created. No problem there. Perhaps the patch has
> become superfluous/ redundant over time?
>=20
> I have tried different "values" for the path-argument to mkdir, and
> have not found a problem while the code snippet is being skipped.
>=20
> What am I missing?
>=20
> Henri
>=20
> -----
> Breakpoint 1 at 0x1800548b9: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/=
cygwin/dir.cc, line 317.
> Breakpoint 2 at 0x1800548e3: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/=
cygwin/dir.cc, line 326.
> (gdb) r
> Starting program: /usr/bin/mkdir 'a\/\/\/'
> [New Thread 1064.0x1a8c]
> [New Thread 1064.0x59c]
>=20
> Thread 1 "mkdir" hit Breakpoint 1, mkdir (dir=3D0x800041320 "a\\/\\/\\/",=
 mode=3D511)
>     at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:317
> 317           if (isdirsep (dir[strlen (dir) - 1]))
> (gdb) j dir.cc:326
> Continuing at 0x1800548e3.
>=20
> Thread 1 "mkdir" hit Breakpoint 2, mkdir (dir=3D0x800041320 "a\\/\\/\\/",=
 mode=3D511)
>     at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:326
> 326           if (!(fh =3D build_fh_name (dir, PC_SYM_NOFOLLOW)))
> (gdb) c
> Continuing.
> [Inferior 1 (process 1064) exited normally]
> (gdb) quit
>=20
> 64-@@ ls -ld a*
> drwxr-xr-x+ 1 Henri None 0 Aug 29 16:47 a
>=20
> =3D=3D=3D=3D=3D
>=20
>=20
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

--=20
Corinna Vinschen
Cygwin Maintainer

--DSayHWYpDlRfCAAQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1o2goACgkQ9TYGna5E
T6CpZBAAlZ1rkhcAyGUUS5LC4DEkWsZqTYSuMYqc9NnX/Y6aHr3r5SIUV6JwWkdP
dWCS/SDjpwlKHxLFnR7iVYpxb4KubGi1jbJiUtkYiFm/oA/9HybjLMuzB7O1Tqnw
MHtTzqVffPLIqT0nLpaP7jGKtAPsrGk8s063fEr+Ow2yRCE9Qr7+OCXVbDSfbnsf
TxU/vneqXqtamwT41cA6ZGiYjY5KK9huBqkxnsvpYe2ZRw8uHPfWu35dLiTQKykD
KxeDvgt0b3Jbjox4hnhBEPaM3saI0GIDG5Y9JAHdD8YPjlNKCwovK5enykpCWVlm
f1/QSEoWaWSJ3hSjb2OuQEmRIH4Ad2gFEPaB5ZvKnj5A+WHAPZCf2oE8RrNj891O
rhmDtc54esfPo0H4lDMcq/VMfU8lPvd3fZcNV+3PUbPccIu216pCwJfWHoJ3lp53
fuhGlFfBRxWw0QLN3xlNTbl3KObiTwyioXSi3ut9Oxo8SJM8iQ13s8K7wSuNRhqC
I51YMgFr+/1u9rXcRdtKB8wKaMIKztEcMHfjAhmzlhWK96ISUeMSAFh9dy9CFtR2
UDWcbn2kxSwqc4IsuhxrzgY/9XcyxwLbCfzzRR59k+KsNHqxrD4hDRgkCznuZjQb
q0DiOath/AvXwZht7qbJ99+2pcrntgSLCW7lz8PFUox/OWKGQSc=
=byAz
-----END PGP SIGNATURE-----

--DSayHWYpDlRfCAAQ--

- Raw text -