delorie.com/archives/browse.cgi | search |
X-Recipient: | archive-cygwin AT delorie DOT com |
DomainKey-Signature: | a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:date:from:to:cc:subject:message-id:reply-to | |
:references:mime-version:content-type:in-reply-to; q=dns; s= | |
default; b=EL4chJeR+B4z3/1ODMVkOsnTt8IPu/tVLY9cVL0/Ng4CzPJQ1c6mu | |
55UeiIib2ssIHu4Lxu7dIjLOVOroK61NuYNihLJAraNoQOVXe+zHi+WJMWjmXr1S | |
6Qu2QONzzzefgAiM0nPt61OtaNRcj1KB1ynVffK29xFkOb9ZLYMg98= | |
DKIM-Signature: | v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:date:from:to:cc:subject:message-id:reply-to | |
:references:mime-version:content-type:in-reply-to; s=default; | |
bh=ioe/ac2ctABtvyysNkFQqFTgNqs=; b=OP/yiLYXSx4Z0mHiUjQvkCFF9hrR | |
I2xYQ39iIVP495YmLBmqP882RzECW5rIGCvwykYOzw6qnbwfZpymZFn1IvVeHPa5 | |
RHJL4+abwAEkXdC8W8hTx5aCADmQdtNvL2chY8jdrKgDWQ7sO9ULckcaapUh1ww2 | |
z63QZfycSKrngjI= | |
Mailing-List: | contact cygwin-help AT cygwin DOT com; run by ezmlm |
List-Id: | <cygwin.cygwin.com> |
List-Subscribe: | <mailto:cygwin-subscribe AT cygwin DOT com> |
List-Archive: | <http://sourceware.org/ml/cygwin/> |
List-Post: | <mailto:cygwin AT cygwin DOT com> |
List-Help: | <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs> |
Sender: | cygwin-owner AT cygwin DOT com |
Mail-Followup-To: | cygwin AT cygwin DOT com |
Delivered-To: | mailing list cygwin AT cygwin DOT com |
Authentication-Results: | sourceware.org; auth=none |
X-Spam-SWARE-Status: | No, score=-102.8 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*Ad:D*jp, october, reproduce, zoom |
X-HELO: | mout.kundenserver.de |
Date: | Fri, 30 Aug 2019 09:55:23 +0200 |
From: | Corinna Vinschen <corinna-cygwin AT cygwin DOT com> |
To: | cygwin AT cygwin DOT com |
Cc: | Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp> |
Subject: | Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.3 |
Message-ID: | <20190830075523.GB27273@calimero.vinschen.de> |
Reply-To: | cygwin AT cygwin DOT com |
Mail-Followup-To: | cygwin AT cygwin DOT com, Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp> |
References: | <announce DOT 20190829122237 DOT GZ11632 AT calimero DOT vinschen DOT de> <CALK-3mLPXAcjZdftE_L-YwneyM79GBEt8c1nyVTisjKp0abCUg AT mail DOT gmail DOT com> |
MIME-Version: | 1.0 |
In-Reply-To: | <CALK-3mLPXAcjZdftE_L-YwneyM79GBEt8c1nyVTisjKp0abCUg@mail.gmail.com> |
User-Agent: | Mutt/1.12.1 (2019-06-15) |
--rS8CxjVDS/+yyDmU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [CC Takashi] On Aug 29 22:15, Biswapriyo Nath wrote: > On Thursday, August 29, 2019, Corinna Vinschen <corinna-cygwin AT cygwin DOT com> > wrote: > > Support the new pseudo console in PTY. Pseudo console is a new feature > in Windows 10 1809, which provides console APIs on virtual terminal. >=20 > Some queries about this specific feature: Please note that this is very likely not the final version. I'm planning for a release end of october or early november so there's still lots of time to fix issues. However, this is a great new feature which needs good testing, that's why we do these test releases. > 1a. In fhandler_pty_mater::ioctl function, shouldn't the function pointer > be checked before use? Also what the FIXME says, isn't clear. Any hint? Yeah, right. What happens on pre-W10 1809 systems? They probably crash on TIOCSWINSZ. See below. > 1b. GetModuleHandle and GetProcessHeap is called several times. Wouldn't = be > it easier to get all the pseudo console function pointers in one > constructor? In terms of GetModuleHandle/GetProcAddress the right thing to do is to use the autoload feature, i.e., add the functions to autoload.cc like this: LoadDLLfuncEx (ClosePseudoConsole, 4, kernel32, 1) LoadDLLfuncEx (CreatePseudoConsole, 20, kernel32, 1) LoadDLLfuncEx (ResizePseudoConsole, 8, kernel32, 1) If the function call returns FALSE with GetLastError() =3D=3D ERROR_PROC_NOT_FOUND, then the function is not available. Takashi, I didn't actually notice the usage of the Windows heap here. The usual method is to use a tls_pbuf buffer, and rather than using MultiByteToWideChar/WideCharToMultiByte, use sys_mbstowcs/ sys_wcstombs. Also, can you please change the camelback names in class tty_min to underscored writing, e.g., term_codepage rather than TermCodePage? > 2. There are many defined values are added but those are also present in > mingw-w64 current git repo. For example, ENABLE_VIRTUAL_TERMINAL_PROCESSI= NG. We can only use what's part of the current w32api-headers package. > 3. I can't reproduce this issue with exact steps. But when I zoom in/out + > resize mintty window + execute cmd.exe in mintty in some random order it > crashed. Here is the error: >=20 > [main] D:\Cygwin64\bin\bash 1129 > fhandler_pty_slave::push_to_pcon_screenbuffer: pty0: pcon_attach > mismatch?????? (0x18035DBD0) Takashi? Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer --rS8CxjVDS/+yyDmU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1o1msACgkQ9TYGna5E T6D9sxAAlc8+XGDNynQJH8F2GARwEFhOuThEZDpq7fkhKnzCO3vVuwLfup7wRltv 8rcF2+jx1J/g3wsjSUNx7UmB8iFD6YFkc8o5UUaImV5W53FceQd13ZSnDH6bhFlO tfweB4vxhfukMXPIaAi8P8nV2RhonEyYi1hKpL7ZtqS9qjQa6Sfn0SofIApjaybR PDVbM4dENfNmkz8ecIyAcPJ2tOs0+xdwnk10s8vd6lTY2C3vf8iZRCJjF1R4azl7 v5lnpWTYzg8DVQJS0fZyuueSFLHccXhoOxT7da/0QyiXv5sV2fRZ4VJSmPatlRzb WUKFpzgB6JI4EgadosS0pczdWo6jl2t04iyCUCaRoMfOPE5eyUhTirLhewhym+s3 MJqlbQOgf2yugx5fMavaxRzy4tIXOR3AnBXLTzuU5nOT2hUWlzv3a42hu8r+PhmC e3sa1YoOBQtTcSWpLusCLwJrMuA0h3x8GnvjgrCLaX67jNCIW5Ea2Yq7yjRcvYpe ACP7ULptBULhyodRMlxGR4xznjAf9PG6gr3p/9jTH2xUCmVHIlXbr5BlY8bfs+zo kVPStVgfeslQhzeC6/DrbHISOy5dOS8yrVlQ4f0uRZhboWYE3j1wzLValR0wcVxW mrNFkvCqA+7QHMwIiD7ugCt/nEEa9PsvFlSAkuzPDHUIMw3Id40= =kAax -----END PGP SIGNATURE----- --rS8CxjVDS/+yyDmU--
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |