X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:message-id:from:reply-to:to:subject
	:references:in-reply-to:content-type; q=dns; s=default; b=mDY2fS
	MhdesUJvlo+D1rCiXOvA/QvN6xB/wjubfpSeVIovlbbnH9g2NA5gxQg2fR1sXIxm
	Q4wBztJF9qrB5vaH+EpFgcvrGll1Ggg/UQjfizvsR0BMgvl2UlUlMwTNJcLCiKQ9
	daZwPxFNJ2ckD0Pic+vRKx3YetOC+soEpnkus=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:message-id:from:reply-to:to:subject
	:references:in-reply-to:content-type; s=default; bh=FXvz2Wj+eqYt
	xAao3+n2GS1CTfA=; b=EFzPN2qmMPP5nqsAzmJwiDtfZO1W1itsOBIiK6Y5O3hz
	Safw1kZ2yIp75ad9MnT/PVqoLpjdr3TFdpxI1U8z9ktq+nOVuhqyqlV2GtVfE4C6
	PJv1aVMF2DvAq3KXc2GcPyHkQf08jPpnHsu/amXJRwJuCPaV3IbXWz+N/yFinmE=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-14.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=Continuing, continuing
X-HELO:	lb2-smtp-cloud8.xs4all.net
Date:	Thu, 29 Aug 2019 17:05:41 +0200
Message-ID:	<ee1138b29ee4be60d62d86d59f581b2e@smtp-cloud8.xs4all.net>
From:	Houder <houder AT xs4all DOT nl>
Reply-To:	cygwin AT cygwin DOT com
To:	cygwin AT cygwin DOT com
Subject:	Re: Odd, is it not? mkdir 'e:\' cannot be undone by rmdir 'e:\' ...
References:	<bc3df101ab93c20b86c3ab7fa7d3ea4f AT xs4all DOT nl> <20190827152549 DOT GY11632 AT calimero DOT vinschen DOT de> <a47cc167b725c08e6f1c914166fabcaf AT smtp-cloud8 DOT xs4all DOT net> <3E262D05-F393-453A-9E43-B248DDE50812 AT solidrocksystems DOT com> <b97e4dbe952154efc68412540514ae81 AT smtp-cloud8 DOT xs4all DOT net> <20190828125939 DOT GL11632 AT calimero DOT vinschen DOT de> <421ac447-b249-da21-1ca5-228041cfc884 AT redhat DOT com> <20190828141556 DOT GM11632 AT calimero DOT vinschen DOT de> <20190828142220 DOT GN11632 AT calimero DOT vinschen DOT de>
In-Reply-to:	<20190828142220.GN11632@calimero.vinschen.de>
User-Agent:	mua.awk 0.99

On Wed, 28 Aug 2019 16:22:20, Corinna Vinschen  wrote:

> > As simple as that?
> >
> > diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc
> > index b757851d5c7f..747b1582af50 100644
> > --- a/winsup/cygwin/dir.cc
> > +++ b/winsup/cygwin/dir.cc
> > @@ -314,13 +314,13 @@ mkdir (const char *dir, mode_t mode)
> >  	  set_errno (ENOENT);
> >  	  __leave;
> >  	}
> > -      if (isdirsep (dir[strlen (dir) - 1]))
> > +      if (dir[strlen (dir) - 1] =3D=3D '/')
> >  	{
> >  	  /* This converts // to /, but since both give EEXIST, we're okay.  */
> >  	  char *buf;
> >  	  char *p =3D stpcpy (buf =3D tp.c_get (), dir) - 1;
> >  	  dir =3D buf;
> > -	  while (p > dir && isdirsep (*p))
> > +	  while (p > dir && *p =3D=3D '/')
> >  	    *p-- =3D '\0';
> >  	}
> >        if (!(fh =3D build_fh_name (dir, PC_SYM_NOFOLLOW)))
> 
> One problem here is, what to do about border cases like
> 
>   $ mkdir a\/\/\/
> 
> In theory slashes and backslashes should both be treated as dir
> separators.  Handling a case like this so that all expectations
> are satisfied is next to impossible, I guess.

How about dropping Eric's code snippet in winsup/cygwin/dir.cc ?????

Subdirectory 'a' is created. No problem there. Perhaps the patch has
become superfluous/ redundant over time?

I have tried different "values" for the path-argument to mkdir, and
have not found a problem while the code snippet is being skipped.

What am I missing?

Henri

-----
Breakpoint 1 at 0x1800548b9: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc, line 317.
Breakpoint 2 at 0x1800548e3: file /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc, line 326.
(gdb) r
Starting program: /usr/bin/mkdir 'a\/\/\/'
[New Thread 1064.0x1a8c]
[New Thread 1064.0x59c]

Thread 1 "mkdir" hit Breakpoint 1, mkdir (dir=0x800041320 "a\\/\\/\\/", mode=511)
    at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:317
317           if (isdirsep (dir[strlen (dir) - 1]))
(gdb) j dir.cc:326
Continuing at 0x1800548e3.

Thread 1 "mkdir" hit Breakpoint 2, mkdir (dir=0x800041320 "a\\/\\/\\/", mode=511)
    at /usr/src/debug/cygwin-3.1.0-0.2/winsup/cygwin/dir.cc:326
326           if (!(fh = build_fh_name (dir, PC_SYM_NOFOLLOW)))
(gdb) c
Continuing.
[Inferior 1 (process 1064) exited normally]
(gdb) quit

64-@@ ls -ld a*
drwxr-xr-x+ 1 Henri None 0 Aug 29 16:47 a

=====


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -