X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=y2M1DBGMjE6X1FvZPStFFMgz4YDXr3UG+4zDGxV7vQZ4VJvYFRLJ5
	nlUmcgnv0ytvYh4WMiRXHLZw/eGT81GTEo1o55v1aLb0meRPQSaVvNwjIBxRP21n
	lExg5R37fEfZGP+Apm9GX7/71c6uJS7KbYGiCwZmhneXU4iCBGtnIM=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=L1XnaeJ6wj5QaK0hYyEnryygkPI=; b=ZMIIxqW/iLf6bYrM2yAgKKzD/RAy
	sYLoi7dF2THdxt1O8STD6l+YMlvm4OUzUB0trvkytecn6mbTl87ete8Sj5uNq+UR
	TUkMJbgHVZxloFIt2UYr0EJHnNHwUAyEaH9d17ysig0w9oraY2oaYAo+rBJN0Kn3
	bIVFhi8pfoOycKg=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-103.8 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=learning, tricky, online, our
X-HELO:	mout.kundenserver.de
Date:	Thu, 15 Aug 2019 12:20:38 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	"Lavrentiev, Anton (NIH/NLM/NCBI) [C]" <lavr AT ncbi DOT nlm DOT nih DOT gov>
Cc:	"cygwin AT cygwin DOT com" <cygwin AT cygwin DOT com>
Subject:	Re: getpriority() and top display for priority inconsistent
Message-ID:	<20190815102038.GM11632@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	"Lavrentiev, Anton (NIH/NLM/NCBI) [C]" <lavr AT ncbi DOT nlm DOT nih DOT gov>, "cygwin AT cygwin DOT com" <cygwin AT cygwin DOT com>
References:	<BN6PR09MB1409FFA3C34F0EF48915C4E1A5AD0 AT BN6PR09MB1409 DOT namprd09 DOT prod DOT outlook DOT com> <20190815072854 DOT GE11632 AT calimero DOT vinschen DOT de> <BN6PR09MB140944DC1C65B9A96BF6D745A5AC0 AT BN6PR09MB1409 DOT namprd09 DOT prod DOT outlook DOT com>
MIME-Version:	1.0
In-Reply-To:	<BN6PR09MB140944DC1C65B9A96BF6D745A5AC0@BN6PR09MB1409.namprd09.prod.outlook.com>
User-Agent:	Mutt/1.11.3 (2019-02-01)

--BvhWI31Ceb2Zf+Ez
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Aug 15 09:41, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via cygwin wrote:
> > git format-patch output with commit message, please?
>=20
> Please educate me how to do that;  I am just using "git diff --no-color".

$ git add <files with changes you want to commit>
$ git commit -a

  - opens editor to create a commit message.  first line is summary,
    second line stays empty, descriptive text follows in line 3+.

$ git format-patch -1

  - creates a git patch file which can be attached to your email or
    just send *as* email with `git send-email --to=3D<addr> <filename>

Starting with git has a bit steep learning curve, but it's totally
worth it.  There's a great free online book available:

  https://git-scm.com/book/

> > The commit message should describe what the problem is and how the patc=
h fixes it.  One or
> > two sentences are enough.
>=20
> The commit message is there:
>=20
> > > "getpriority() consistent with process priority
> > https://cygwin.com/ml/cygwin/2019-08/msg00122.html"

Well, that's just a quote from a former email.  I would never have
recognized it as a commit message.  A commit message should consist
of the one-line summary (in our case starting with the text "Cygwin: "
to distinguish the change from generic newlib changes), followed
by an empty line, followed by a descriptive text, what problem this
patch fixes and how.

Don't get me wrong, I'm glad you send patches, but it's tricky to create
a meaningful commit message if you're not the author of a patch.  It's
also pretty time-consuming since you have to care for correct authorship
and stuff.


Thanks,
Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--BvhWI31Ceb2Zf+Ez
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1VMfYACgkQ9TYGna5E
T6Dc/w//c2URAomYkJI/be4w5xclsCu8raJaAUksLcP9gqC6SMZLcmT6Ay60lYwy
YzObYDASBXr0WcPZ7Nmif+nIztbQAV89aEP6M2dALQcTGlosI8tNPm0UZevMgkB9
io53ELuP3fwWHzMKH3NdmOe3PUsHNHwZlJMgw+5THWDNlrX/hqmYj4yprppiajNb
/iVAJlvsHMnmG2FZJftOJELIvAWtoOVOE+zn57kW6OQ8LyNZfVw17dwS8LagFMHS
PV/ts0zFZaPhM6jIa6AqeKkNI7H33y5x6w0Uc+ObkL/XIMVJqlxwO5mwNnCAlhdS
61HLnUE/CCRa598IzjE0rWiF8ejJLOi9sQLR2pl6TEdyeH53gKgAorNxZxuMxi8l
c1gMFxZM6pBpaW4s5qTLxvEMaZhGrH7nG21ErZ6v+lbeQMNmrEVpVL+2AG0emAVf
AOjWhOLjMHPx30vTPbuQsnr/HS/SdGpdR4IISjxFlQqzfZ2sZV5NdOnhQPSoVn04
fLDyyzdetC33kw19QSrdB7IfAcaEccQT5eKFQc103UjierTP5YRAklAqrjANuPoi
B7NXJRpvKRKwBcQ+y0Nug1KHivtfrlPqASPadCZelDibJCC7Ins0i/QzbwzqDBYK
JSeCigcDAanO7ckk7+96IRzCPjwICk9g/BwtWLnKjiC9jtg2av4=
=t0ew
-----END PGP SIGNATURE-----

--BvhWI31Ceb2Zf+Ez--

- Raw text -