delorie.com/archives/browse.cgi | search |
X-Recipient: | archive-cygwin AT delorie DOT com |
DomainKey-Signature: | a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:date:from:to:cc:subject:message-id:reply-to | |
:references:mime-version:content-type:in-reply-to; q=dns; s= | |
default; b=rz4K/qgTIfX1e6YBgNZM2mNmGnLAPxyuXvchxtBwvzvII7X98qQjo | |
QVFDx1uoW3TAo9m9MgCpp4dMWBxqZ6XQ3N27BN9L/7RFta2ISJEgi+cXCJlo0dEl | |
PPJQD1la0qS/WMrMA33F4RW8BSrJHp9qo1o3dDN06xyeHmydG+guwI= | |
DKIM-Signature: | v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:date:from:to:cc:subject:message-id:reply-to | |
:references:mime-version:content-type:in-reply-to; s=default; | |
bh=ABiSIAMzL9ODMpgLCvqbwtZxyBQ=; b=nsGKSM521oszgmeEBurf07CXs4OY | |
Zab2DlFpuRs7T1iceNasFGZF3fq3HVDjjoTBbgSwKE6eOJIlOzUsZ08TBTkMLJrR | |
xhJ7wVV0ccBvJsEWhEWzQpcR35U24zAlDR/WL4HDweVLxZAllshi6oP5FPQN4kps | |
UCfDcpRPZqEfeAM= | |
Mailing-List: | contact cygwin-help AT cygwin DOT com; run by ezmlm |
List-Id: | <cygwin.cygwin.com> |
List-Subscribe: | <mailto:cygwin-subscribe AT cygwin DOT com> |
List-Archive: | <http://sourceware.org/ml/cygwin/> |
List-Post: | <mailto:cygwin AT cygwin DOT com> |
List-Help: | <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs> |
Sender: | cygwin-owner AT cygwin DOT com |
Mail-Followup-To: | cygwin AT cygwin DOT com |
Delivered-To: | mailing list cygwin AT cygwin DOT com |
Authentication-Results: | sourceware.org; auth=none |
X-Spam-SWARE-Status: | No, score=-115.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*F:D*cygwin.com |
X-HELO: | mout.kundenserver.de |
Date: | Tue, 26 Mar 2019 19:25:38 +0100 |
From: | Corinna Vinschen <corinna-cygwin AT cygwin DOT com> |
To: | Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com> |
Cc: | cygwin-patches AT cygwin DOT com, cygwin AT cygwin DOT com |
Subject: | Re: [PATCH RFC] fork: reduce chances for "address space is already occupied" errors |
Message-ID: | <20190326182538.GA4096@calimero.vinschen.de> |
Reply-To: | cygwin-patches AT cygwin DOT com |
Mail-Followup-To: | Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com>, cygwin-patches AT cygwin DOT com, cygwin AT cygwin DOT com |
References: | <8c77b589-fcae-fd0d-f5c5-c2520cfebbfa AT ssi-schaefer DOT com> |
MIME-Version: | 1.0 |
In-Reply-To: | <8c77b589-fcae-fd0d-f5c5-c2520cfebbfa@ssi-schaefer.com> |
User-Agent: | Mutt/1.11.3 (2019-02-01) |
--ikeVEW9yuYc//A+q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Michael, Redirected to cygwin-patches... On Mar 26 18:10, Michael Haubenwallner wrote: > Hi Corinna, >=20 > as I do still encounter fork errors (address space needed by <dll> is > already occupied) with dynamically loaded dlls (but unrelated to > replaced dlls), one of them repeating even upon multiple retries, Why didn't rebase fix that? > I'm > coming up with attached patch. >=20 > What do you think about it? I'm not opposed to this patch but I don't quite follow the description. threadinterface->Init only creates three event objects. From what I can tell, Events are stored in Paged and Nonpaged Pools, so they don't affect the processes VM. What am I missing? Thanks, Corinna >=20 > Thanks! > /haubi/ > >From dfc28bcbb7ed55fe33ddb8d15e761b4d5b4815f8 Mon Sep 17 00:00:00 2001 > From: Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com> > Date: Tue, 26 Mar 2019 17:38:36 +0100 > Subject: [PATCH] Cygwin: fork: reserve dynloaded dll areas earlier >=20 > In dll_crt0_0, both threadinterface->Init and sigproc_init allocate > windows object handles using unpredictable memory regions, which may > collide with dynamically loaded dlls when they were relocated. > --- > winsup/cygwin/dcrt0.cc | 6 ++++++ > winsup/cygwin/fork.cc | 6 ------ > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/winsup/cygwin/dcrt0.cc b/winsup/cygwin/dcrt0.cc > index 11edcdf0d..fb726a739 100644 > --- a/winsup/cygwin/dcrt0.cc > +++ b/winsup/cygwin/dcrt0.cc > @@ -632,6 +632,12 @@ child_info_fork::handle_fork () >=20=20 > if (fixup_mmaps_after_fork (parent)) > api_fatal ("recreate_mmaps_after_fork_failed"); > + > + /* We need to occupy the address space for dynamically loaded dlls > + before we allocate any dynamic object, or we may end up with > + error "address space needed by <dll> is already occupied" > + for no good reason (seen with some relocated dll). */ > + dlls.reserve_space (); > } >=20=20 > bool > diff --git a/winsup/cygwin/fork.cc b/winsup/cygwin/fork.cc > index 74ee9acf4..7e1c08990 100644 > --- a/winsup/cygwin/fork.cc > +++ b/winsup/cygwin/fork.cc > @@ -136,12 +136,6 @@ frok::child (volatile char * volatile here) > { > HANDLE& hParent =3D ch.parent; >=20=20 > - /* NOTE: Logically this belongs in dll_list::load_after_fork, but by > - doing it here, before the first sync_with_parent, we can exploit > - the existing retry mechanism in hopes of getting a more favorable > - address space layout next time. */ > - dlls.reserve_space (); > - > sync_with_parent ("after longjmp", true); > debug_printf ("child is running. pid %d, ppid %d, stack here %p", > myself->pid, myself->ppid, __builtin_frame_address (0)); > --=20 > 2.17.0 >=20 >=20 >=20 > -- > Problem reports: http://cygwin.com/problems.html > FAQ: http://cygwin.com/faq/ > Documentation: http://cygwin.com/docs.html > Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple --=20 Corinna Vinschen Cygwin Maintainer --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlyabqIACgkQ9TYGna5E T6Ao5g/+JCxDqQZXB1ljI6WAbJZVGH6whlxQSMgWpPSlavTxLFGCGtB3QtTB8bpO xx5iKV6sD3Lv8BxiBz1OeQvi3j/EnoVykhVbIrCxv9rpbtxr6ncKu3D1kDjVyIBh 4mMSQON9PDOucmdKlpoEh3GiZNkfX6W2jQCqdv01nF1jfrxscN7opRQhnFdnW6nt LP4Pzj/mSKZQpyBpJ0b1WeIYPW5OXppy1U6JhfF9RJxrLD3GN8HVW7ZNPiseK5Z3 HnRfgBbh9FcEdPLyq/17ymhw3HbdynfCGmTuYeGXXNftDsOkyK6p94G+d7xjIOz/ 7wdttdNg926v4aMbJ9mN7qtyIyY1cLBxtPayCthMAE6uP4X6HALyl9E0PFnmn7pO /7Qc3Hx0BqFxdtpuqWkICxlL/Kn/ADfj+kn8NARMUaeBgyGTlsgrAiTA3zT9UVJV TV2QxtnJUCTs3plFQj+NYbM1qftiaQXVNA2hUzSaGfj7XpG1ExaO2ZgM4IM9fUlb dW8F7GMqpjelm1xjgKK3PDtlKYdncTpO71pMiNJF2ckCd4EQvQ29j02zwwm7z2cV TUVXqdvOV1hcSvxiNbtnmlk6RxtLN0T0p3vM3cgY/tzWehsiK7VnvChj23JdcNf5 4VFjkMvPSD677m9xXUOY4Otb+XPAsROdWOVoCtAfHekMdGkN5KU= =U6n8 -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q--
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |