X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type; q=dns; s=default; b=wvzo
	xzBv2bwSjM552poEfgUEfazcI1vBvhb2EprxamP4g9naIE0Jy4NYCHlxOXr/bKd+
	A4Oex2rWydbokHwkplP1eum2D8W8rJVj2sK4/wAkItPfaKrktyrb/WlEWlXIFT84
	SU4cdFDaqIhNErCymXzy7A5+7kJuaPAH1k7IKbo=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type; s=default; bh=hDtT6SiZjq
	vivBl9iQ4mycCTRmw=; b=lppb9CWLNMAFoQIxa2Y2J9yjNALpx3bz5L0649gHNw
	UMq6g1gS/4+0+oTLsFgbjGcQHhmnB6B4/irJMujjrqY/A1xh2YqQMTjbbJgxR/vD
	B8mZVKLTOTtDXdTEPIgcV7Z4OsiQ0/Fa517gBOXeWLolGiKm0Wn8DBShbSQCiTko
	g=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:mailhos, HX-Envelope-From:sk:michael
X-HELO:	atfriesa01.ssi-schaefer.com
Subject:	Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.3
To:	cygwin AT cygwin DOT com
References:	<announce DOT 20190130212227 DOT GP3912 AT calimero DOT vinschen DOT de> <19c5e653-890a-7c52-fde8-80df137223c9 AT ssi-schaefer DOT com> <20190131194813 DOT GT3912 AT calimero DOT vinschen DOT de> <20190203111937 DOT GG3532 AT calimero DOT vinschen DOT de> <f9e7921a-241b-7e75-52a6-84d0cf6e0ac0 AT ssi-schaefer DOT com> <20190206162037 DOT GC13951 AT calimero DOT vinschen DOT de> <20190206163424 DOT GD13951 AT calimero DOT vinschen DOT de>
From:	Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com>
Openpgp:	preference=signencrypt
Message-ID:	<57ac1756-e43f-e327-865e-a5b2147a5379@ssi-schaefer.com>
Date:	Thu, 7 Feb 2019 08:06:28 +0100
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0
MIME-Version:	1.0
In-Reply-To:	<20190206163424.GD13951@calimero.vinschen.de>

--ZpOUq1pZMHu9WvZyJCOz97RsKfrfdLOz1
Content-Type: multipart/mixed; boundary="wTRBrbpvKYv4I8kpvrCcQdj4hsv53dEIW";
 protected-headers="v1"
From: Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com>
To: cygwin AT cygwin DOT com
Message-ID: <57ac1756-e43f-e327-865e-a5b2147a5379 AT ssi-schaefer DOT com>
Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.3
References: <announce DOT 20190130212227 DOT GP3912 AT calimero DOT vinschen DOT de>
 <19c5e653-890a-7c52-fde8-80df137223c9 AT ssi-schaefer DOT com>
 <20190131194813 DOT GT3912 AT calimero DOT vinschen DOT de>
 <20190203111937 DOT GG3532 AT calimero DOT vinschen DOT de>
 <f9e7921a-241b-7e75-52a6-84d0cf6e0ac0 AT ssi-schaefer DOT com>
 <20190206162037 DOT GC13951 AT calimero DOT vinschen DOT de>
 <20190206163424 DOT GD13951 AT calimero DOT vinschen DOT de>
In-Reply-To: <20190206163424 DOT GD13951 AT calimero DOT vinschen DOT de>


--wTRBrbpvKYv4I8kpvrCcQdj4hsv53dEIW
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable



On 2/6/19 5:34 PM, Corinna Vinschen wrote:
> On Feb  6 17:20, Corinna Vinschen wrote:
>> On Feb  6 15:28, Michael Haubenwallner wrote:
>>> On 2/3/19 12:19 PM, Corinna Vinschen wrote:
>>>> On Jan 31 20:48, Corinna Vinschen wrote:
>>>>> On Jan 31 09:47, Michael Haubenwallner wrote:
>>>>>> Hi Corinna,
>>>>>>
>>>>>> I'm missing that topic/forkables branch in the announcement - is tha=
t in?
>>>>>> https://cygwin.com/ml/cygwin-patches/2017-q1/msg00053.html
>>>>>
>>>>> No, it's not.  It hasn't been touched for almost two years so I forgot
>>>>> about it.
>>>>>
>>>>> Does it still apply to current mainline?  Will it still work correctly
>>>>> in conjunction with the Windows 10 1709/1803/1809 changes in terms of
>>>>> deleting and renaming files?
>>>
>>> Independent of topic/forkables: With Cygwin 3.0.0 replacing/removing an
>>> exe or dll in use does fail on Server 2019 while it does succeed on 201=
2.
>>> The error messages on Server 2019 is 'Permission denied'.
>>
>> Is that the new FILE_DISPOSITION_POSIX_SEMANTICS change by any chance?
>>
>> https://sourceware.org/git/?p=3Dnewlib-cygwin.git;a=3Dcommitdiff;h=3Da7f=
392686b5b2
>>
>> If so, sigh, no new API without drawbacks.
>>
>> I guess we have to fallback to the old method in certain cases.
>=20
> Can you try this patch, please?

Seems to work so far, thanks!

/haubi/

>=20
> diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
> index 62b9638447ab..a1fd6cc9c975 100644
> --- a/winsup/cygwin/syscalls.cc
> +++ b/winsup/cygwin/syscalls.cc
> @@ -733,7 +733,11 @@ unlink_nt (path_conv &pc)
>        if (pc.file_attributes () & FILE_ATTRIBUTE_READONLY)
>  	NtSetAttributesFile (fh, pc.file_attributes ());
>        NtClose (fh);
> -      goto out;
> +      /* Trying to delete in-use executables and DLLs using
> +         FILE_DISPOSITION_POSIX_SEMANTICS returns STATUS_CANNOT_DELETE.
> +	 Fall back to the old method. */
> +      if (status !=3D STATUS_CANNOT_DELETE)
> +	goto out;
>      }
>=20=20
>    /* If the R/O attribute is set, we have to open the file with
>=20
>=20
> Thanks,
> Corinna
>=20


--wTRBrbpvKYv4I8kpvrCcQdj4hsv53dEIW--

--ZpOUq1pZMHu9WvZyJCOz97RsKfrfdLOz1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQKTBAEBCgB9FiEEY4PJ0Y//u+XgtVrKscWEirl385IFAlxb2PVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYz
ODNDOUQxOEZGRkJCRTVFMEI1NUFDQUIxQzU4NDhBQjk3N0YzOTIACgkQscWEirl3
85IX/A//U/JGAGNL/N1b7UBzMvAbq10ios7nSYNdQdgIIM/Swc9GvEqDSH2oVIwZ
7UuLEJhrs4nPq8FP2265/BlgN5OXhEglCuC6khStMlP1kAIKigF8jrEhH321Ak8Y
HhZHOj+HF5ofvEvYGyd1EHFfaBEAdmKvisw6NpfSuIKeoR+innAQ2uQpzC4lUo2e
I/2GiA4ATHsvQPe4dl+hmLVC/h7RKs3/9dtjGft0dqTVu3USUXZmej2Vnrr2xhcd
qz8eOT65C9XkcCJ3tHMNE0YyxA6QzoAO5zGETmRbhjcejjJ+9/4xPiYh2IfCq7A+
hTJHW1Xh3CJdjzhacXZ2CET13SFKdycsooP5vqxwktw/x9j5UuCJkHJS5ctI8wkl
yiGYnlGMmZfgVU3qQhlpQaKpqaQ8Qg1laJmEXiTq5Tk8JNyh+sKyOusdkgOYhww+
nl66ZrJ/TP3zZQkQS3nFQmwEZI13xaW5fLmJUw7athotEAMJaWAD+zqnQ5v+tFpd
02QVbajrABpeeglKsQTeubeyLsyLJKuz5aviRjEAnafYDbkMeDR3hCcXc8qrHB7m
sL8r0w6PajcsckMRT+3MZ7SvWYUX8CHQ4jlJVPWtHQmoty8yLgxvA4g3Gx8IdwFZ
Dw/Xc5TmuVa7Zr4/A6nj0jJJiyj/iW6rXiR+V2G7eQwNIh75Rzg=
=k/kM
-----END PGP SIGNATURE-----

--ZpOUq1pZMHu9WvZyJCOz97RsKfrfdLOz1--

- Raw text -