X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=QJB8DU9C5OThokQYeSMBgqiy31doRBYEkUZHP9CRNNd00TdcIFtBD
	/W1YsObevOeUSJqkNvrRb3UQPGbiN07sjBOKBv/wWgDYOy4hCZyD/ZCpgXL9uRlb
	diPDv8ABWs+eWMFdejEs2Zsb4cECUfh63+80XuOdJHlKWwzlUbxvw4=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=2eXNx+ujql0P6BC0Pxumi/LC97g=; b=L6vDXF/DYGKIec7mjn09TktXVwV/
	Okd7+H4eaqu9vYPry52lCsSJwwNsz7WbjtAyyaK4Eq+Pdv8NgKnvrsUH/eq56+u9
	PRf4jVX+N6Qhyzm7T1aST6T1lRmOSea+MzwZ7IO074/orV8HpEXYzP+/Mq59B0Nk
	1DY7RpD4LLHiHAQ=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-125.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=
X-HELO:	mout.kundenserver.de
Date:	Wed, 6 Feb 2019 17:34:24 +0100
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com>
Cc:	cygwin AT cygwin DOT com
Subject:	Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.3
Message-ID:	<20190206163424.GD13951@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	Michael Haubenwallner <michael DOT haubenwallner AT ssi-schaefer DOT com>, cygwin AT cygwin DOT com
References:	<announce DOT 20190130212227 DOT GP3912 AT calimero DOT vinschen DOT de> <19c5e653-890a-7c52-fde8-80df137223c9 AT ssi-schaefer DOT com> <20190131194813 DOT GT3912 AT calimero DOT vinschen DOT de> <20190203111937 DOT GG3532 AT calimero DOT vinschen DOT de> <f9e7921a-241b-7e75-52a6-84d0cf6e0ac0 AT ssi-schaefer DOT com> <20190206162037 DOT GC13951 AT calimero DOT vinschen DOT de>
MIME-Version:	1.0
In-Reply-To:	<20190206162037.GC13951@calimero.vinschen.de>
User-Agent:	Mutt/1.10.1 (2018-07-13)

--61jdw2sOBCFtR2d/
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb  6 17:20, Corinna Vinschen wrote:
> On Feb  6 15:28, Michael Haubenwallner wrote:
> > On 2/3/19 12:19 PM, Corinna Vinschen wrote:
> > > On Jan 31 20:48, Corinna Vinschen wrote:
> > >> On Jan 31 09:47, Michael Haubenwallner wrote:
> > >>> Hi Corinna,
> > >>>
> > >>> I'm missing that topic/forkables branch in the announcement - is th=
at in?
> > >>> https://cygwin.com/ml/cygwin-patches/2017-q1/msg00053.html
> > >>
> > >> No, it's not.  It hasn't been touched for almost two years so I forg=
ot
> > >> about it.
> > >>
> > >> Does it still apply to current mainline?  Will it still work correct=
ly
> > >> in conjunction with the Windows 10 1709/1803/1809 changes in terms of
> > >> deleting and renaming files?
> >=20
> > Independent of topic/forkables: With Cygwin 3.0.0 replacing/removing an
> > exe or dll in use does fail on Server 2019 while it does succeed on 201=
2.
> > The error messages on Server 2019 is 'Permission denied'.
>=20
> Is that the new FILE_DISPOSITION_POSIX_SEMANTICS change by any chance?
>=20
> https://sourceware.org/git/?p=3Dnewlib-cygwin.git;a=3Dcommitdiff;h=3Da7f3=
92686b5b2
>=20
> If so, sigh, no new API without drawbacks.
>=20
> I guess we have to fallback to the old method in certain cases.

Can you try this patch, please?

diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index 62b9638447ab..a1fd6cc9c975 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -733,7 +733,11 @@ unlink_nt (path_conv &pc)
       if (pc.file_attributes () & FILE_ATTRIBUTE_READONLY)
 	NtSetAttributesFile (fh, pc.file_attributes ());
       NtClose (fh);
-      goto out;
+      /* Trying to delete in-use executables and DLLs using
+         FILE_DISPOSITION_POSIX_SEMANTICS returns STATUS_CANNOT_DELETE.
+	 Fall back to the old method. */
+      if (status !=3D STATUS_CANNOT_DELETE)
+	goto out;
     }
=20
   /* If the R/O attribute is set, we have to open the file with


Thanks,
Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--61jdw2sOBCFtR2d/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlxbDJAACgkQ9TYGna5E
T6Bb8w/9E0P9wVxASc0U9YnK1IpT+wzM6QYviv7s9QWufFC7CjkSSyY61lUVQqiv
OXCBRMZ/XyjRtnFrwuFJfR0/NBhm77aMds0nAOsLkx8/g6XFOLmMVXOphsXbmDAV
tn4WdMVHqU0wbH+7M1bKiBbgVMLH9ADmyYWPNkpyY6lESS5H3q4ArEPrUdnnYnhE
Pa4DcULfvDaJI/kk5hWDu/ZqnoeMb2HQyCvwqJu9cDv7aROYd+3G39vzlvpPlvPx
OHNpJOBAxYFscqCM3JJpNl+S1zDj/9OwrneVo+5jkjMNb9H/XlYlDxdIwa5/qj4E
/tm3m/aKF0nWeqyxxZVWefbB3Sj6UKAlL6ffKF7TbHiY5h6Mb+ztXolNc2x8Qrb5
tA7jAOPaukrvAGCJ/G28Bw7mfqqN+BemzJq1bAoLGRSeND9195NI6vN7MI0oTcRK
fUngP5Urr3NnJFOXPebXxlq0daJr6OzVqnOIJsJw4Lr8n9v9i2L79DtgiFveMYFA
jbl+MEnaSbKx6Q8XRvDN15bvbQ3B2OzKHwfYVwP7gQ0ii7OTWmbr3/GkWzbaKobA
W76GLBtXI9Ttz4Pdi8tdCTwrDRSXpc1qWG+XjDKYMed9IeLRt2nUC4756Z7J2HHz
VB1Jof3rXQJM45llpOC3a7a+rdGhIkuMtTN4SJGHCIHRaOOzmuw=
=mVmB
-----END PGP SIGNATURE-----

--61jdw2sOBCFtR2d/--

- Raw text -