X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:subject:references:date:in-reply-to
	:message-id:mime-version:content-type; q=dns; s=default; b=c3qkO
	zrSUZ3WeV6i45skHOO7Uwo+H+3LhmKs8t81hgzaOXo67gMBDa4/K528BYiBnylaX
	xDxYUkHulCeT1ahSqgzF1NtzV26rw2KuQwuIsIMPhENf9hkM8NE1MWyXVPiXxVEs
	wpv8xLlxZhMP9MVGW6U/OG/sYLmJxHO1srDHjQ=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:subject:references:date:in-reply-to
	:message-id:mime-version:content-type; s=default; bh=e8Xjxc/Y3cV
	4FWU0bPhQY+TEY+k=; b=tT/DHuQQcGb+uWaw8aMyh00nKHVfVL6EAV6zsC+cK9j
	bB9xzWkSKmDSs+Len949QAvRXERg5yOwFFNSTQFzOlgX9xS3gTs+SjLlrDae6HmF
	FLzb1ezpd8xDy+QPbWq8HxwcHa7cGUHeS71Ieg9PKeeXWj7MhZweUtW3oQw707vM
	=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=tarxz, pvr, debuginfo-$, a3997ae7ac
X-HELO:	vsmx009.vodafonemail.xion.oxcs.net
From:	Achim Gratz <Stromeko AT nexgo DOT de>
To:	cygwin AT cygwin DOT com
Subject:	Re: cygport fails with package starting with number
References:	<703d2702-0407-82fa-3a84-237bc913cd41 AT gmail DOT com> <878t24d4qd DOT fsf AT Rainer DOT invalid> <35e00f32-4e09-34d9-d1f6-34544a92bd2e AT SystematicSw DOT ab DOT ca>
Date:	Wed, 07 Nov 2018 22:14:42 +0100
In-Reply-To:	<35e00f32-4e09-34d9-d1f6-34544a92bd2e@SystematicSw.ab.ca> (Brian Inglis's message of "Wed, 7 Nov 2018 14:02:04 -0700")
Message-ID:	<87sh0cbnel.fsf@Rainer.invalid>
User-Agent:	Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version:	1.0

Brian Inglis writes:
> On 2018-11-07 13:15, Achim Gratz wrote:
>> Marco Atzeri writes:
>>> It seems that the behaviour of cygport is changed recently
>>> and rebuilding the 4ti2 package fails on the name 4ti2.
>> Introduced by a3997ae7ac, which constructs a variable whose name starts
>> with the package name.  However, a leading number does not result in a
>> valid identifier.  So if such package names must be supported then the
>> substitution made earlier (replacing invalid characters from the name by
>> an underscore) also needs to handle that particular case.  So something
>> like
>>                 local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS;
>> +               dbg_contents_var=${dbg_contents_var/#[0-9]/_}
>>                 __step "${PN}-debuginfo-${PVR}.tar.xz";
>> in lib/pkg_pkg.cygpart should fix it.
>
> or just prefix var name with "_":
>
> 		[ -d ${autoloaddir} ] || autoloaddir=
> -		local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS;
> +		local dbg_contents_var=_${PN//[-+\.]/_}_debuginfo_CONTENTS;

That would run against the naming convention cygport assumes and thus
break all cygport files that make use of them (which probably are just a
a handful, but the breakage is easy enough to avoid).


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -