X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:reply-to:subject:to:references:from:message-id
	:date:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=o9jllv0Pj+zP91Vu
	BXxmm18wpGPbyD2BFUjTD1mqFT5Kj9ujva2ZNhp8LMixI2U/7OYahrNCJOp8qPei
	VqeFwUZXP6NIy5kL7hdgboPpmtve+f/3k+96kYB+hKdfaLQPBKR5wG38ZhsGficP
	aitLtl3NzMxbQJWEq+SqwWFDBZw=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:reply-to:subject:to:references:from:message-id
	:date:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=4cEFrTBjQs3t5JgSPBE+CR
	zMvSY=; b=YdNdT4iNiBEWbIoUwd+BQ4ZqFCKHGpItri0WQX5IgsOx/XIXBFROYJ
	Eor67AlTCawpC4000GhIcp0p7EgRw6jmLhbH9oC2pD3Lpnc2G/z2Jk41sllwDvBo
	fbSorwKDxitoXAcbTR7etKTZB64EI+owy+PsGz7UQXNd2vXGhzfEE=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-0.5 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=disturbing, tarxz, pvr, debuginfo-$
X-HELO:	smtp-out-so.shaw.ca
Reply-To:	Brian DOT Inglis AT SystematicSw DOT ab DOT ca
Subject:	Re: cygport fails with package starting with number
To:	cygwin AT cygwin DOT com
References:	<703d2702-0407-82fa-3a84-237bc913cd41 AT gmail DOT com> <878t24d4qd DOT fsf AT Rainer DOT invalid>
From:	Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
Openpgp:	preference=signencrypt
Message-ID:	<35e00f32-4e09-34d9-d1f6-34544a92bd2e@SystematicSw.ab.ca>
Date:	Wed, 7 Nov 2018 14:02:04 -0700
User-Agent:	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version:	1.0
In-Reply-To:	<878t24d4qd.fsf@Rainer.invalid>
X-IsSubscribed:	yes

On 2018-11-07 13:15, Achim Gratz wrote:
> Marco Atzeri writes:
>> It seems that the behaviour of cygport is changed recently
>> and rebuilding the 4ti2 package fails on the name 4ti2.
> Introduced by a3997ae7ac, which constructs a variable whose name starts
> with the package name.  However, a leading number does not result in a
> valid identifier.  So if such package names must be supported then the
> substitution made earlier (replacing invalid characters from the name by
> an underscore) also needs to handle that particular case.  So something
> like
>                 local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS;
> +               dbg_contents_var=${dbg_contents_var/#[0-9]/_}
>                 __step "${PN}-debuginfo-${PVR}.tar.xz";
> in lib/pkg_pkg.cygpart should fix it.

or just prefix var name with "_":

		[ -d ${autoloaddir} ] || autoloaddir=
-		local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS;
+		local dbg_contents_var=_${PN//[-+\.]/_}_debuginfo_CONTENTS;


-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -