X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=QIdZdW13xZZryRyq
	+ExFr/uWX0wCEtPxnxru/NFwLJn8zDHkQVpZ2RGp0iVaLFEudt+7EjUUM1UoPUAx
	/0exwXc+OdqNEPVUc7SmPMSduAlNIudiEWOJfXyhvhtsZQqvsq5pCpc4iMy88umv
	d5f9LvpUaw+p+Y/4Qi6+qW5Zi5c=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=egXWZL8IeFeA++dJPVLyJX
	VFkW8=; b=q2dSj37eBHuoyrSh/LK1064iFBv71JtCABYxwTEp0VFlZi6CmEXcSN
	89ztE3MMe/KKAoJf+TdIWDgFh3CG7hIVUKddn/8ESUCpWmTkw6THLqxGkw8POpvo
	8LHvORB3crLbqcJXw6s0sbQjA7sA029dl0zUcuD/1JvonglVaNZos=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Spam-SWARE-Status:	No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=emailing, H*F:D*mail.com, H*Ad:D*mail.com, intend
X-HELO:	mout.gmx.com
Subject:	Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1
To:	cygwin AT cygwin DOT com
References:	<announce DOT 20180809202604 DOT GN4180 AT calimero DOT vinschen DOT de> <cc1d684fabcfe5e581ec82aae1617471 AT smtp-cloud8 DOT xs4all DOT net> <20180810114254 DOT GA25560 AT calimero DOT vinschen DOT de> <57b3092a9b5027be5f14e59c305200bc AT smtp-cloud8 DOT xs4all DOT net> <71f1280d04f70e8b74cfce78ba5690d3 AT xs4all DOT nl> <f9b36ce5-9027-b7a5-fd06-baa951f6812e AT redhat DOT com> <9a902fe9715b173671599a2e32eca26d AT xs4all DOT nl>
From:	john doe <johndoe65534 AT mail DOT com>
Message-ID:	<8d94b72b-4be9-311a-ddc6-c43942234693@mail.com>
Date:	Tue, 14 Aug 2018 08:09:45 +0200
MIME-Version:	1.0
In-Reply-To:	<9a902fe9715b173671599a2e32eca26d@xs4all.nl>
X-IsSubscribed:	yes
Note-from-DJ:	This may be spam

On 8/14/2018 12:26 AM, Houder wrote:
> On 2018-08-14 00:16, Eric Blake wrote:
>> On 08/13/2018 04:29 PM, Houder wrote:
>>
>>>> The modication would require changing:
>>>>
>>>> winsup/cygwin/fenv.cc (_feinitialise() )
>>>> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT)
>>>
>>> GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters 
>>> in this
>>> line:
>>>
>>>       Intel® 64 and IA-32 Architectures Software Developer’s Manuals:
>>>
>>> ... part of a comment at the beginning of the file.
>>>
>>> (the registered trademark sign (u00ae) is encoded as 0xae (cp1252), 
>>> while it
>>>   would be: 0xc2 0xae, in utf-8,
>>>   the right single quotation mark (u2019) is encoded as 0x92 
>>> (cp1252), but in
>>>   utf-8 it would be: 0xc2 0x80 0x98)
>>>
>>> I intend to convert the file encoding of fenv.h to utf-8. Is that a 
>>> "No-No"
>>> or is it allowed? (I assume GIT will notice).
>>
>> In general, git doesn't care if you change a file's encoding - that's
>> just another content change.  In practice, you may get weird effects
>> when viewing that particular patch (as the patch is not well-formed in
>> the new multibyte locale, and looks funky when displayed in the old
>> locale), and emailing a patch may require care in telling git which
>> encoding to use for the email; but that's cosmetic, and shouldn't
>> matter in the long run.  Updating the code base to uniformly use UTF-8
>> seems reasonable to me.
> 
> ... and emailing a patch may require care in telling git which encoding
> to use for the email ... Huh, huh ?????
> 
> Last time I used:
> 
>   - git format-patch
>   - git send-mail
> 
> Am I safe here?
> 

To better understand what has happened in the code cosmetic changes 
should be done in separate commits.

- Code changes -- Will only change the code.
- Cosmetic changes -- Will only change the cosmetic aspect of the code 
(encoding, spacing, indentation ...)

In most cases you can simply do 'git send-email' and pass the options 
for 'git format-patch' at the end of the cmd:

$ git send-email master --to=me AT example DOT com --reroll-count 1 --rfc


The options '--reroll-count, --rfc' are format-patch options.

-- 
John Doe

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -