delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2018/08/13/18:26:21

X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
:list-unsubscribe:list-subscribe:list-archive:list-post
:list-help:sender:mime-version:content-type
:content-transfer-encoding:date:from:to:subject:in-reply-to
:references:message-id; q=dns; s=default; b=jx38CzyvM2AqBtp1A6kx
n1pkpuzyX1I2/N1zh0HqjxaZtrUquj/YjctjYaG1QD3nl5LOngPr/kLaiGVPE1Sd
fLIcNtAwxlWXwh2VKCE1dotE1R0Vzd/cfvR4Xv/z+4mrmTi8p6H8Pje/epo0fYnO
UlCMIJXSMjSsdQ2PNPlIMbc=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
:list-unsubscribe:list-subscribe:list-archive:list-post
:list-help:sender:mime-version:content-type
:content-transfer-encoding:date:from:to:subject:in-reply-to
:references:message-id; s=default; bh=/hnWCRHd6DEUeuhf1+o6sVDHRE
k=; b=hQYrMhRzFICgHT81dLJAEsCz3gku7r3eXzi5sb557etbpQKZlgtd0cMeo5
sOTlLZTcgWlWXnkhIZrO4pc6C9pLCusEPgkmrv1UzyWyP+FwRXDjYTuo44/KJTyW
EewRNUcASssfRF0i3z0RbF84eJJqDH23+G0plJ2DpniJXlgd4=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_40,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=emailing, H*r:sk:webmail, Hx-spam-relays-external:sk:webmail, H*RU:sk:webmail
X-HELO: lb1-smtp-cloud9.xs4all.net
MIME-Version: 1.0
Date: Tue, 14 Aug 2018 00:26:07 +0200
From: Houder <houder AT xs4all DOT nl>
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1
In-Reply-To: <f9b36ce5-9027-b7a5-fd06-baa951f6812e@redhat.com>
References: <announce DOT 20180809202604 DOT GN4180 AT calimero DOT vinschen DOT de> <cc1d684fabcfe5e581ec82aae1617471 AT smtp-cloud8 DOT xs4all DOT net> <20180810114254 DOT GA25560 AT calimero DOT vinschen DOT de> <57b3092a9b5027be5f14e59c305200bc AT smtp-cloud8 DOT xs4all DOT net> <71f1280d04f70e8b74cfce78ba5690d3 AT xs4all DOT nl> <f9b36ce5-9027-b7a5-fd06-baa951f6812e AT redhat DOT com>
Message-ID: <9a902fe9715b173671599a2e32eca26d@xs4all.nl>
X-Sender: houder AT xs4all DOT nl
User-Agent: XS4ALL Webmail
X-IsSubscribed: yes
Note-from-DJ: This may be spam

On 2018-08-14 00:16, Eric Blake wrote:
> On 08/13/2018 04:29 PM, Houder wrote:
> 
>>> The modication would require changing:
>>> 
>>> winsup/cygwin/fenv.cc (_feinitialise() )
>>> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT)
>> 
>> GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters 
>> in this
>> line:
>> 
>>       Intel® 64 and IA-32 Architectures Software Developer’s Manuals:
>> 
>> ... part of a comment at the beginning of the file.
>> 
>> (the registered trademark sign (u00ae) is encoded as 0xae (cp1252), 
>> while it
>>   would be: 0xc2 0xae, in utf-8,
>>   the right single quotation mark (u2019) is encoded as 0x92 (cp1252), 
>> but in
>>   utf-8 it would be: 0xc2 0x80 0x98)
>> 
>> I intend to convert the file encoding of fenv.h to utf-8. Is that a 
>> "No-No"
>> or is it allowed? (I assume GIT will notice).
> 
> In general, git doesn't care if you change a file's encoding - that's
> just another content change.  In practice, you may get weird effects
> when viewing that particular patch (as the patch is not well-formed in
> the new multibyte locale, and looks funky when displayed in the old
> locale), and emailing a patch may require care in telling git which
> encoding to use for the email; but that's cosmetic, and shouldn't
> matter in the long run.  Updating the code base to uniformly use UTF-8
> seems reasonable to me.

... and emailing a patch may require care in telling git which encoding
to use for the email ... Huh, huh ?????

Last time I used:

  - git format-patch
  - git send-mail

Am I safe here?

Regards,
Henri

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019