X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:message-id:from:to:subject:in-reply-to
	:references:mime-version:content-type; q=dns; s=default; b=SIIYo
	FP4FklIGDr/l2J8WqeJIlRFwkbt8jBnjKo7KfoyClV/1sphBVtKUWxBhoqK5HgQk
	4M0S0zvJ2th028UqdlxsDkJLNHtQQGygyY/xWcRr38+HZpv1Ul+9c+IDC2HWetrZ
	7Q6hp4/wE9N931VTJt2FJR75JF8tBEedbEPS1M=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:message-id:from:to:subject:in-reply-to
	:references:mime-version:content-type; s=default; bh=bmxIGa+2fot
	D70ixdlNTAEwVEiM=; b=KSmqpF3j4xwqtYIo/5mqBAbSGEFiDVK0MycYk1g1ZkZ
	k+yUh4jubnqGiU/WI3AgJbdh002DT5jgelJkIM8cpaQgB6qeUZjeRUNip+/0e3QO
	Y3a2tthSdZrAwYACE4TWoG8FK9XdJ7iyH6QdPQgPTIQFMcFYRFw+MB2pj4kCPiuc
	=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-10.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=BEFORE, oversight
X-HELO:	scan1.ztv.ne.jp
Date:	Wed, 25 Apr 2018 14:10:56 +0100
Message-ID:	<xolh8nzph27.wl-atara-y@mx.scn.tv>
From:	Yasutaka Atarashi <atara-y AT mx DOT scn DOT tv>
To:	cygwin AT cygwin DOT com
Subject:	Re: subversion problem
User-Agent:	Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (i686-pc-mingw32) MULE/6.0 (HANACHIRUSATO)
In-Reply-To:	<77a982f8-d617-7a1d-2ac1-c0843ba30c94@acm.org>
References:	<9c2c7358137b4513a7b8f5fc08386354 AT vsrv060ex03 DOT ssd DOT fsi DOT com> <77a982f8-d617-7a1d-2ac1-c0843ba30c94 AT acm DOT org> <xolin8jpcbe DOT wl-atara-y AT mx DOT scn DOT tv>
MIME-Version:	1.0 (generated by SEMI 1.14.6 - "Maruoka")

Hi David,

I had some doubt that the modification suggested in my mail:
Cygwin subversion and UNC path https://cygwin.com/ml/cygwin/2018-04/msg00271.html
would cause the failure.
However, this would not be the case.

I'm afraid to say that it seems to be an oversight in 05-retry-loop.patch.

The first call of the loop target function must be made BEFORE the call of WIN32_RETRY_LOOP() while Cygwin branch of svn_io_file_rename2() calls WIN32_RETRY_LOOP() directly. 

I've made just simple tests only but applying the following patch additionally and replacing cygsvn_subr-1-0.dll seems to fix the issues.

--- origsrc/subversion-1.10.0/subversion/libsvn_subr/io.c	2018-04-24 15:58:49.920742300 +0900
+++ src/subversion-1.10.0/subversion/libsvn_subr/io.c	2018-04-24 21:16:56.215447100 +0900
@@ -4294,6 +4294,7 @@ svn_io_file_rename2(const char *from_pat
       status = apr_file_rename(from_path_apr, to_path_apr, pool);
     }
 #elif defined (__CYGWIN__)
+  status = apr_file_rename(from_path_apr, to_path_apr, pool);
   WIN32_RETRY_LOOP(status, apr_file_rename(from_path_apr, to_path_apr, pool));
 #else
   status = apr_file_rename(from_path_apr, to_path_apr, pool);

Regards,
Yasutaka ATARASHI

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -