X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type; q=dns; s=default; b=bU9Y
	63boGPSmsyWr1txMExRIZHx4NMDCiyZD8Rs0b7/PhRGwFgFb+WEqBtf2SYrPfC5x
	knJKtiKBV1/maCp5OyWB3bZv43wxVvXKZB/D8TCMmuYuMsSGdtTdisZ3tks1+6RO
	4oO/fSL6kOPyJ6D9Ju3RgvMUy63MTJpSK0Y72HU=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type; s=default; bh=3Fg8WCgiqB
	cMUexRVrP+Us2lJHM=; b=WeE5NQCYNdmBVvH43gRsZQHf43iyfSaMsr9584gJHq
	lxUHGJH/fhn+KsfbRA0OHsWpJlz3eMM12FTEtUXyzptIEVmozGKNO8a5X6vWQ9kA
	ZXIN394drO0w6A4Ee/Jn4T1zQO7JKHtGtS+zLu1gLn9pHFKMf/uk5vJys8qFRo8r
	k=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-10.4 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=4.2, licensing, H*M:cygwin
X-HELO:	mx1.redhat.com
Subject:	Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.10.0-0.1
To:	cygwin AT cygwin DOT com
References:	<announce DOT 20180116155108 DOT GA9503 AT calimero DOT vinschen DOT de> <9990d909-f112-9658-1b0f-d63e3f338a18 AT cornell DOT edu> <4f7edc68-4c98-8fa3-9fef-47bdd3343330 AT cornell DOT edu> <3b738a06-a3b8-210b-2886-4c9701efcd48 AT cygwin DOT com> <eb4e6cf2-12aa-bb4c-738e-f2259f58f3fe AT cornell DOT edu> <c5a92ae1-3b63-0227-f170-fa1d0ac959eb AT cornell DOT edu> <39045e32-8a2c-c767-0fcd-27d544ba6d93 AT cornell DOT edu> <e8cdfc99-bcad-eb80-ec48-9e1bdefbe69d AT cornell DOT edu> <5769e163-8716-23b3-520e-dbae6faaa84a AT cornell DOT edu>
From:	Yaakov Selkowitz <yselkowitz AT cygwin DOT com>
Message-ID:	<85d3c271-55c6-0002-42cd-f46ef588be4d@cygwin.com>
Date:	Wed, 24 Jan 2018 18:16:17 -0600
User-Agent:	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
MIME-Version:	1.0
In-Reply-To:	<5769e163-8716-23b3-520e-dbae6faaa84a@cornell.edu>
X-IsSubscribed:	yes

--phBQZquBBXdcMyZVvS444qsX9sZdfu5si
Content-Type: multipart/mixed; boundary="fWI6o5831vpYEWme5H2boJSoAIqBZmTG6";
 protected-headers="v1"
From: Yaakov Selkowitz <yselkowitz AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Message-ID: <85d3c271-55c6-0002-42cd-f46ef588be4d AT cygwin DOT com>
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.10.0-0.1
References: <announce DOT 20180116155108 DOT GA9503 AT calimero DOT vinschen DOT de>
 <9990d909-f112-9658-1b0f-d63e3f338a18 AT cornell DOT edu>
 <4f7edc68-4c98-8fa3-9fef-47bdd3343330 AT cornell DOT edu>
 <3b738a06-a3b8-210b-2886-4c9701efcd48 AT cygwin DOT com>
 <eb4e6cf2-12aa-bb4c-738e-f2259f58f3fe AT cornell DOT edu>
 <c5a92ae1-3b63-0227-f170-fa1d0ac959eb AT cornell DOT edu>
 <39045e32-8a2c-c767-0fcd-27d544ba6d93 AT cornell DOT edu>
 <e8cdfc99-bcad-eb80-ec48-9e1bdefbe69d AT cornell DOT edu>
 <5769e163-8716-23b3-520e-dbae6faaa84a AT cornell DOT edu>
In-Reply-To: <5769e163-8716-23b3-520e-dbae6faaa84a AT cornell DOT edu>


--fWI6o5831vpYEWme5H2boJSoAIqBZmTG6
Content-Type: text/plain; charset=utf-8
Content-Language: en-CA
Content-Transfer-Encoding: quoted-printable

On 2018-01-24 13:25, Ken Brown wrote:
> On 1/20/2018 6:49 PM, Ken Brown wrote:
>> On 1/20/2018 7:23 AM, Ken Brown wrote:
>>> On 1/19/2018 10:27 PM, Ken Brown wrote:
>>>> Here's another issue that's come up with _FORTIFY_SOURCE.=C2=A0 One of=
 the=20
>>>> emacs source files, fileio.c, makes use of a pointer to readlinkat.=20
>>>> When _FORTIFY_SOURCE > 0, this leads to an "undefined reference to=20
>>>> `__ssp_protected_readlinkat'" linking error.=C2=A0 Does this sound lik=
e=20
>>>> something that will be fixed with the new gcc release?
>>>
>>> I got to this sooner than expected:
>>>
>>> $ cat ssp_test.c
>>> #define=C2=A0 _FORTIFY_SOURCE 1
>>> #include <unistd.h>
>>> void foo (ssize_t (*preadlinkat) (int, char const *, char *, size_t));
>>>
>>> void baz ()
>>> {
>>> =C2=A0=C2=A0 foo (readlinkat);
>>> }
>=20
> The following patch seems to fix the problem:
>=20
> -#define __ssp_inline extern __inline__ __attribute__((__always_inline__,=
 __gnu_inline__))
> +#define __ssp_inline extern __inline__ __attribute__((__always_inline__))

No, that would have other consequences:

https://gcc.gnu.org/onlinedocs/gcc/Inline.html

> I arrived at this by comparing Cygwin's ssp.h with NetBSD's, on which
> Cygwin's was based, and I noticed that NetBSD didn't use __gnu_inline__.

The BSDs also stuck with GCC 4.2 due to licensing reasons, so you can't
always compare.

> Yaakov, is there a reason that Cygwin needs __gnu_inline__?

Because the semantics of inline changed in GCC 4.3.

> It apparently prevents fortified functions from being used as function po=
inters.

I am currently testing the following, which seems to match glibc in this
detail:

--- a/newlib/libc/include/ssp/ssp.h
+++ b/newlib/libc/include/ssp/ssp.h
@@ -51,7 +51,6 @@
                __chk_fail()
 #define __ssp_decl(rtype, fun, args) \
 rtype __ssp_real_(fun) args __asm__(__ASMNAME(#fun)); \
-__ssp_inline rtype fun args __asm__(__ASMNAME("__ssp_protected_" #fun)); \
 __ssp_inline rtype fun args
 #define __ssp_redirect_raw(rtype, fun, args, call, cond, bos) \
 __ssp_decl(rtype, fun, args) \

--=20
Yaakov


--fWI6o5831vpYEWme5H2boJSoAIqBZmTG6--

--phBQZquBBXdcMyZVvS444qsX9sZdfu5si
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHQEARECADQWIQRFYAu5jKh4qpenARn/IK+aZu4flAUCWmkh0xYceXNlbGtvd2l0
ekBjeWd3aW4uY29tAAoJEP8gr5pm7h+U494Ani45DnvB+4ApetJfLG3FqQdWo3/V
AJwOEDuhzUSfZrFtEU8DEDAyrJeJ2w==
=pjRW
-----END PGP SIGNATURE-----

--phBQZquBBXdcMyZVvS444qsX9sZdfu5si--

- Raw text -