X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:from:date:message-id:subject:to
	:content-type; q=dns; s=default; b=kAjSej9wIy6Zlnie9VD40dmhHocZj
	nfdbHjyJtrUKc3CTEDTgjuodYzaKw5ul8vmdb052izJ9OKnf3zfIATwuUpH0OjiM
	91xIAFEKEHgM0zKI5FN0KQEzBmKkZ4N/XcqFW8VOABmiDQnygSbzbA953aboAOWL
	kxGAgpxzGujfq0=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:from:date:message-id:subject:to
	:content-type; s=default; bh=v0AnMTC5ZAPU8hnwkiBt07ZKsqs=; b=TPA
	ErLUAp6X4f6b9XzAGioijnGz6aGCo8xHc2hZcGjgire/RtZ4n9X+rI7xjx1PcHbq
	5TE3bkceYkCdT9H2jjxqc7PqiK5GAgeYnCJurTPo9KyFPACn0GZd791KMLQK/a4X
	yzUOSgi34l2ARH22RsP3V4rtMNAL/VvL6vZgNdfU=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-1.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=calm, Hx-languages-length:944
X-HELO:	mail-lf0-f50.google.com
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NwcKiWAPnAUtng2BRoVlpAnqlN1JrBnL7dKcHp3ml8E=; b=dNnTre6yeGM7di4aBsiQYU/2r5qPP+eGloSX2/mNM6K4cUyL851H7RQ4ga0xVRflUn araFQNEYNFeW9mwCXwhApuAvv3rR5idHNg/MtWg6FrR5slM3VkPtPgPDlrlLDj8/Tbmq brZJPqklVwAZ4TMOBWZ3e5pVBaJ8cIApat45IxTfKIgcVYkjddtKphYw2Oo9NDe7XNGE ZA1znd9A1NvJ8/Egev3+CSjBzpIKMDBW14nsfuFgUt26g+arUpkHvyL3dCuxrfVZswzA 6wciK4crWIfOi7t4dSFV/TraH6hEQBOGJYJnnbFRjQFTCyg/5EU9nLaTI3JN1Pw8o/c5 /suQ==
X-Gm-Message-State:	AJaThX7CEKeld8iLZsaeM5Q4/7PdmyBJrhZSQufsR1LdS4TIdXzxmDWx 9wXL3cRbjSu1L4tg2x1uLl8uGZzOdRyjXoI57BiPMg==
X-Google-Smtp-Source:	AGs4zMb+2BBqCvW6Z0b9drE5BexWc4PY/J4HLgw/xnSn6Z/W0oLC9w21WwqgiXUFQXYHo+ptJdu3XVNOZyh0UTy12ZY=
X-Received:	by 10.25.15.73 with SMTP id e70mr1343015lfi.64.1511967526530; Wed, 29 Nov 2017 06:58:46 -0800 (PST)
MIME-Version:	1.0
From:	Ivan Gagis <igagis AT gmail DOT com>
Date:	Wed, 29 Nov 2017 16:58:45 +0200
Message-ID:	<CAL_02JBwqseAuH+N+-AE-5A9bs1Y-Nvrt080e-p88pHwVy4mGA@mail.gmail.com>
Subject:	mksetupini does not return error code
To:	The Cygwin Mailing List <cygwin AT cygwin DOT com>
X-IsSubscribed:	yes

Hi,

I found that in case packages validation fails the mksetup script just
returns success, though it prints a line in the console saying
"mksetupini: package set has errors, not writing setup.ini".

I think it should return some error code so that it would not be
considered as success by CI scripts where mksetupini is called from.

The problematic lines are as following:

https://cygwin.com/git/?p=cygwin-apps/calm.git;a=blob;f=calm/mksetupini.py;h=f24e4c5751e1f7e13516e8689c041403ba1f8d38;hb=HEAD#l63
returns nothing, should return non-zero error code.

https://cygwin.com/git/?p=cygwin-apps/calm.git;a=blob;f=calm/mksetupini.py;h=f24e4c5751e1f7e13516e8689c041403ba1f8d38;hb=HEAD#l118
returns nothing, should return result of do_main().

I'm not familiar with python, so I don't submit a patch, but even
without knowing python it is clearly seen that the errors are not
returned properly.

Br,
Ivan

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -