X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=LpGGCJr3qbmYTICD9+Cl7zdmnS4n5EXNCDSPPaxylELU4yeAd9Utk
	B9GNaqU2hSsPA3QK7IGB5RBfY+Twz5VxImUcFhW2IwWhLSdgE5GB9Ig8jQVPzQiJ
	h/hTNQU+wio/RRS3i8QSp9/tZmobh0CADJFSfDSoDHV4G137v7ZvUM=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=P3c5hItSYIQJllZvcBgdW+ca5M4=; b=XPg8RnvFfg37hk85c0YIqKubRxex
	N9qhoYgbfsVAsXLXrz05ECh+2b90EMzj8nniVaUw0oM/phFwh3F28x6TR8kxbDJs
	wJZdzvJ8sxPjKReJKGHxE8o5z7i546VwpD6GnlfFCCiAe1tdwoT5mxK8grso/X7s
	AWwqajpBPnmtLo8=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-107.3 required=5.0 tests=AWL,BAYES_00,BODY_8BITS,GARBLED_BODY,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=japanese, Japanese, HCc:D*cygwin.com, H*c:application
X-HELO:	drew.franken.de
Date:	Tue, 6 Jun 2017 18:48:09 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	Fujii Hironori <fujii DOT hironori AT gmail DOT com>
Cc:	cygwin AT cygwin DOT com
Subject:	Re: BUG: Error messages of regtool are wrongly encoded
Message-ID:	<20170606164809.GD23208@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	Fujii Hironori <fujii DOT hironori AT gmail DOT com>, cygwin AT cygwin DOT com
References:	<CALus1PkHChR0nCaahAy4vp+i6RNm38Nv9CsM5yPNejyrS5yETQ AT mail DOT gmail DOT com>
MIME-Version:	1.0
In-Reply-To:	<CALus1PkHChR0nCaahAy4vp+i6RNm38Nv9CsM5yPNejyrS5yETQ@mail.gmail.com>
User-Agent:	Mutt/1.8.0 (2017-02-23)

--wLAMOaPNJ0fu1fTG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Fujii,

On May 16 18:15, Fujii Hironori wrote:
> Error messages of regtool can't be read, which are encoded in
> SHIFT_JIS in Japanese Windows.
>=20
>  $ regtool get /HKCU/hoge
> Error (2): =E2=96=92w=E2=96=92=E8=82=B3=E2=96=92=E2=96=92t=E2=96=92@=E2=
=96=92C=E2=96=92=E2=96=92=E2=96=92=E2=96=92=E2=96=92=E2=96=92=E2=96=92=E2=
=96=92=E2=96=92=E2=96=92=DC=82=E2=96=92=E2=96=92=E2=96=92B
>=20
>  $ regtool get /HKCU/hoge 2>&1 | iconv -f shift_jis
> Error (2): =E6=8C=87=E5=AE=9A=E3=81=95=E3=82=8C=E3=81=9F=E3=83=95=E3=82=
=A1=E3=82=A4=E3=83=AB=E3=81=8C=E8=A6=8B=E3=81=A4=E3=81=8B=E3=82=8A=E3=81=BE=
=E3=81=9B=E3=82=93=E3=80=82
>=20
>=20
> --- regtool.cc.orig 2017-05-16 17:20:32.671229600 +0900
> +++ regtool.cc 2017-05-16 17:21:18.859375500 +0900
> @@ -197,13 +197,13 @@
>  void
>  Fail (unsigned int rv)
>  {
> -  char *buf;
> +  wchar_t *buf;
>    if (!quiet)
>      {
> -      FormatMessage (FORMAT_MESSAGE_ALLOCATE_BUFFER
> +      FormatMessageW (FORMAT_MESSAGE_ALLOCATE_BUFFER
>       | FORMAT_MESSAGE_FROM_SYSTEM,
> -     0, rv, 0, (CHAR *) & buf, 0, 0);
> -      fprintf (stderr, "Error (%d): %s\n", rv, buf);
> +     0, rv, 0, (WCHAR *)& buf, 0, 0);
> +      fprintf (stderr, "Error (%d): %ls\n", rv, buf);
>        LocalFree (buf);
>      }
>    exit (1);

Unfortunately this patch doesn't apply cleanly.  Any chance you can
create a patch with `git format-patch' and send that as attachment?


Thanks,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--wLAMOaPNJ0fu1fTG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZNtzJAAoJEPU2Bp2uRE+gx1AP/0u4mH7ugBYOFSp9a0gtDEtx
WINOZY9RTLinsZxKjsuTMUdStd8xtzlz6tfEbaT2jqTKO5LAmSY/GdX08Quoj8S7
DfyHTnBCJDil/I/1uIvWGCMvvYOknZLnI0mKzW/4oJuCvTxv6oJ0fuCVQJ4KhcVg
V2Ymagv6+REPlwmHlNUKb+gNK05g75v7XKJNTEqHfqnTxB0Gn848jdhinwzrsLvz
wEEF7RhDALpIc5DBMKNN/4XQmrQVcLlTYVoAOAHIK6KjgyLB5l1KDUvjl9tiRKyK
LMgT86LcftDNDfqhFQkm2GvlT6Hzeq1HFN7vXerv2OfMShXC4eKR8saKa42jA+Gk
p8Frr6vMQUdtsHmiCqC2Aj71gTUB8gvJeZdFUF4KWej44+rJV5Tr9Ym98Y4kFXS6
vpvjv6uuCi9a0ERlyV+ItYIP+UnsuH6Oahk9QHQiLhGLUglm6irgvJGyWklOACsd
udY6getjxQILlqjU/KYhyrBweYQIZKZotajcZgLaVAIo+D9B1Y7bRjZGX0UPzgTo
73fTcb7cEPADk8sHO3/QsfOUr3XaGs2gHnUvrAerY9obIkMnNFONL/VNeOnYTm2s
kEYS5pdieYmwVVA5ACjRxEwPP5nOB3x0G2CugAeXhRcO6O9ryhmdJbosV0SFyROS
EHDpFDYNmk5xr9wsciI5
=TaQ1
-----END PGP SIGNATURE-----

--wLAMOaPNJ0fu1fTG--

- Raw text -