X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:in-reply-to
	:references:mime-version:content-type; q=dns; s=default; b=yLzRK
	oUWvcCdGDqsbDYSqM448SAyucwVdotQ6wfyo3wR8kw7Tth4KHWDnJhPYnZi5MrFS
	CGP1cLXZ+mXu78KbtRr0SiUrlfSEgoSb6zpTzAAHPVA4PgT+y3vfetTLvi+tMkJq
	HMFRkH62WNlwEx7dTuXQCIMbhR/xccAgVyXNeQ=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:in-reply-to
	:references:mime-version:content-type; s=default; bh=xKtyZcGtXMs
	jpW6ayhHFLbnfFac=; b=ubEvp4IdCXaMMd6gOsJNxQ+O9dUJ+a2Ci4q+8/wE8Ac
	DNmngoD1JzxXAnm/JefkY8zqHQa0aivZB59ro6xWdhYMrBZSvjzkpGlwU0ikUEch
	IHUTzWoFkUD/iTYhffdIV12Mi4/KY/7IINTm3gCrJdI6D2GTpTHeWG8L49Zsuk5k
	=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-6.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.2 spammy=employed, H*c:HHHH
X-HELO:	conssluserg-05.nifty.com
DKIM-Filter:	OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v2SBqUwL024607
X-Nifty-SrcIP:	[175.179.23.201]
Date:	Tue, 28 Mar 2017 20:52:31 +0900
From:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
To:	cygwin AT cygwin DOT com
Subject:	Re: [ANNOUNCEMENT] python3 3.6.1-2 (x86 only)
Message-Id:	<20170328205231.e62a862e4e350b9b1f773de8@nifty.ne.jp>
In-Reply-To:	<20170325094638.5209c67a5efef02f51a99e75@nifty.ne.jp>
References:	<20170324182610 DOT 8B2F9440070 AT conbox-039 DOT nifty DOT com> <20170325094638 DOT 5209c67a5efef02f51a99e75 AT nifty DOT ne DOT jp>
Mime-Version:	1.0
X-IsSubscribed:	yes

--Multipart=_Tue__28_Mar_2017_20_52_31_+0900_lXa4DmmFKKQd3G0j
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 25 Mar 2017 09:46:38 +0900 Takashi Yano wrote:
> from ctypes import pythonapi
> key = pythonapi.PyThread_create_key()
> res1 = pythonapi.PyThread_set_key_value(key, 5555)
> res2 = pythonapi.PyThread_get_key_value(key)
> res3 = pythonapi.PyThread_delete_key(key)
> print(key,res1,res2,res3)

There was one mistake. The function type of PyThread_delete_key() is
void, so the return value is meaningless (just a garbage).

Moreover, the script works as expected if modified as follows.

--- from here ---
from ctypes import *
pythonapi.PyThread_create_key.restype = c_long
pythonapi.PyThread_set_key_value.argtypes = [c_long, c_void_p]
pythonapi.PyThread_get_key_value.restype = c_void_p
pythonapi.PyThread_get_key_value.argtypes = [c_long]
key = pythonapi.PyThread_create_key()
res1 = pythonapi.PyThread_set_key_value(key, 5555)
res2 = pythonapi.PyThread_get_key_value(key)
print(key,res1,res2)
--- to here ---

This is because 3.6-thread-cygwin64.patch is changing the type of
functions as the key type is changed from int to long.

However, from the portability point of view, it is not desirable to
change the types of functions exported as APIs.

If one of the idea of the patches I proposed will be employed, the
patch 3.6-thread-cygwin64.patch is not necessary anymore.

Thus, I would like to propose new version of the patches replacing
3.6-thread-cygwin64.patch.

3.6-thread-cygwin-replacement-1.patch:
  replaces 3.6-thread-cygwin64.patch and pthread-cygwin-1.patch

3.6-thread-cygwin-replacement-2.patch:
  replaces 3.6-thread-cygwin64.patch and pthread-cygwin-2.patch

I would appreciate your comment.

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

--Multipart=_Tue__28_Mar_2017_20_52_31_+0900_lXa4DmmFKKQd3G0j
Content-Type: application/octet-stream;
 name="3.6-thread-cygwin-replacement-1.patch"
Content-Disposition: attachment;
 filename="3.6-thread-cygwin-replacement-1.patch"
Content-Transfer-Encoding: base64

LS0tIG9yaWdzcmMvUHl0aG9uLTMuNi4xL1B5dGhvbi90aHJlYWRfcHRocmVh
ZC5oCTIwMTctMDMtMjUgMDg6MTA6MzAuNzg0NjAxODAwICswOTAwCisrKyBz
cmMvUHl0aG9uLTMuNi4xL1B5dGhvbi90aHJlYWRfcHRocmVhZC5oCTIwMTct
MDMtMjUgMDg6NDM6MTIuMDcwOTA2OTAwICswOTAwCkBAIC02MDMsNiArNjAz
LDY0IEBACiAKICNkZWZpbmUgUHlfSEFWRV9OQVRJVkVfVExTCiAKKyNpZmRl
ZiBfX0NZR1dJTl9fCisvKiBDeWd3aW4gcHRocmVhZCBUTFMga2V5IHR5cGUg
aXMgYSBwb2ludGVyLCB3aGVyZWFzIFB5dGhvbiAzIGFzc3VtZXMKKyAqIGlu
dCB0eXBlLiBTbyB3cmFwcGVyIGZ1bmN0aW9ucyBhcmUgdXNlZCBpbnN0ZWFk
LgorICovCitzdGF0aWMgdW5zaWduZWQgbG9uZyBrZXliYXNlID0gVUxPTkdf
TUFYOworCitzdGF0aWMgaW50CitweV9wdGhyZWFkX2tleV9jcmVhdGUodW5z
aWduZWQgaW50ICprZXksIHZvaWQoKmZ1bmMpKHZvaWQgKikpCit7CisgICAg
aW50IHJldDsKKyAgICBjb25zdCB1bnNpZ25lZCBsb25nIG1hc2sgPSBVTE9O
R19NQVggJiB+KHVuc2lnbmVkIGxvbmcpSU5UX01BWDsKKyAgICB1bnNpZ25l
ZCBsb25nIGtleWJhc2VfbmV3OworICAgIHB0aHJlYWRfa2V5X3Qga2V5X2N5
ZzsKKyAgICByZXQgPSBwdGhyZWFkX2tleV9jcmVhdGUoJmtleV9jeWcsIGZ1
bmMpOworICAgIGlmIChyZXQpIHsKKyAgICAgICAgLyogRXJyb3IgKi8KKyAg
ICAgICAgcmV0dXJuIHJldDsKKyAgICB9CisgICAga2V5YmFzZV9uZXcgPSAo
dW5zaWduZWQgbG9uZylrZXlfY3lnICYgbWFzazsKKyAgICAvKiBJZiBiYXNl
IGFkZHJlc3MgaXMgZGlmZmVyZW50LCB0cmVhdCBhcyBlcnJvciAqLworICAg
IGlmIChrZXliYXNlICE9IFVMT05HX01BWCAmJiBrZXliYXNlX25ldyAhPSBr
ZXliYXNlKSB7CisgICAgICAgIHB0aHJlYWRfa2V5X2RlbGV0ZShrZXlfY3ln
KTsKKyAgICAgICAgcmV0dXJuIEVOT01FTTsKKyAgICB9CisgICAga2V5YmFz
ZSA9IGtleWJhc2VfbmV3OworICAgICprZXkgPSAodW5zaWduZWQgaW50KSgo
dW5zaWduZWQgbG9uZylrZXlfY3lnICYgfm1hc2spOworICAgIHJldHVybiAw
OworfQorCitzdGF0aWMgaW50CitweV9wdGhyZWFkX2tleV9kZWxldGUodW5z
aWduZWQgaW50IGtleSkKK3sKKyAgICBwdGhyZWFkX2tleV90IGtleV9jeWcg
PSAocHRocmVhZF9rZXlfdCkoa2V5YmFzZSB8IGtleSk7CisgICAgcmV0dXJu
IHB0aHJlYWRfa2V5X2RlbGV0ZShrZXlfY3lnKTsKK30KKworc3RhdGljIGlu
dAorcHlfcHRocmVhZF9zZXRzcGVjaWZpYyh1bnNpZ25lZCBpbnQga2V5LCBj
b25zdCB2b2lkICpwKQoreworICAgIHB0aHJlYWRfa2V5X3Qga2V5X2N5ZyA9
IChwdGhyZWFkX2tleV90KShrZXliYXNlIHwga2V5KTsKKyAgICByZXR1cm4g
cHRocmVhZF9zZXRzcGVjaWZpYyhrZXlfY3lnLCBwKTsKK30KKworc3RhdGlj
IHZvaWQgKgorcHlfcHRocmVhZF9nZXRzcGVjaWZpYyh1bnNpZ25lZCBpbnQg
a2V5KQoreworICAgIHB0aHJlYWRfa2V5X3Qga2V5X2N5ZyA9IChwdGhyZWFk
X2tleV90KShrZXliYXNlIHwga2V5KTsKKyAgICByZXR1cm4gcHRocmVhZF9n
ZXRzcGVjaWZpYyhrZXlfY3lnKTsKK30KKworI2RlZmluZSBwdGhyZWFkX2tl
eV90IHVuc2lnbmVkIGludAorI2RlZmluZSBwdGhyZWFkX2tleV9jcmVhdGUg
cHlfcHRocmVhZF9rZXlfY3JlYXRlCisjZGVmaW5lIHB0aHJlYWRfa2V5X2Rl
bGV0ZSBweV9wdGhyZWFkX2tleV9kZWxldGUKKyNkZWZpbmUgcHRocmVhZF9z
ZXRzcGVjaWZpYyBweV9wdGhyZWFkX3NldHNwZWNpZmljCisjZGVmaW5lIHB0
aHJlYWRfZ2V0c3BlY2lmaWMgcHlfcHRocmVhZF9nZXRzcGVjaWZpYworCisj
ZW5kaWYgLyogX19DWUdXSU5fXyAqLworCiBpbnQKIFB5VGhyZWFkX2NyZWF0
ZV9rZXkodm9pZCkKIHsKCg==

--Multipart=_Tue__28_Mar_2017_20_52_31_+0900_lXa4DmmFKKQd3G0j
Content-Type: application/octet-stream;
 name="3.6-thread-cygwin-replacement-2.patch"
Content-Disposition: attachment;
 filename="3.6-thread-cygwin-replacement-2.patch"
Content-Transfer-Encoding: base64

LS0tIG9yaWdzcmMvUHl0aG9uLTMuNi4xL1B5dGhvbi90aHJlYWRfcHRocmVh
ZC5oCTIwMTctMDMtMjUgMDg6MTA6MzAuNzg0NjAxODAwICswOTAwCisrKyBz
cmMvUHl0aG9uLTMuNi4xL1B5dGhvbi90aHJlYWRfcHRocmVhZC5oCTIwMTct
MDMtMjUgMDg6NDQ6MjEuOTQ2NTk2NjAwICswOTAwCkBAIC02MDMsNiArNjAz
LDc0IEBACiAKICNkZWZpbmUgUHlfSEFWRV9OQVRJVkVfVExTCiAKKyNpZmRl
ZiBfX0NZR1dJTl9fCisvKiBDeWd3aW4gcHRocmVhZCBUTFMga2V5IHR5cGUg
aXMgYSBwb2ludGVyLCB3aGVyZWFzIFB5dGhvbiAzIGFzc3VtZXMKKyAqIGlu
dCB0eXBlLiBTbyB3cmFwcGVyIGZ1bmN0aW9ucyBhcmUgdXNlZCBpbnN0ZWFk
LgorICovCitzdGF0aWMgcHRocmVhZF9rZXlfdCBrZXlfdGJsW1BUSFJFQURf
S0VZU19NQVhdOworCitzdGF0aWMgaW50CitweV9wdGhyZWFkX2tleV9jcmVh
dGUodW5zaWduZWQgaW50ICprZXksIHZvaWQoKmZ1bmMpKHZvaWQgKikpCit7
CisgICAgaW50IHJldDsKKyAgICBpbnQgaTsKKyAgICBwdGhyZWFkX2tleV90
IGtleV9jeWc7CisgICAgcmV0ID0gcHRocmVhZF9rZXlfY3JlYXRlKCZrZXlf
Y3lnLCBmdW5jKTsKKyAgICBpZiAocmV0KSB7CisgICAgICAgIC8qIEVycm9y
ICovCisgICAgICAgIHJldHVybiByZXQ7CisgICAgfQorICAgIGZvciAoaT0w
OyBpPFBUSFJFQURfS0VZU19NQVg7IGkrKykgeworICAgICAgICBpZiAoa2V5
X3RibFtpXSA9PSBOVUxMKSB7CisgICAgICAgICAgICAvKiBTdWNjZWVkZWQg
Ki8KKyAgICAgICAgICAgIGtleV90YmxbaV0gPSBrZXlfY3lnOworICAgICAg
ICAgICAgKmtleSA9IGk7CisgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAg
ICAgfQorICAgIH0KKyAgICBwdGhyZWFkX2tleV9kZWxldGUoa2V5X2N5Zyk7
CisgICAgLyogUFRIUkVBRF9LRVlTX01BWCByZWFjaGVkICovCisgICAgcmV0
dXJuIEVBR0FJTjsKK30KKworc3RhdGljIGludAorcHlfcHRocmVhZF9rZXlf
ZGVsZXRlKHVuc2lnbmVkIGludCBrZXkpCit7CisgICAgaW50IHJldDsKKyAg
ICBpZiAoa2V5ID49IFBUSFJFQURfS0VZU19NQVggfHwga2V5X3RibFtrZXld
ID09IE5VTEwpIHsKKyAgICAgICAgcmV0dXJuIEVJTlZBTDsKKyAgICB9Cisg
ICAgcmV0ID0gcHRocmVhZF9rZXlfZGVsZXRlKGtleV90Ymxba2V5XSk7Cisg
ICAga2V5X3RibFtrZXldID0gTlVMTDsKKyAgICByZXR1cm4gcmV0OworfQor
CitzdGF0aWMgaW50CitweV9wdGhyZWFkX3NldHNwZWNpZmljKHVuc2lnbmVk
IGludCBrZXksIGNvbnN0IHZvaWQgKnApCit7CisgICAgaWYgKGtleSA+PSBQ
VEhSRUFEX0tFWVNfTUFYIHx8IGtleV90Ymxba2V5XSA9PSBOVUxMKSB7Cisg
ICAgICAgIHJldHVybiBFSU5WQUw7CisgICAgfQorICAgIHJldHVybiBwdGhy
ZWFkX3NldHNwZWNpZmljKGtleV90Ymxba2V5XSwgcCk7Cit9CisKK3N0YXRp
YyB2b2lkICoKK3B5X3B0aHJlYWRfZ2V0c3BlY2lmaWModW5zaWduZWQgaW50
IGtleSkKK3sKKyAgICBpZiAoa2V5ID49IFBUSFJFQURfS0VZU19NQVggfHwg
a2V5X3RibFtrZXldID09IE5VTEwpIHsKKyAgICAgICAgcmV0dXJuIE5VTEw7
CisgICAgfQorICAgIHJldHVybiBwdGhyZWFkX2dldHNwZWNpZmljKGtleV90
Ymxba2V5XSk7Cit9CisKKyNkZWZpbmUgcHRocmVhZF9rZXlfdCB1bnNpZ25l
ZCBpbnQKKyNkZWZpbmUgcHRocmVhZF9rZXlfY3JlYXRlIHB5X3B0aHJlYWRf
a2V5X2NyZWF0ZQorI2RlZmluZSBwdGhyZWFkX2tleV9kZWxldGUgcHlfcHRo
cmVhZF9rZXlfZGVsZXRlCisjZGVmaW5lIHB0aHJlYWRfc2V0c3BlY2lmaWMg
cHlfcHRocmVhZF9zZXRzcGVjaWZpYworI2RlZmluZSBwdGhyZWFkX2dldHNw
ZWNpZmljIHB5X3B0aHJlYWRfZ2V0c3BlY2lmaWMKKworI2VuZGlmIC8qIF9f
Q1lHV0lOX18gKi8KKwogaW50CiBQeVRocmVhZF9jcmVhdGVfa2V5KHZvaWQp
CiB7Cgo=


--Multipart=_Tue__28_Mar_2017_20_52_31_+0900_lXa4DmmFKKQd3G0j
Content-Type: text/plain; charset=us-ascii


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--Multipart=_Tue__28_Mar_2017_20_52_31_+0900_lXa4DmmFKKQd3G0j--

- Raw text -