X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=WOFdbxVjHllKCYef
	Mf7rNgdlZQWu8JFKy4En3q8zFzAhq8xuggiPupy2q+bVqWaoSvp/eISSAG5HSP5K
	S5y8ScuLNH/gpXZOSTzM90IOki3/ZMx8XXACRAbY/mUOJ0KKS+qVA229vkdwOaiJ
	E4w4YWWt3fvkGgs6zX/bm4F+E40=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=SQTjW3kAJYmEuXDd1RtJ7i
	C6yoI=; b=E36LKkf/5isvi8HdpBV3JQKvHQaVixJsH4ufHIw9YvHzdXmNQYxckK
	UjAI/iaEbONhnwdB8zVCqfE53jiEnKZJhBTJzY4ScrYkEUkmHwpLMo3dWctHFTUS
	2tHDDPNAoFOnhMUoVMcow5tTqt/W4Oa1LFWcAj4Y/t13yfmoI6J9g=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:220-245, H*r:sk:220-245, H*RU:sk:220-245, hitches
X-HELO:	mail16.tpgi.com.au
X-TPG-Junk-Status:	Message not scanned
X-TPG-Abuse:	host=220-245-251-204.static.tpgi.com.au; ip=220.245.251.204; date=Thu, 19 Jan 2017 22:26:45 +1100
Subject:	Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)
To:	cygwin AT cygwin DOT com
References:	<84a7692e-041a-8b99-2ea9-fb1c784fc01c AT shaddybaddah DOT name> <20170119103840 DOT GD13008 AT calimero DOT vinschen DOT de>
From:	Shaddy Baddah <lithium-cygwin AT shaddybaddah DOT name>
Message-ID:	<2cb5cd97-a711-8d11-c07a-2534ee67298b@shaddybaddah.name>
Date:	Thu, 19 Jan 2017 22:26:42 +1100
User-Agent:	Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.6.0
MIME-Version:	1.0
In-Reply-To:	<20170119103840.GD13008@calimero.vinschen.de>
X-IsSubscribed:	yes

Hi,

On 19/01/17 21:38, Corinna Vinschen wrote:
> On Jan 18 14:34, Shaddy Baddah wrote:
...

>> And I'm sure the problem is that this well-intended change to the script
>> fails on the assumption that LOGONSERVER is always populated. It isn't
>> for me on Vista.
>>
>> cygwin-service-installation-helper.sh:2884:      # This test succeeds on
>> domain member machines only, not on DCs.
>> cygwin-service-installation-helper.sh:2885:      if [
>> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
>> cygwin-service-installation-helper.sh:2886:        -a "${LOGONSERVER}" !=
>> "\\\\MicrosoftAccount" ]
>> cygwin-service-installation-helper.sh:2887:      then
>> cygwin-service-installation-helper.sh:2888:     # Lowercase of USERDOMAIN
>> cygwin-service-installation-helper.sh:2889:
>> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
>> cygwin-service-installation-helper.sh:2890:      fi
>> cygwin-service-installation-helper.sh:2891:    fi
>>
>> I fixed this by modifying the test to check LOGONSERVER is not empty:
>>
>> if [ -n "${LOGONSERVER}" -a "\\\\...
>>
>> Can this be fixed in the next release?
>
> Sure, please provide a patch, I'll check it in and release a new csih
> soonish.

I would, but there's a couple of hitches. Without understanding the
syntax (and I should bring up the bash man page here, I will do after
this), I can't be sure that the following test:

"\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}"

wasn't designed to handled an empty LOGONSERVER variable. Though it
looks to me that it is a binary test (i.e. handling both variables being
empty).

And secondly, I am not sure that chucking in the -n "${LOGONSERVER}"
test is safe in a Vista domain environment. From the comment about the
line, it seems like the original author of those lines, whomever that
may be, might have a strong understanding to make the modification.

But that's not constructive on my part. I'll come up with a patch in the
next 24 hours (it is late where I am now).

-- 
Regards,
Shaddy


>
>
> Thanks,
> Corinna
>


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -