X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=YAcCdpC1dNRiKxlvZ/WwfVat9BvuGFvH2t2eR7Sumk1RMMOt651b6
	YWaChXTyxY5mlXZIo8LzXRsbpPky3eZia4Oz1CvrfRZcB2POZozZkS4dbqEyGVxU
	kpP+q31EqyF65AlMMgg5ByTqJD3tFh/s9vPYQZhdelGREktaiBotKE=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=Q7T8Yorx4ug6OH7LnUN04DHOpow=; b=HFp65azcv5CcsrprwitoDg0JsWvd
	tmJoFweTlmElMTBZ0JEqFFnPtdgSWMiLbVUKVTPQwztuhBvc2YaUMJZ1J/rswH0K
	GXgbQg8h+9zQFCeAZm9ZhR0CpUZ5hU1S0KNxdt86wmooXlw4qih7WKN6gt6kTyBl
	5Ua/uDHyfDwft1o=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-101.6 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Baddah, baddah, H*MI:sk:84a7692, H*f:sk:84a7692
X-HELO:	drew.franken.de
Date:	Thu, 19 Jan 2017 11:38:40 +0100
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)
Message-ID:	<20170119103840.GD13008@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<84a7692e-041a-8b99-2ea9-fb1c784fc01c AT shaddybaddah DOT name>
MIME-Version:	1.0
In-Reply-To:	<84a7692e-041a-8b99-2ea9-fb1c784fc01c@shaddybaddah.name>
User-Agent:	Mutt/1.7.1 (2016-10-04)

--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan 18 14:34, Shaddy Baddah wrote:
> Hi,
>=20
> First please find attached a simple patch that fixes a problem I
> encountered running ssh-host-config with the --debug option.

Thanks, applied.

> And I'm sure the problem is that this well-intended change to the script
> fails on the assumption that LOGONSERVER is always populated. It isn't
> for me on Vista.
>=20
> cygwin-service-installation-helper.sh:2884:      # This test succeeds on
> domain member machines only, not on DCs.
> cygwin-service-installation-helper.sh:2885:      if [
> "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" \
> cygwin-service-installation-helper.sh:2886:        -a "${LOGONSERVER}" !=
=3D
> "\\\\MicrosoftAccount" ]
> cygwin-service-installation-helper.sh:2887:      then
> cygwin-service-installation-helper.sh:2888:     # Lowercase of USERDOMAIN
> cygwin-service-installation-helper.sh:2889:
> csih_PRIVILEGED_USERNAME=3D"${COMPUTERNAME,,*}+${username}"
> cygwin-service-installation-helper.sh:2890:      fi
> cygwin-service-installation-helper.sh:2891:    fi
>=20
> I fixed this by modifying the test to check LOGONSERVER is not empty:
>=20
> if [ -n "${LOGONSERVER}" -a "\\\\...
>=20
> Can this be fixed in the next release?

Sure, please provide a patch, I'll check it in and release a new csih
soonish.


Thanks,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--BOKacYhQ+x31HxR3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJYgJcwAAoJEPU2Bp2uRE+gBX4P+wU2LG4wbaWHSd+bH1mv9qjq
PNEBsEqCA87OlhBUfQ61aVa9LCqeLqaC6CtMHX0W72BJeCS5EHoNYNma0qTULww0
fQAwVSPIQ5O5KqMkk8W1yNlPQtb0Jl9PFmdLByT7s10l/ocVQKTsHjb1VmTzf+8v
vkuDZXbg/XAfHUtYuEgQhFSs83D75R3GYiVpSUZrrjx8JmOTa8iVzcfEFuHxdtfF
No7NB9X/8tpatyUXlGE6kBVOG3OEmCY0a9o1KsebgBKaW8ynQwcpuToHMaWA0/+B
RQfnFl6juU4ZUe+q+GmbhsH1WrMID8b3RmFyaed6u4Q2i995TOuxTO5Oseh9XioT
/ZKobbE1mDVGPjao/viVIZq0Y/9HE2hYXFUbBU7fVduvIbxaqwJTE3YRc3XvWwzd
HvXUr5+OfHM7TJN5BLO9djiG5ZYkmgoR8NLHJD7RFw7jp8RlO4lKX9YDbbxe8AeT
h2bpBPTXpw/76aEHXqH9CzVG5lyQZZMrP/Hzxk8e3VjcAtMa8z6XQYWRoMBy+tDZ
GFgld9gQXP7qJD8M1wE/B91mfh4ml/tFjonmGz3tudNatEWjhGXMsnTa3hi9aB/G
pl87jituBv/38adPZVAXzs1H7OsSraR3sAstO4+XzeWNfAXP2dU3Qd5PGI3JrrIP
JJwPLsaCrFgV1CZYDPef
=slw2
-----END PGP SIGNATURE-----

--BOKacYhQ+x31HxR3--

- Raw text -