delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2016/07/28/15:57:33

X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
:list-unsubscribe:list-subscribe:list-archive:list-post
:list-help:sender:date:from:to:subject:message-id:reply-to
:references:mime-version:content-type:in-reply-to; q=dns; s=
default; b=GWhGA+F05lY/oHzEhsuQ1fbKdXJTUdQicQSw3q+bUKrPV/pr6mKzO
iZheB2/R4E95Ds6HFfCD0jKSiaH3/f3ko/jkiWwdtFW8GXmemGVD7iP+uq5BGOIT
6xUUvobB2ww88Dh4UDwbRFKN0A4gPRdaAJhQOY5AXIHEH+nASM8UYM=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
:list-unsubscribe:list-subscribe:list-archive:list-post
:list-help:sender:date:from:to:subject:message-id:reply-to
:references:mime-version:content-type:in-reply-to; s=default;
bh=QVx+SyzG5BqO+28fMxHxCZpbYeA=; b=eiVF4/cVZjchbAToF+c9RV1x82AE
I+TxfUNa5qY5b0aXAWoUawbqMbCY6P4J+z3FCCV8ku9Ghx4J1JZX7Glw3/TmJYac
dRYd/XNxEtS/zrzdhHXjaxogMTop9fnEBM1Spi4mjo7e/OR/aRqKkZd2HmdGVk37
7eo5Lwu8o+NOqqs=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-95.0 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_BRBL_LASTEXT,RCVD_IN_PBL,RCVD_IN_SORBS_DUL,RDNS_DYNAMIC autolearn=ham version=3.3.2 spammy=H*i:sk:9ce2e1f, 7226, H*f:sk:9ce2e1f, H*MI:sk:9ce2e1f
X-HELO: calimero.vinschen.de
Date: Thu, 28 Jul 2016 21:56:58 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.3
Message-ID: <20160728195658.GD26311@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <announce DOT 20160727123645 DOT GA15051 AT calimero DOT vinschen DOT de> <bd8a8318-7318-966a-646b-8f4cf9bed1d7 AT cornell DOT edu> <20160727203350 DOT GB29214 AT calimero DOT vinschen DOT de> <9ce2e1fc-5bb5-923e-3c86-9331f33a5bb7 AT cornell DOT edu>
MIME-Version: 1.0
In-Reply-To: <9ce2e1fc-5bb5-923e-3c86-9331f33a5bb7@cornell.edu>
User-Agent: Mutt/1.6.2 (2016-07-01)

--NklN7DEeGtkPCoo3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul 28 15:44, Ken Brown wrote:
> On 7/27/2016 4:33 PM, Corinna Vinschen wrote:
> > On Jul 27 10:58, Ken Brown wrote:
> >> On 7/27/2016 8:36 AM, Corinna Vinschen wrote:
> >>> Hi Cygwin developers and maintainers,
> >>> Hi everyone else,
> >>>
> >>>
> >>> I uploaded a new Cygwin test release 2.6.0-0.3.
> >>>
> >>> Supposed to fix the problems reported in
> >>> https://cygwin.com/ml/cygwin/2016-07/msg00306.html
> >>
> >> This is now fixed.  Here's another problem, with a very easy test case:
> >>
> >> $ locale -a
> >> Segmentation fault (core dumped)
> >=20
> > Confirmed.  I missed to set a variable in case of the "th_TH.TIS-620"
> > locale or the "thai" locale alias.  I'll build a 0.4 tomorrow.
>=20
> This is fixed in 0.4, and that's the last of the regressions that I've
> found by running the emacs test suite.
>=20
> I built and tested texlive with no problem.
>=20
> I also tried to build icu, but there are some glitches due to the new
> POSIX guard in /usr/include/locale.h.  For example: [...]
>=20
> The errors go away if I move the prototypes of setlocale and
> localeconv outside of the new POSIX guard.

Ouch, right, they don't belong there.  What was I thinking?

Proposing this patch, can you give it a quick test?

diff --git a/newlib/libc/include/locale.h b/newlib/libc/include/locale.h
index f74e9c5..6b3b788 100644
--- a/newlib/libc/include/locale.h
+++ b/newlib/libc/include/locale.h
@@ -72,26 +72,26 @@ char *_EXFUN(_setlocale_r,(struct _reent *, int, const =
char *));
 struct lconv *_EXFUN(_localeconv_r,(struct _reent *));
=20
 #if __POSIX_VISIBLE >=3D 200809
-
 locale_t _newlocale_r (struct _reent *, int, const char *, locale_t);
 void _freelocale_r (struct _reent *, locale_t);
 locale_t _duplocale_r (struct _reent *, locale_t);
 locale_t _uselocale_r (struct _reent *, locale_t);
+#endif /* __POSIX_VISIBLE >=3D 200809 */
=20
 #ifndef _REENT_ONLY
=20
 char *_EXFUN(setlocale,(int, const char *));
 struct lconv *_EXFUN(localeconv,(void));
=20
+#if __POSIX_VISIBLE >=3D 200809
 locale_t newlocale (int, const char *, locale_t);
 void freelocale (locale_t);
 locale_t duplocale (locale_t);
 locale_t uselocale (locale_t);
+#endif /* __POSIX_VISIBLE >=3D 200809 */
=20
 #endif /* _REENT_ONLY */
=20
-#endif /* __POSIX_VISIBLE >=3D 200809 */
-
 _END_STD_C
=20
 #endif /* _LOCALE_H_ */


Thanks (A LOT),
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--NklN7DEeGtkPCoo3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXmmOKAAoJEPU2Bp2uRE+gfJoP/1WpD28JsHD9x8B2DPJWFdN8
/9EJgOD454YStA6mNkA6grJXX7aKIYECuibnB9WvbyVKXXcW3QRKYqQlMgeWJL4f
+DKpsLHAXQXMT4VoBuGTiOOS39hkKpbeHD7NmV7l6Dzpa8rwTVB0Nhv8lLxUKsMk
OPtUJpi0Vbt1zpmaF7DniIgLOGmAP7mrWgZXD73AqwIwXdSfoFE9uKP2SHYUj6D4
z0tJKxSJiGXOkcgKpHlV409BcUKKI2bKsAe4LzT7QOk/Ff9/MqMOZZRXb6k55vTP
J5sPNuv8YD0BYT+ZpegMpRgdkW4oElDY1lF8LY6yQCyfDRnZhN8Eopg2UmSZ9FvD
clsZqCvZ3/dg86VToXyeiw5PNSYVSLaunmoVF7KRnSyP6+y2LW7M41oeAXphmpe+
QdFn+/YaMfe4of/AyI0CPVvNg6J+VAFxUXRLyKb9JRwI3R6g5DWZyRSkT8/Y3yS+
efy3/n28NZ8PLlil36h+JA0VSLDaLxEFxydDtyTJZ1ZACi2Uqml/eTHrInfmCW6r
/qcgXbdJTgB7+nsaEZRAjEWHOvJYAYtZjNQlM7GN61EEqjjHvilJWWq7p2U8Kba4
msTbYOZhtOquKpUElF78P8b+Wi9fCgb0GucvH7GvGUudmvSuyD9BqbFijm04kh19
w5bR1gs3nz9UiwHYokG5
=c+CY
-----END PGP SIGNATURE-----

--NklN7DEeGtkPCoo3--

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019