X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:content-type
	:content-transfer-encoding:date:from:to:subject:in-reply-to
	:references:message-id; q=dns; s=default; b=l2rImsEbCO+9fW4u6Ub7
	wMnE+6/eS/BQuc2AGmb/8lGBGkq62c7DN1R04C3aKWwJdFdPp8m/bA+L39Y51A90
	EO2EmG8zY4xKiEOmcEmfQwkG1CmVbVFSQwJ+K/LZa4ExqBLRz1KZrF3ifAzLNTZI
	ASG579ReDjS1pubr0NsnUgY=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:content-type
	:content-transfer-encoding:date:from:to:subject:in-reply-to
	:references:message-id; s=default; bh=2Yx+HYPCOA6jdlM+tGQJXwGFjc
	8=; b=skDFMFK1hNgM/sZ7+t57GmaT3WSLIejcpqrk2tQqgzlMj7bo7qtp9zAxYy
	fav2NEV4DcndUZ9ZRjwQKphW3pIUrCfNlCYU8LQgLuaVaugxFmLe7aylIKIONZyL
	g/uyReDr76GDCSEPXbwSGYsvvBzq09K4McVwPObEhqQOKLits=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=2.1 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW,SPAM_SUBJECT1,SPF_PASS autolearn=no version=3.3.2 spammy=ci, oops, pga, PGA
X-HELO:	lb2-smtp-cloud6.xs4all.net
MIME-Version:	1.0
Date:	Wed, 23 Mar 2016 17:21:52 +0100
From:	Houder <houder AT xs4all DOT nl>
To:	cygwin AT cygwin DOT com
Subject:	Re: Package choosing algorithm ...
In-Reply-To:	<20160322095250.GK7179@calimero.vinschen.de>
References:	<bf41d85cb0aa96624fd4383778eb1287 AT xs4all DOT nl> <20160321100007 DOT GK3422 AT calimero DOT vinschen DOT de> <1a2fa4d86b78fbf1ccf8bc9a690e82e5 AT xs4all DOT nl> <20160322095250 DOT GK7179 AT calimero DOT vinschen DOT de>
Message-ID:	<45b98316e3603593a6c9b10e37745cb3@xs4all.nl>
X-Sender:	houder AT xs4all DOT nl (4LNTF7+wAm/ny2awr97/0g==)
User-Agent:	XS4ALL Webmail
X-IsSubscribed:	yes

On 2016-03-22 10:52, Corinna Vinschen wrote:
> On Mar 21 13:40, Houder wrote:

[snip]

>> Apparently specifying the -m option makes a difference ...
> 
> It shouldn't but apparently it does, oh well.
> 
> https://cygwin.com/acronyms#PGA anybody?

Hi Corinna,

More experimenting ... including building and testing setup.exe

All the time using "Install from Local Directory" ...

  - copied cygwin-2.5.0-0.8.tar.xz to cygwin-2.5.0-0.9.tar.xz
  - modified setup.ini
cygwin: substituted 0.9 for TEST

  - using my test version of setup.exe, I found out that the current 
version of
    the cygwin tarball (setup.ini) HAD to be in my repo ... or else setup 
would
    not offer the new test version for install ...
  - I modified package_meta.h accordingly - see below
    (my new test version is offered for install after the modification)
  - next I downloaded the current version of the cygwin tarball and moved
    the file to appropriate place in my repo.
    Using the official version of setup, I verified that my test version 
is now
    offered for install.

Please, keep in mind: I am NOT announcing here that I found the bug ... 
Please,
keep that in mind (inexperienced C++ developer and all that).

I am sure more testing is required ...

Regards,

Henri

======

package_meta.h:

   std::string action_caption () const;
   packageversion trustp (bool _default, trusts const t) const
   {
     /* If the user chose "test" and a "test" version is available, 
return it. */
     if (t == TRUST_TEST && exp)
       return exp;
     /* Are we looking for the default version and does the installed 
version
        have a higher version number than the "curr" package?  This means 
the
        user has installed a "test" version, or built her own version 
newer
        than "curr".  Rather than pulling the user back to "curr", we 
install
        "test" if a "test" version is available and the version number is 
higher,
        or we stick to "installed" if not.  This reflects the behaviour 
of
        `yum update' on Fedora. */
// Henri
//Log (LOG_PLAIN) << "HENRI:" << "\t" << this->name << "\t" << _default 
<< "\t" << prev << curr << exp << "\t" << installed << endLog;
Log (LOG_PLAIN) << "HENRI:" << "\t" << this->name << " " \
         << curr << " " << installed << " cmp(c,i): " << 
packageversion::compareVersions (curr, installed) << " " \
         << installed << " " << exp << " cmp(i,e): " << 
packageversion::compareVersions (installed, exp) << endLog;

// Henri: Oops, current (setup.ini) is NOT present in repo in my case 
...
//    if (_default && curr && installed
     if (_default && installed
         && packageversion::compareVersions (curr, installed) < 0)
       {
         if (exp && packageversion::compareVersions (installed, exp) < 0) 
{
Log (LOG_PLAIN) << "HENRI!" << "\t" << this->name << endLog;
           return exp;
         }
         return installed;
       }
     /* Otherwise, if a "curr" version exists, return "curr". */
     if (curr)
       return curr;
     /* Otherwise return the installed version. */
     return installed;
   }

=====

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -