X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=gOrIEqZX6ArfH+3wswiedXCk3LFAF79OdXzwFWnsR6pyaCAhAgJ7f
	Wg+LtDRMKNK5OKFjbk2ZnrmrGRuBsDw1OWHVIpXdGvKHX+oZ84Kg4mBOELyjug0h
	Uys0la+FBJOQvI+7E+gobo6/Eq4wBM1JNa5aBYNKxOVGKLII8Z3Vn8=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=iZtCVewQaCUvJoEzKkYvB9apNJM=; b=hxxUU+bd/nTX2i2ai8e72nkDz5Vq
	oTV7u/KtXuz/4SQJnYvW+2Vk3WO5bIPprfMZEwHpY6zVQUuJ0CVSl3GdUpzTmub7
	0G0XCd5oDBDdXdu95NCrWXHf7LF35ixeKTiuO7ob1CCXy3UJBGFwsKy9cem1I2cv
	OVrjPlHr0lIAqXk=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-93.9 required=5.0 tests=BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=H*f:sk:02b9665, non-0, potenitally, resets
X-HELO:	calimero.vinschen.de
Date:	Sun, 13 Mar 2016 12:37:02 +0100
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Problem with line buffering and getc function on 1.7.33.
Message-ID:	<20160313113702.GE25791@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<a0c23290b3a8502552dcf149fbfa5f90 AT mail DOT kylheku DOT com> <56E34346 DOT 9010000 AT gmail DOT com> <11ca145175d5b7d15db927c0c1f28b18 AT mail DOT kylheku DOT com> <20160312193946 DOT GB3567 AT calimero DOT vinschen DOT de> <20160312222921 DOT GD3567 AT calimero DOT vinschen DOT de> <02b96659afff45653e40bc7eaeae3495 AT mail DOT kylheku DOT com> <20160313110627 DOT GD25791 AT calimero DOT vinschen DOT de>
MIME-Version:	1.0
In-Reply-To:	<20160313110627.GD25791@calimero.vinschen.de>
User-Agent:	Mutt/1.5.24 (2015-08-30)

--pAwQNkOnpTn9IO2O
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mar 13 12:06, Corinna Vinschen wrote:
> On Mar 12 16:41, Kaz Kylheku wrote:
> > On 12.03.2016 14:29, Corinna Vinschen wrote:
> > >I do now.  Basically it's setvbuf screwing up the internal flags in the
> > >FILE structure.  I took the liberty to update newlib's setvbuf to the
> > >OpenBSD version locally and I'm going to apply my patches to newlib
> > >soon.  I'll provide a new 2.5.0 test release of Cygwin with this patch
> > >tomorrow or early next week.
> >=20
> > The change in git now seems risky; it substantially rewrites setvbuf.
> > Of course, it's not that I think OpenBSD has it wrong, but that it's
> > being cherry-picked in isolation into what looks like a code base
> > with some other old pieces. Just a thought.
>=20
> Point taken.  I compared the code carefully and I'm reasonable sure
> that the risk is low.  The major differences to the old setvbuf are:
>=20
> - The locking call is later.  The first check potenitally exiting
>   the function early does not need any access to either reent or fp.
>=20
> - OpenBSD setvbuf now drops the ungetc buffer.
>=20
> - OpenBSD resets more flags, namely __SOPT | __SNPT | __SEOF.  That's
>   certainly the safer option.
>=20
> - Optimal IO size handling is a bonus.  Just setting buffer to 1K was
>   a bit sub-optimal.
>=20
> - Add missing __sinit() call.
>=20
> - Only set buffersize to non-0 in _IOLBF case if we're already writing.
>=20
> - The rest is equivalent to before.  Only the switch statement has been
>   changed to an if in OpenBSD's setvbuf.
>=20
> Did you try Cygwin 2.0.5-0.6?

s/2.0.5/2.5.0/


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--pAwQNkOnpTn9IO2O
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJW5VDeAAoJEPU2Bp2uRE+gkM4P/igDGC4PoS/8lJCvsGbZXJOK
KZWk6IjAFOEFSgWymTPTqBCYT3+OMHdWx4oy/PzpMfEWqfChYbc7YVtFnubprBCg
yASo5y8slDcA26JxMarsmA+reFXlTXF3amBLxE5U+qBvIGrOStAKK8vtb/e4kYJA
w2pqSgBaC4mJYj9RmFLA+5X+RCh6cwPiu0Gu8bFdniCjxiWvcxIC2HmIqiblQcco
xfiVw7EEGjVVQdCWWBbJ/kJYlY6+SOC7Kgc4cLBbLTVyTBKqA6KrBXfKHJ9xVtZn
tILLo+aeWPlT63K8jZ+PntrUIyfEXUZ4bIwuDJMTWDfUdOwamooHd9felumIEIUu
xUT18/+oGelz8zVrFX0Ej9ZhdrbtfE9ljtOnkWk+w03Cr++1ummnYomWTFz0tG1O
z0KGanyxhfeXEKTdq3xnutP3bWIYiE2zkAwIaAU+Mwo4f9RxOUmtZ3aLgP++D8Pv
T8EjtlOtJoBFJGB31ywoSfM9VKHp2GrxrLxyoVWKi8BhIRkKOtN1GvHm9PnxBA2X
7/hkTiB8HLYNYdzIqQTZ01WavIgLzM0cEki9b+TqYeYydO/j1JkdFtgdhWXRpb+1
C/HubxKvfG45OVsPE60sFi1ACtNJ6lcIch/ZsG0L6GHQA+k95C1GgTTOH87GH6+O
dlfMzqLeYq6J1I3UQ86/
=vGx+
-----END PGP SIGNATURE-----

--pAwQNkOnpTn9IO2O--

- Raw text -