X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	q=dns; s=default; b=E+ONPZe7JJdyWjw6MCZgYtQLLpS/4ecAkmPssE6dBO+
	UtVKYSFuG6eKj2mz+LEky2+VmpCcswcKY6ka4yPDEZiE9Mx5FhyPajjA6x14aoo7
	gO6LF0lUFy+/EVb/Um51fK/MhVGTEbjsablfHhPC2saDBzrnxId4v3INUhGShIqI
	=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	s=default; bh=wRBQBB6HmrSVVytRa+EiSt9Hpjo=; b=X2NXFs/lnQsA6i4w2
	9PKx5edNcRyTcEb0EMSHWXL3z4IKwE+DxwAF1w9Ew1SQiSkmc5jWYWR6I+NyJZWr
	CCRVpK0J5UHyuIpMr/1wKcH/lWdluAh0n9CSgv6Tj6zT7+xzVBfcS3TA+vOYKNk7
	Wn3NTbdRgrIOhyZPSVghWcq4Fs=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:CAFo71_, hacking, H*MI:sk:RVcyoDw, H*i:i57w_eAgeq
X-HELO:	mail.lysator.liu.se
Message-ID:	<56B9A9D8.1030900@lysator.liu.se>
Date:	Tue, 09 Feb 2016 09:56:56 +0100
From:	Peter Rosin <peda AT lysator DOT liu DOT se>
User-Agent:	Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: Problem with new acl code and cdrtools
References:	<CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg AT mail DOT gmail DOT com> <20160208131835 DOT GC12975 AT calimero DOT vinschen DOT de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg AT mail DOT gmail DOT com> <56B8C25F DOT 7050206 AT lysator DOT liu DOT se> <CAFo71_4eQ2VMypAnC=Bx_bvbzGvVCs=jj4r9Ax6GDbgaH1zGOQ AT mail DOT gmail DOT com> <CA0C06F1-A50D-4DBF-AB58-AADCE3D9F9F4 AT etr-usa DOT com> <CAFo71_58PFDgaNU4-bdj4JoCndXAd=+i57w_eAgeq==RVcyoDw AT mail DOT gmail DOT com>
In-Reply-To:	<CAFo71_58PFDgaNU4-bdj4JoCndXAd=+i57w_eAgeq==RVcyoDw@mail.gmail.com>

On 2016-02-09 08:56, Ismail Donmez wrote:
> Hi,
> 
> On Tue, Feb 9, 2016 at 6:14 AM, Warren Young <wyml AT etr-usa DOT com> wrote:
>> On Feb 8, 2016, at 9:59 AM, Ismail Donmez <ismail AT i10z DOT com> wrote:
>>>
>>> On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin <peda AT lysator DOT liu DOT se> wrote:
>>>> On 2016-02-08 14:31, Ismail Donmez wrote:
>>>>> This is a generic code so I don't want to add a cygwin specific
>>>>> dependency there. Is there a preprocessor definition for cygwin
>>>>> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
>>>>
>>>> Pardon me for butting in, but isn't adding a Cygwin version check
>>>> about as non-generic as it gets?
>>>>
>>>> Wouldn't something like this work:
>>>>
>>>> .../configure ac_cv_func_aclfromtext=no
>>>
>>> Thats a hack :)
>>
>> I don’t know if that smiley means you’re joking or if you’re just trying to soften a negative judgement, but Peter’s proposal is as far from a hack as it gets.
> 
> What Peter suggests is telling autoconf to assume aclfromtext() does
> not exist on the system which is a hack and I already have a hack I
> could use.
> 
>> He is proposing that you write an autoconf test that determines if the platform has this new ACL behavior.  Then in your C code:
>>
>>    #include <config.h>
>>    #if HAVE_FUNC_ACLFROMTEXT
>>    #  include <cygwin/acl.h>
>>    #endif
> 
> I could check for __cygwin__ instead of that which would do the same thing.
> 
> Anyhow the discussion diverged a lot, and for now I'll be using my
> simple hack of disabling HAVE_SUN_ACL manually.

My take on the situation was that you could disable SUN ACLs by telling
configure that cdrtools should not use aclfromtext(), and that the code
that backs this was already in place. I.e. that you could get a working
build recipe w/o any hacking/patching of cdrtools at all.

I might be misunderstanding something though, but if it works and if
it is considered more of an hack than introducing a cygwin version
check inside the cdrtools package, then that's not my headache.

Just trying to help...

Cheers,
Peter

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -