X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=pW55FVi
	axBurEXULotHv5YEtBd0wnHxlFJm8si9VFIYr/xStw7buYR27Nmfvfajf49fTfGQ
	TB8nr+m89gFeggr07sP6qKJdxHLQYcw1AbRAMvf9CxCwfqTBpWQnckGjhApdEuDc
	lvVRgkaNpyyWcR4qY1mnYeHvpjPwc5lF++qk=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; s=default; bh=iH+xl9opcWhBf
	WPjsTObbcAiXok=; b=if9vsL54x/4upU/zXgX4/YYy0ypvEjrqYprVsf0qFedqE
	2w2YUWrTxkX/5VxyKACoGA1wqHQHn1M+jK/VOb98Ipb5fRbV2euVGPqfIc4eIubF
	Vatj++hX8MgLlz2mu9REUKPgqlHHrznDYga0gZ7TUeiiKLwLetX9REukeqStU4=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:suFuu-J, H*f:DF9FzH1, Hx-languages-length:2027, H*f:sk:3nVujGH
X-HELO:	mail-wm0-f45.google.com
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=LG4E+OEgWthlNyT4Rjv//hwl4PPexC0bVWGcWDI6RJ8=; b=MS4QUHxauq2pMRpnHrArcVHIz6ibSWxCrV4SKRltJ5eQPAa/ZQ4cI6cJooe2qP2yho xQxuH977yf9d4pQ9VnsdEt3u/x3utlnwsjnm/VrmCQNbY+CeJb7DWTmm35YzWpsRs9M0 deUryr6/dvPbwB84MVIi7jGTF7C9LOaYjVVivYm2Nv/ySLyBSpmT2YJZqx0wu6F+xCTU fetu8Q62lZLbuDnHrDydM1Sm4lkM7blPrG1R1/yGiGgo9rDIp1dhquPGbYC91GIhm7gQ FbT5vEqHJFppJtgmKH8Ks34iCpny2PHTwTwYfDfcmXT1mg7K1/E6IXIcmhoVHbTJkEBh UawA==
X-Gm-Message-State:	AG10YORtFzGiP6GUWCez7HMLNRNhpL6q/ensQGVPzDr0STpFoNGgZvx6VZ7h/nCMBuDx2uTXHenmL/7R/kKqQg==
X-Received:	by 10.194.246.134 with SMTP id xw6mr27740930wjc.158.1454947808534; Mon, 08 Feb 2016 08:10:08 -0800 (PST)
MIME-Version:	1.0
In-Reply-To:	<20160208143630.GG12975@calimero.vinschen.de>
References:	<CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg AT mail DOT gmail DOT com> <20160208131835 DOT GC12975 AT calimero DOT vinschen DOT de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg AT mail DOT gmail DOT com> <20160208141015 DOT GD12975 AT calimero DOT vinschen DOT de> <CAFo71_57DCPp=DF9FzH1=suFuu-J4MAoObC8y=3nVujGHThqJQ AT mail DOT gmail DOT com> <20160208143630 DOT GG12975 AT calimero DOT vinschen DOT de>
From:	Ismail Donmez <ismail AT i10z DOT com>
Date:	Mon, 8 Feb 2016 18:09:38 +0200
Message-ID:	<CAFo71_4Ubx0SJuXXusuJ9neeBF8QcfgGr2pHgW3GCiiG2vDLBA@mail.gmail.com>
Subject:	Re: Problem with new acl code and cdrtools
To:	cygwin AT cygwin DOT com
X-IsSubscribed:	yes

On Mon, Feb 8, 2016 at 4:36 PM, Corinna Vinschen
<corinna-cygwin AT cygwin DOT com> wrote:
> On Feb  8 16:13, Ismail Donmez wrote:
>> On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen
>> <corinna-cygwin AT cygwin DOT com> wrote:
>> > On Feb  8 15:31, Ismail Donmez wrote:
>> >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
>> >> <corinna-cygwin AT cygwin DOT com> wrote:
>> >> > On Feb  8 12:01, Ismail Donmez wrote:
>> >> >> Hi,
>> >> >>
>> >> >> cdrtools has some code to detect Solaris style ACLs:
>> >> >>
>> >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
>> >> >>      defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
>> >> >> #   define  HAVE_SUN_ACL    1 /* Sun UFS ACL's present */
>> >> >> #endif
>> >> >>
>> >> >> Since cygwin still seems to be defining aclfromtext() and acltotext()
>> >> >> functions (which are not defined in POSIX) cdrtools thinks this a
>> >> >> Solaris-style system and get up getting a compile error later on.
>> >> >
>> >> > Probably due to including sys/acl.h.  Does swtiching to cygwin/acl.h
>> >> > help?  Or changing the above check to prefer POSIX ACLs over Solaris
>> >> > ACLs?
>> >>
>> >> This is a generic code so I don't want to add a cygwin specific
>> >> dependency there. Is there a preprocessor definition for cygwin
>> >> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
>> >
>> > If you include cygwin/version.h you could use the version definitions.
>> >
>> > Alternatively we could allow to use the Solaris ACL functions even if
>> > only including sys/acl.h, given some macro:
>> >
>> >   sys/acl.h:
>> >
>> >     #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS
>> >     # include <cygwin/acl.h>
>> >     #else
>> >       [...POSIX definitions...]
>> >     #endif
>> >
>> > Would that help?
>>
>> That should help, I cook a patch and send to cdrecord maintainer.
>
> Wait, that's a bit premature.  I'm not even sure yet if the macro name
> is ok.

I thought the macro already exissts sorry. But, again I would prefer a
__cygwin_version__ macro anyway.

Thanks,
ismail

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -