X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=Tlw+QFc
	qJ+pSOvcd5ZQeLApbN1K5AiIfYwuw1l1LcCa84iey9v0GcGmaa5TyZnZgEW0IbVc
	ugGnZvbCxSYllWvY5jnN1iB0VQlafMHm7EUof94H9XwF5sae6fKGEiYG7K1hmTks
	DzaDdENQ75WtImqDPHCQy36c8XTikyWYWNKs=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; s=default; bh=/EBkWuL232t/J
	FTO+yIt7MfcvqM=; b=hEOIwmoTM+JSydWyl49wtJSZ9TEyjHL7x9ZOYC724gF83
	cBCtGu/jc2L325YV0IZfh8aChoAUmSUBe4c+780palImE++ggEHY76X7WnmKXlUZ
	50Ao30IjkgMea0ug5H59v/ASFty1XfyYGp8m8/pPRBSnBpg1cfn6M9RsRm+tjo=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=cook, sk:__use_o, version.h, versionh
X-HELO:	mail-wm0-f54.google.com
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=4XRPENxAzd8k8I95kgpAUEP3wDMLT9ObBEz2UjGyUFM=; b=FXIQC8xFK4SrpoEs/m9TFkPjzj21xedO9H4RC3MPnbmII9aCgSFd1QEAhZ9yT+5a9h 2N7PajEdpiULx27MlaAxZ4UG6aAE003uPCnPkJR0St1XEBUuOBGJI9mOK/5pw7Woiznt 188F893MbUfAqZiXT0JagS13eRVSaOD8J33WdTnTQHVFrowr/XK0TO6mMrq15y28yUZb 9CjkTX/0eGyqUON78e+AxQnKkdZMqFcCTHjO6CD1l5uLRk+jDOVtC8chyFJ4Zd3xOnra 7dPbhrpfkWyd/jcyW9IgY5lAFCFevSOZ9eVKoGAXNnq1DlWUhC8hYIVkVHtEu9AiMDA9 k6WQ==
X-Gm-Message-State:	AG10YOQxXBq2FAjA/02Llz0tee8u3mxeavujfXpmTyh3fzEENhbBx9aveizEvMlhmFAvqFIt+xPekw//5eHs/g==
X-Received:	by 10.194.192.198 with SMTP id hi6mr28033406wjc.141.1454940840309; Mon, 08 Feb 2016 06:14:00 -0800 (PST)
MIME-Version:	1.0
In-Reply-To:	<20160208141015.GD12975@calimero.vinschen.de>
References:	<CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg AT mail DOT gmail DOT com> <20160208131835 DOT GC12975 AT calimero DOT vinschen DOT de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg AT mail DOT gmail DOT com> <20160208141015 DOT GD12975 AT calimero DOT vinschen DOT de>
From:	Ismail Donmez <ismail AT i10z DOT com>
Date:	Mon, 8 Feb 2016 16:13:30 +0200
Message-ID:	<CAFo71_57DCPp=DF9FzH1=suFuu-J4MAoObC8y=3nVujGHThqJQ@mail.gmail.com>
Subject:	Re: Problem with new acl code and cdrtools
To:	cygwin AT cygwin DOT com
X-IsSubscribed:	yes

On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen
<corinna-cygwin AT cygwin DOT com> wrote:
> On Feb  8 15:31, Ismail Donmez wrote:
>> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
>> <corinna-cygwin AT cygwin DOT com> wrote:
>> > On Feb  8 12:01, Ismail Donmez wrote:
>> >> Hi,
>> >>
>> >> cdrtools has some code to detect Solaris style ACLs:
>> >>
>> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
>> >>      defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
>> >> #   define  HAVE_SUN_ACL    1 /* Sun UFS ACL's present */
>> >> #endif
>> >>
>> >> Since cygwin still seems to be defining aclfromtext() and acltotext()
>> >> functions (which are not defined in POSIX) cdrtools thinks this a
>> >> Solaris-style system and get up getting a compile error later on.
>> >
>> > Probably due to including sys/acl.h.  Does swtiching to cygwin/acl.h
>> > help?  Or changing the above check to prefer POSIX ACLs over Solaris
>> > ACLs?
>>
>> This is a generic code so I don't want to add a cygwin specific
>> dependency there. Is there a preprocessor definition for cygwin
>> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
>
> If you include cygwin/version.h you could use the version definitions.
>
> Alternatively we could allow to use the Solaris ACL functions even if
> only including sys/acl.h, given some macro:
>
>   sys/acl.h:
>
>     #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS
>     # include <cygwin/acl.h>
>     #else
>       [...POSIX definitions...]
>     #endif
>
> Would that help?

That should help, I cook a patch and send to cdrecord maintainer.

Thanks a lot.
ismail

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -