X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=dP9WdvQjjqvOmgyxtjAKsfDB4xmOGhtsPo9+AS3Qq+KSi9w+mU2Vk
	9gWaggr3/xK5oRXDX/wphYgQYwho3JAhOunhmwBNF4AFKtaEGAh9I0qKZKFMDijJ
	OdZq8sY7A7VO1kiNBNtg6R/ta2n5T0kU1WYzu4xddFHDZHa7LQsyHQ=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=9jBvpzua1yBwHbuBo48mgYXimCE=; b=b2kcPASPH7u5S3FIBGySTUTrf4/t
	MRYDp7JUMWjrVgJ/Axrgm51RoxqFmMYqUTIaZ03cmegaQYPxQLe9pmclqqb9/ojP
	ljucduu97jMB48OTlg0j+h/rpcSXuHDPVpSUmNM0S2f33WV7H+e6xzNsTnDyF15H
	BCsmM+dywCXN7zI=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-94.7 required=5.0 tests=BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=H*R:D*cygwin.com, H*R:U*cygwin, H*MI:sk:kJY-wz0, H*f:CAFo71_5
X-HELO:	calimero.vinschen.de
Date:	Mon, 8 Feb 2016 15:10:15 +0100
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Problem with new acl code and cdrtools
Message-ID:	<20160208141015.GD12975@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg AT mail DOT gmail DOT com> <20160208131835 DOT GC12975 AT calimero DOT vinschen DOT de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg AT mail DOT gmail DOT com>
MIME-Version:	1.0
In-Reply-To:	<CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg@mail.gmail.com>
User-Agent:	Mutt/1.5.24 (2015-08-30)

--2iBwrppp/7QCDedR
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb  8 15:31, Ismail Donmez wrote:
> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
> <corinna-cygwin AT cygwin DOT com> wrote:
> > On Feb  8 12:01, Ismail Donmez wrote:
> >> Hi,
> >>
> >> cdrtools has some code to detect Solaris style ACLs:
> >>
> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
> >>      defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
> >> #   define  HAVE_SUN_ACL    1 /* Sun UFS ACL's present */
> >> #endif
> >>
> >> Since cygwin still seems to be defining aclfromtext() and acltotext()
> >> functions (which are not defined in POSIX) cdrtools thinks this a
> >> Solaris-style system and get up getting a compile error later on.
> >
> > Probably due to including sys/acl.h.  Does swtiching to cygwin/acl.h
> > help?  Or changing the above check to prefer POSIX ACLs over Solaris
> > ACLs?
>=20
> This is a generic code so I don't want to add a cygwin specific
> dependency there. Is there a preprocessor definition for cygwin
> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+

If you include cygwin/version.h you could use the version definitions.

Alternatively we could allow to use the Solaris ACL functions even if
only including sys/acl.h, given some macro:

  sys/acl.h:

    #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS
    # include <cygwin/acl.h>
    #else
      [...POSIX definitions...]
    #endif

Would that help?


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--2iBwrppp/7QCDedR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWuKHHAAoJEPU2Bp2uRE+gUkYP/2AH6ym+zdp9qIqe4TaLNGfE
9LRTWbg370dK5TUFS/pABzCzqEJfMsP/TA5ua4XmpOEnj9PWk5bE6tVDoaCCd2dA
xTFjfv6h7XAI+3ynJSMK7zrpR0IU1nIi4aOSXKQT+5TCcPCod+BEOwOLMfWUn7CI
nWVnw/THrSnYjVI8siXVGERsxBDd2dErf9iiCEHxfOkyyKhT0n+4+50fvn/ia8ci
nuzUviIbnAQqqR3GPpnlp5U8ADQjC6F3O5M414pM7OXM7nD3BJ6zksEijuLiYWBa
oIHMmgHnl319PYU8H3qPGwu1zdxp78znYyF7fOjHxdRiZ26YlfxsNqN9dmUy0+DJ
4x3G3QjEMsNS0dKzXjFQ3WqsKaaEGLGoA8MJDyl9rfWV9opVs/0//JwOJhLtLjR0
AstxVNlnqFS9EfiqSzAOrvMpWM38/zjpscikZALGFDbFE2US1DQAz6fPNU0uyk3F
nYu/WT02X22NXfhWEtJTAX2K9UanPKXhjiv9BQj/BWbvUUwgsHKM47v9ETrnrBhg
Y/rEvJGjxmS+GIw302yeef39qKr2G5WuQLilJXCxIlIJO32rqeyFkZwnznpM1Yyv
G0jFoooVSs42DlOQypJSt3Zt5nLdYUA1X724FzY91UdZXMaQc6lGV/8VoKczhrAB
t+n39hz2iuIsrA/ZvcPe
=RkMk
-----END PGP SIGNATURE-----

--2iBwrppp/7QCDedR--

- Raw text -