X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type; q=dns; s=default; b=NO
	5i2PXpKu53Gp7c7OKWKVtnNLfDhDUS1OJ7NkkFZTyKC7ZGs9IFi5KVCwLseSzjGn
	8BzUH544on9nYY2d+AW4F5ZM1PAdGELmZxO43OT1F4hwBcNDgMQRnAeisE4ENLZ/
	rQS5/VP27sXwkJFbLkgE0X1NwGV716TpiIL6WzBwQ=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type; s=default; bh=+saoSJjK
	+FpshogGj77e30zXDTA=; b=mOWw/gPAzSfNV/EUVVPp2HEH4EHZSp6o+0wlzwft
	5lrpPPSu92NGuHd3YX2ohf4F0C/CAus8rfXGH+wAjiUi/ZxdB/CXMyZcz+nCO7jo
	TN17xv9aWBykw01aVbCGQzFFzwr3aDJgilBWv8ZLm+8mYrK189nunaLAPDB72Ur0
	cnY=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-0.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=D*nl, Hx-languages-length:1584, D*xs4all.nl, U*houder
X-HELO:	mail-lb0-f175.google.com
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=0VQ5OrUqYD1Kjh+nSpef/3Q3cP+O46Hc6NDhHqAzcGk=; b=lmVwtndvikA/2kDHz99t8+nCTdWfcBtYpBiDEWepKH8dgQEPPolp6KATs+OQCviihE 8++0yEs7XZp/+SExbloCToLKNesygn/XxQw51TNvEJs9kaVjU7B8OgEcVq1XLLF6FApi /UI42YWQTQ6WtLI6POuxbD5QkX1xHROYIJUdz30DJfuZR2CU/S+NSol3afqUj9+MMJBK ic62Rsrj7+RcWsOYrFIS9kpmI7+eAcsme3Xga1bSDaRgeN0P88WgOZyLHD7Lv8w2yrF5 Z1b1lOwTbFE9sm2WjdNCElJsa6R+pwG72SVMWKVNW2e70byyGY5mJbC3EKw1pMA+kM53 pglA==
X-Gm-Message-State:	AG10YORUGEdJrDDKqQmh2trhe31IQCJqCnIkldNkGmnc0JWR+scSAVFlcsPrZiJtvGQjbOndGZQsjUk1FbtXUg==
MIME-Version:	1.0
X-Received:	by 10.112.209.2 with SMTP id mi2mr6707862lbc.139.1454323514232; Mon, 01 Feb 2016 02:45:14 -0800 (PST)
In-Reply-To:	<loom.20160201T112426-750@post.gmane.org>
References:	<56AC2C35 DOT 9060903 AT cornell DOT edu> <CAO1jNwv+Lza40TnN+woA_R1HpsnEZZvYda2f8A49NE+xvKUCGw AT mail DOT gmail DOT com> <loom DOT 20160201T112426-750 AT post DOT gmane DOT org>
Date:	Mon, 1 Feb 2016 10:45:14 +0000
Message-ID:	<CAOYw7dtaqNYHayMeXupTG10VB3DdWXt10A3EroFuPfJVVN69eA@mail.gmail.com>
Subject:	Re: cygwin_conv_path sometimes removes trailing slash
From:	Ray Donnelly <mingw DOT android AT gmail DOT com>
To:	cygwin AT cygwin DOT com
X-IsSubscribed:	yes

On Mon, Feb 1, 2016 at 10:29 AM, Henri <houder AT xs4all DOT nl> wrote:
> Jan Nijtmans <jan.nijtmans <at> gmail.com> writes:
>
>>
>> 2016-01-30 4:21 GMT+01:00 Ken Brown:
>> > I'm using cygwin_conv_path to convert Win32 paths to POSIX paths, and I'm
>> > puzzled by the conversion
>> >
>> >   d:/ --> /cygdrive/d
>> >
>> > without the trailing slash.  By contrast, we have
>> >
>> >   d:/foo/ --> /cygdrive/d/foo/
>>
>> This came up before:
>>    <https://cygwin.com/ml/cygwin/2015-10/msg00048.html>
>> I had to workaround it in tkimg.
>>
>> It's easy to workaround in your program, but - indeed -
>> that shouldn't be necessary. I too would expect that
>> when the input contains a slash, the output should too.
>>
>> Regards,
>>      Jan Nijtmans
>
> For the record ...
>
>  - Ken Brown refers to: win32 -> posix
>  - Jan Nijthuis and Ray Donnelly refer to: posix -> win32
>
> Different code paths ...
>
> (and yes, conversions in both directions should be correct)

I can't check as I'm at work, but to the best of my knowledge (and yes
I wrote these a long time ago) path_conv::check is used in conversions
both ways so I am talking about both cases here, Jan's with the first
patch and Ken's with the second patch. Please do correct me if I am
wrong though! I will run some detailed tests tonight.

Best regards,

Ray.

>
> Regards,
> Henri
>
>
>
>
>
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -