X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=fatsk2uWZqWsOlPuY+pUIP1IRij7Fp0pq0ApY82Kxp5lr8bETTr1M
	6nMfrINVXre5CfEZTzbR2G4+Hkls0U9iqsiG/Cck/1325+VTkE+DpdG7irtiAt+0
	L3vvjOglItdK3Oj/vduIURyCtrLcALcDwfQeC4bWMlc3G6qxHyXW6E=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=QSovmi63XgUpUG38cBwuD8XW4r0=; b=Auo3GQTTrptQT71rhxGMGySmVFSl
	l4xNXkJO6Myv8exFcEgsPqd+45CRYOpD5zhugcouh8sMeRLm4HhRRXKhIggAdjjV
	IdJeWY2D13TDK4Ef+//68O84o3MBhMSneNLZkt8GE7UK3EKuPtP69D+401Nl9yXQ
	aDehi18fajgr3yU=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-101.9 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_PBL,RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=no version=3.3.2 spammy=corinna, Vinschen, vinschen, Maintainer
X-HELO:	calimero.vinschen.de
Date:	Thu, 7 Jan 2016 15:43:47 +0100
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Issues in utmp/utmpx headers
Message-ID:	<20160107144347.GD20447@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<CALiPeumt3nnNr=6P_p7WUUy1QHk6CBHXpv0i36Y3QanqoN3DbQ AT mail DOT gmail DOT com> <loom DOT 20151227T200026-993 AT post DOT gmane DOT org> <CALiPeun3v+vME=6YU5bgvKp2ENv+csuLLSdKu5Jj0T9x66eQjw AT mail DOT gmail DOT com> <loom DOT 20151229T054517-919 AT post DOT gmane DOT org>
MIME-Version:	1.0
In-Reply-To:	<loom.20151229T054517-919@post.gmane.org>
User-Agent:	Mutt/1.5.24 (2015-08-30)

--NklN7DEeGtkPCoo3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Dec 29 05:16, Brian Inglis wrote:
> > > David Lee <mailtolky <at> gmail.com> writes:
> > >> While trying to port bsdgames to Cygwin I spotted the following issu=
es:
> > >> (1) In /usr/include/utmpx.h, utmpxname() is declared a void function.
> > >> Should it return int?
> > >> (2) In /usr/include/sys/utmp.h, utmpname() is declared a void
> > >> function. Should it return int?
> > >> (3) _PATH_UTMPX is not defined in any system headers.
>=20
> > On 28 December 2015 at 03:02, Brian Inglis
> > <Brian.Inglis <at> systematicsw.ab.ca> wrote:
> > > Search packages for missing files e.g.
> > > https://cygwin.com/cgi-bin2/package-grep.cgi?grep=3Dutmp.h&arch=3Dx86=
_64
> > > brings up package cygwin-devel and cygwin32.
> > > Download and run setup and select cygwin-devel to install the headers=
 and
> > > libraries.
>=20
> David Lee <mailtolky <at> gmail.com> writes:
> > The issue isn't missing, not-installed packages. The issues are (1)
> > some function declaration seem wrong; and (2) a constant is missing.
>=20
> Pardon my reading comprehension bork!=20
>=20
> The utmpname implementation in newlib-cygwin/winsup/cygwin/syscalls.cc
> could probably be improved to: avoid a memory leak; return -1 if=20
> strdup fails, zero otherwise;

This function is supposed to be called only once, so is it worth the
additional effort?

> default the path if a null pointer or string
> argument is passed.=20

The function now returns int and -1 if path is invalid.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--NklN7DEeGtkPCoo3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWjnmjAAoJEPU2Bp2uRE+g/8cP/1x+zyTJ7RsbxSSv6w0eMlEl
UnGlDx/ToALW7gMYRvdANByXqJWgotf49ALj9s3GoE8rjzy9jztCm4XrdeOQ9P08
AQrzMAJM5fxHEhpa3flvV/OYZbHk9uQ2C48zY3zpmtneGYSPMyPNsbR9jFdpxFsH
dt8+Y3v0rnXfj6/pDUdemVcm+pAwZ/AfU/bKd3+z7/KzlBVRJgJ8RlvW9ijknqXd
+ZE5n4BlWpMTyOWJlGrtuTAQZW1elrz/YhBglYrJ1BmHRYxnmYQVREhhWywWXX+e
pVDtmMdFySoDDpsu1+HkfB4Q1IPHytw3+2GsH59ynaguwb+42qHhWfQ5zUrhQcRT
bNB9+tXsBbn9rrL4CRbxuUtPiGXCzY5+waDh6wvMVTy9icD1EMlPrYja3TDk+MwJ
onWK238O/TTVTRS6AgBUsfeeV1sRB+E0j5SJ7F2fzFBBX0WJIEWtzCfMcbsXOCCz
xRYG8fFV7p5+CgbK3TUxB7YmRR/HZjPnltoZ9N9vQOeLnNh4aI3MzPCOa+sK3PJ8
HDTQGzlkWvtCt9UhTMw69SqEGiH9wgDKt7QGb5KYJGYJHFYE+oPQhbwhq97Pn4Zd
zS+p5oDWg7u4F0zIxywyJYkt+Rc5wPzOdsz1hXa9tbLU1ceal3/CQbSU2wo5rUHn
CsaVVeWBDqE3YGcD0Vyc
=VVNG
-----END PGP SIGNATURE-----

--NklN7DEeGtkPCoo3--

- Raw text -