Mail Archives: cygwin/2015/10/29/03:42:15
--SLRDCdsRrCd4mzuj
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Oct 28 17:20, Brian Inglis wrote:
> Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:
> > On Oct 26 19:16, Brian Inglis wrote:
> > > Sorry - redo with the file existing!
> >=20
> > No worries, I applied your other patch since it also cleaned up some
> > whitespaces and, for some reason, the below patch didn't apply cleanly.
>=20
> Email paste may have converted tabs to spaces - need to work out how to
> email inline text attachments without tab expansion in tbird - paste on
> gmane (below) seems to retain tabs - may try that in future.=20
>=20
> > There was just one problem:
> >=20
> > > + {
> > > + long offset; /* offset < 0 =3D> W of GMT, > 0 =3D> E of GMT:
> > > + offset =3D 0; subtract to get UTC */
> >=20
> > This setting the offset to 0 is necessary, but commented out. Typo?
> > I fixed this before committing the patch.
>=20
> Thanks - total brain fart - Doh! Interesting that gcc -Wall -Wextra did n=
ot
> catch this - used to be reliable warning about conditionally uninitialized
> variables!=20
>=20
> Please check that the second set of tests in Vec1 includes the following,=
as
> it was not in my very first patch email, which you may not have received:=
=20
> @@ -1502,6 +1575,7 @@ const struct test Vec1[] =3D {
> { CQ("%p"), 2+1, EXP(CQ("PM")) },
> { CQ("%r"), 11+1, EXP(CQ("11:01:13 PM")) },
> { CQ("%R"), 5+1, EXP(CQ("23:01")) },
> + { CQ("%s"), 2+1, EXP(CQ("1215054073")) },
> { CQ("%S"), 2+1, EXP(CQ("13")) },
> { CQ("%t"), 1+1, EXP(CQ("\t")) },
> { CQ("%T"), 8+1, EXP(CQ("23:01:13")) },
Check. This was in your patch so it's upstream now.
Thanks,
Corinna
--=20
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
--SLRDCdsRrCd4mzuj
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJWMc2/AAoJEPU2Bp2uRE+gmf4P/15WZiXWE59xugqUK8n8/l6z
zqwykGc1qAWDO6OU4EXvoMlqV+TZlFu+7F0r8Zg8QH1qvR1e9NTFcjLLfzBT2lqK
UrqZuPc+DoOVb5TVIfGbyxbgHR4djsnkPJ1BeigBPrswwdCcgEcPP16y5yy8zveR
amRWgOUgWCvCuY0Nh5FyS8fhh01BAZO6wbKqyfxATSTikxvuOIb94/8Oe5mXs0dM
cj/Y/5trs1G5TBuxZw0Sqdc4I9aFr6VatHAiiatf+cARb1eVAN8JaM4rNs1oPWaK
RSFt/t+gJnLA587GXo3iAFEEVco+OUAgs/IFG4hgbn7n6ZIdxso9H5aXkSnSUPFF
3bcLhHTXc5iBjA0fNfC8nG6HkhAD15vD/5jozqu0YkP1Ovsx6iCzcfd+Q/1tzaI+
bdvarxE2wfgxD1YLqH4ZtfejVpZ1EFClVY7sCZvJpJdZpwe3BuhSWRg80BMf3kIi
LHgQ/rZIh5/GYlDWJaaEE2GcDq7auUReij9DugNMSr+U5ZszCDi7y1SN2Yp0I9jq
fCYBhM0GT0cjx0vQoNbtedT4Va8q8byx4jx56Ehxsmn8pQ6wDr2++/PoYVNt9b+x
kuVPe8CIkYmRaG4sFRQ8A5s4iOvw2q5ZEOp0RA2R6JwXFnST1rrwpgrp/9N7tutX
IioK95OfcwLiYY36or9s
=hwh0
-----END PGP SIGNATURE-----
--SLRDCdsRrCd4mzuj--
- Raw text -