X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:references
	:mime-version:content-type:content-transfer-encoding; q=dns; s=
	default; b=n2bhHuHDTacQtVDP0YEiyqNzBAzuQ7h5Zk3VKCOjU5fOjW6NSFxZE
	SNg8MuVl+CDjgPWIki5LVw/GNUP5khe8TecYpWbK6A6ncv/7Et7SF4YfBJoJ5tRq
	0+64XEGIBiqv7dEOAjtlHCs9xryMq+rsekLjPaany/SxhH+XPj24rM=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:references
	:mime-version:content-type:content-transfer-encoding; s=default;
	bh=Dow6yLe1kEaFpzPzhdB+1ww+uJQ=; b=uN7UIr4d2/HnfkNBqXCq+h29iRWl
	rh67PUVGMAnVLcnaRT47iD95XNqWAickf/y2I5r3rACDe+faK5oPpa0cDy99TlrP
	dwuRQ3DTdwDo+IkDnzKMMnAJAPInpIzv+70ydF+YS8qAmn5/7GJ+o1LeOMFQl2l1
	0PmEHYPXxF/OV6Y=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FSL_HELO_BARE_IP_2,RCVD_IN_DNSWL_LOW,RCVD_NUMERIC_HELO,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO:	plane.gmane.org
To:	cygwin AT cygwin DOT com
From:	Johan Laenen <johan.laenen+cygwin AT gmail DOT com>
Subject:	Re: Https proxy auth issue with git in cygwin 2.2.1
Date:	Fri, 16 Oct 2015 12:26:14 +0000 (UTC)
Lines:	61
Message-ID:	<loom.20151016T142002-602@post.gmane.org>
References:	<CAFkLm6xW=5uUP+CRrmUontqPzqAZ+r4WdwjVAhP+XTvs53JmFQ AT mail DOT gmail DOT com> <20150921103100 DOT GF14466 AT dinwoodie DOT org> <loom DOT 20150925T090939-654 AT post DOT gmane DOT org> <20151005202249 DOT GM14466 AT dinwoodie DOT org>
Mime-Version:	1.0
User-Agent:	Loom/3.14 (http://gmane.org/)
X-IsSubscribed:	yes

Adam Dinwoodie <adam <at> dinwoodie.org> writes:

> I think I've found the problem, and you're right -- Git has changed the
> way it makes the curl call.  The culprit is commit 5841520b in the
> upstream Git repository, which has the following commit message:
> 
> | http: always use any proxy auth method available
> |
> | We set CURLOPT_PROXYAUTH to use the most secure authentication
> | method available only when the user has set configuration variables
> | to specify a proxy.  However, libcurl also supports specifying a
> | proxy through environment variables.  In that case libcurl defaults
> | to only using the Basic proxy authentication method, because we do
> | not use CURLOPT_PROXYAUTH.
> |
> | Set CURLOPT_PROXYAUTH to always use the most secure authentication
> | method available, even when there is no git configuration telling us
> | to use a proxy. This allows the user to use environment variables to
> | configure a proxy that requires an authentication method different
> | from Basic.
> 
> I can't confirm this is the problem, though, as I don't have a test
> environment that uses NTLM.
> 
> Do you have the ability to either run a test version of Git I can
> produce that patches out this change, or (better) to build Git yourself
> without this patch to see if that is indeed the change that's causing
> the problem?
> 

Hi There,

I can into the exact same problem after upgrading to the latest cygwin version. 

So, following your advice, I took git-2.6.1.tar.gz from github, untarred,
and modified http.c:

$ diff git-2.6.1/http.c t/git-2.6.1/http.c
466,467c466,468
<     if (curl_http_proxy) {
<         curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
---
>       if (curl_http_proxy) {
>               curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
>       }
469c470
<         curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
---
>       curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
471d471
<     }

One make configure, ./configure, make and make install I can confirm that
unpatching the change undoes the problem :)

> Adam
> 
> 


Johan


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -