X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=PqyZAfScDIgmOOC5+lIYXX1oM8DjF99BWSnr4FFd0ABlAPuwMCL+c
	22vphSCfSq3xASCCWp/qozxFieLPPwiC+Trmo8iJN8Bp5oybDq53uGb3+3xuvOCC
	dBGcwxss9pLFIHMBe4C7ESmMhzZlLNyaUpKkowiYjEaLasWi1BXaLM=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=6o9ePRalpAnLgEqvnFVvRuBe9tQ=; b=oth0Peu7IPK9o49UaFyZ0uKNAhVX
	jMXt4aJbgMr67wcl6k89MbHNFoK0kHf4GVUMLfc76CaAsoMgeMK1aTZSWII2gOHl
	C5rVqOAzWes9w8LBH0u0MBQMqBRsec4pVi919s6RT3zQ44pPQ+nClQXc0B4hd8oC
	BOhvvClATCC90xs=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-4.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2
X-HELO:	calimero.vinschen.de
Date:	Thu, 10 Sep 2015 19:49:33 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Group Permissions on root folders problem (Windows 10 TP build 10061)
Message-ID:	<20150910174933.GE26699@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<CAMH9mcFEL3mao+m-DEYM84kC1HOPeSBpZXD+mDf0USobF9oY7g AT mail DOT gmail DOT com> <CAMH9mcFOKjvjiFvvk1ju0ZxBDK28MaktdnYwj5_CjvbgnpVO4A AT mail DOT gmail DOT com> <20150616155843 DOT GE31537 AT calimero DOT vinschen DOT de> <20150905155916 DOT 8403bea8d4f631c1f7a314e3 AT nifty DOT ne DOT jp> <20150906114444 DOT GA27066 AT calimero DOT vinschen DOT de> <20150910200439 DOT bf06449af4f1e6efcb76676e AT nifty DOT ne DOT jp> <20150910172348 DOT GB26699 AT calimero DOT vinschen DOT de> <55F1BD86 DOT 1090001 AT redhat DOT com> <20150910173128 DOT GD26699 AT calimero DOT vinschen DOT de> <55F1BF8A DOT 2050907 AT redhat DOT com>
MIME-Version:	1.0
In-Reply-To:	<55F1BF8A.2050907@redhat.com>
User-Agent:	Mutt/1.5.23 (2014-03-12)

--7CZp05NP8/gJM8Cl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sep 10 11:36, Eric Blake wrote:
> On 09/10/2015 11:31 AM, Corinna Vinschen wrote:
>=20
> >>>> -      if [ "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" ]
> >>>> +      if [ "\\\\${COMPUTERNAME,,*}" !=3D "${LOGONSERVER,,*}" \
> >>>> +	   -a "${LOGONSERVER}" !=3D "\\\\MicrosoftAccount" ]
> >>>>        then
> >>>>  	# Lowercase of USERDOMAIN
> >>>>        	csih_PRIVILEGED_USERNAME=3D"${COMPUTERNAME,,*}+${username}"
> >>>
> >>> Thanks a lot, much appreciated.  Patch applied.
> >>
> >> [ ... -a ... ] is not portable; there are some inherently ambiguous
> >> situations that it cannot handle. POSIX recommends that you spell it [
> >> ... ] && [ ... ] instead.
> >=20
> > Does this matter in this very situation?  This is always running under
> > bash, btw.  Bash's a requirement for the csih helper script.
>=20
> Because you are at least using bash, you will get consistent behavior;
> and because both ... are 3-argument tests, it is unlikely that one of
> the tests can be confused with other operators like '(' or ')'.  So, I
> guess it's okay to leave it alone here.  But even with bash, the use of
> -a can cause problems when testing user-supplied variables that might
> happen to expand to text that looks like potential operators.

Feel free to change that in the csih repo.  Csih is under git now,
see https://sourceware.org/git/?p=3Dcygwin-csih.git.  You're in the
cygwin-apps group, so you have checkin rights.

If I didn't mention that before, I'm glad for any help since I only took
over because Chuck disappeared.


Thanks,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--7CZp05NP8/gJM8Cl
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJV8cKtAAoJEPU2Bp2uRE+gFtoP/R8Zi2yndJQlGkB11p5gjlor
QBAz8KxTDbQlI/eKEM93rJ11aSHredtZk9UpiJnoushmxSJfMUyG922rqZmReqTM
R7k7WXHSVUk/Coe0PUcwvvPP0P0N9+r2eceWyiIicuz8Ej14uqfMPerxii6u2mVU
WV2WvWsjPfInSZWl1wDhFWi1vfvv+8aMithGvmeup8LPpg0RR25uT4lBbPNCbTkC
cjL2lzabbduL2E9kLClp5avh4ALgIhxKK4fxMKxsACSo8qq90oZGMR/lOIVBNnkU
1KYZChwCDD3iRFliWqQa2+Rwdyl9JRJ4j+MX3A7UL03fZQMe8GdnEYZNueONM8/4
MLvV4wJEwAEEIe1tdsNnxCK3oyk5j7qe4MzG3aRfLNn2mJNZXIhCX+RJ87f/fQlS
K0WxKbjmP1mX0nIxKXQWFYVDKTe2+5K9TKlK6LwV9xBRoOyMELpXwQy2t7cP5eXk
/RLPx6UGI6o9Q13IcKSPkekp4hp9WhJmYP745HdfnKP4E4XewAh28vmZ4cHIKjgX
HRAlRo+igWO3fLCMj1psoqO22gt9AWXNoGtXjTpXJH1XgGbgFQ6Q9wWXNP945eM8
Z5unhmDJZG8EyAkE1fGJG0uNKr4KhLjMCtvMpaEsuIi7HLuMpzxgjSe0EKS5+WyI
soB8R3Oej5p1rvmIQwS9
=7JE8
-----END PGP SIGNATURE-----

--7CZp05NP8/gJM8Cl--

- Raw text -