Mail Archives: cygwin/2015/04/07/05:11:47
--vGgW1X5XWziG23Ko
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Takashi,
On Apr 5 20:55, Takashi Yano wrote:
> Hi Corinna,
>=20
> On Sat, 4 Apr 2015 10:43:54 +0200
> Corinna Vinschen <corinna-cygwin AT cygwin DOT com> wrote:
>=20
> > That should have been fixed by cbb9849fa76f1dbe6c66d91b68d9a10f46f1ba69.
> > You have to rebuild Cygwin to make this change have an effect.
> >=20
> > Alternatively you could checkout f992ae6f4da99b6a200cfc146b96e8e921ca1e=
70
> > to ignore the ucontext stuff for now.
>=20
> Hmm, even after cbb9849fa76f1dbe6c66d91b68d9a10f46f1ba69,
> it does not work in my environment.
>=20
> But ok, f992ae6f4da99b6a200cfc146b96e8e921ca1e70 works.
>=20
> Using f992ae6f4da99b6a200cfc146b96e8e921ca1e70, the problem
> you had pointed out has been regenerated. Same problem can
> be regenerated with a simple test case below.
>=20
> #include <windows.h>
>=20
> int main()
> {
> HANDLE hCons;
> DWORD n;
>=20
> hCons =3D GetStdHandle(STD_OUTPUT_HANDLE);
> WriteFile(hCons, "AAAA\n", 5, &n, NULL);
> WriteFile(hCons, "BBBB\n", 5, &n, NULL);
> WriteFile(hCons, "CCCC\n", 5, &n, NULL);
> CloseHandle(hCons);
> return 0;
> }
>=20
> This is caused obviously by the patch I had proposed.
> Post processing, in which \n is converted to \r\n, was in
> the read process previously, so it had effect to the test
> case above.
>=20
> However, now the post processing is in the write process,
> so it does not have effect against direct WriteFile() to
> the pipe.
>=20
> Unfortunately, I have no idea for the moment....
The problem is that the patch shifted processing from the pty master to
the slave, but the slave isn't necessarily a well-behaved Cygwin process.
I think we should move opost processing back to the master side. Would
it be much of a problem to restructure your patch to do that, without
re-introducing the old problems your patch fixed?
Thanks,
Corinna
--=20
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
--vGgW1X5XWziG23Ko
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBAgAGBQJVI58wAAoJEPU2Bp2uRE+g5REP/1illbSA8XbRMU8ZdLWaO7ZG
7HrJj9PsKoYBS+MyynTj1tYBbQNv62O4yHtbN7eVoD5xthaEUwCGLSGxNToR2PMT
cVTp20TPqGovWeRFX21InD0x3jV9+5GealPdPdI436m5O87qAdFfl+f7CAf/r7fC
40Yv8XYQbNXd9uR7B5L7sgUDHzS9jIwAsWexnJinsSKgfVP23Xh1gFhlYHcrhdHf
PFno85WO3gGqxO7SSVufIHnNybsBJHN397op4s5atMoqXkcb/NS2OQ2kCVxYdQ2Z
CmnLdR4IVSsv+ucwiPuIH4IZm1vOTYO6PGIQQRXIrBjoUBVnpeKjl2DsHld72clq
uXKO/6kES4T6QKj+cUiHnWDyCS+Qtn1mjCX4+t0y6L4w2txPM5kvUFlupkpxwgA4
hZoX6cbucs66tlnA/GD32Tkluxu1YrwWUjsyVxxjAGMgYrfjxPWBRUMLi+mghRDS
KOWXHe5Q+Lz12W9Yd5rC1RZkCTGDkvwT5yARyC2FLLSm+RaB+XmhlZhk1QOeHUdz
Iy7xR2oJipdrpz7WjG24BaHG6N38ELIO+UkXSE4xEzvUS/CZbVi3dSYIjfoL6V1r
yuv+b0+sqDNRhflL2Esks4BT+kaOi3pWFCHxKAhfwAnHaalDzcZPK2WjrBcZllg3
UTR2ZxfWB4Xs9AB62v+E
=axWs
-----END PGP SIGNATURE-----
--vGgW1X5XWziG23Ko--
- Raw text -