delorie.com/archives/browse.cgi | search |
X-Recipient: | archive-cygwin AT delorie DOT com |
DomainKey-Signature: | a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:date:from:to:subject:message-id:in-reply-to | |
:references:mime-version:content-type:content-transfer-encoding; | |
q=dns; s=default; b=Wo9zK2Rad46k3fvcbrlfKqbten7cbn4datDYqJf7Avu | |
kg9PD/474iete1evA7OI723V9gULaWR8VFRlpELE3C1myqdiuhFxALXtUbxktcgI | |
7Dy5+fD76RKH12YVcjYlYS34uWiIHJDDAdU4xxQ9BLTDZ8F+2kZYHvJKnudrcu6k | |
= | |
DKIM-Signature: | v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:date:from:to:subject:message-id:in-reply-to | |
:references:mime-version:content-type:content-transfer-encoding; | |
s=default; bh=zMXqvY+YbecXyAuu0mbpmzOKP+8=; b=Yhom67zJgnEI1JmJI | |
ZqBWJKuPHVI3s90rZCRNYtVInqHsNwYbWjattCYPqTLrr0ny/6LT1KTC1X7UJp60 | |
lx0sy/g1ppWzNMt8utdo6KpKdKaDb1G6DewPlW8OS9WY/DCqr1F/MuIGyfBoJIk2 | |
Xmg2CRcKks0y5l8SN/58n7m60g= | |
Mailing-List: | contact cygwin-help AT cygwin DOT com; run by ezmlm |
List-Id: | <cygwin.cygwin.com> |
List-Subscribe: | <mailto:cygwin-subscribe AT cygwin DOT com> |
List-Archive: | <http://sourceware.org/ml/cygwin/> |
List-Post: | <mailto:cygwin AT cygwin DOT com> |
List-Help: | <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs> |
Sender: | cygwin-owner AT cygwin DOT com |
Mail-Followup-To: | cygwin AT cygwin DOT com |
Delivered-To: | mailing list cygwin AT cygwin DOT com |
Authentication-Results: | sourceware.org; auth=none |
X-Virus-Found: | No |
X-Spam-SWARE-Status: | No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_SORBS_DUL,SPF_PASS autolearn=ham version=3.3.2 |
X-HELO: | conuserg003-v.nifty.com |
X-Nifty-SrcIP: | [121.93.68.199] |
Date: | Wed, 25 Mar 2015 20:20:46 +0900 |
From: | Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp> |
To: | cygwin AT cygwin DOT com |
Subject: | Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared. |
Message-Id: | <20150325202046.f6b6f40c0245145760d72391@nifty.ne.jp> |
In-Reply-To: | <20150323100823.GE3017@calimero.vinschen.de> |
References: | <20150228143653 DOT ab0a6bf854db294105e1d5f3 AT nifty DOT ne DOT jp> <20150228135947 DOT GZ11124 AT calimero DOT vinschen DOT de> <20150302210508 DOT 1be5c1ed4753508431842913 AT nifty DOT ne DOT jp> <20150318145854 DOT GC2368 AT calimero DOT vinschen DOT de> <20150319074942 DOT 6c18c8fe0199037f028687dd AT nifty DOT ne DOT jp> <20150319083451 DOT GA8398 AT calimero DOT vinschen DOT de> <20150320191232 DOT GJ2368 AT calimero DOT vinschen DOT de> <20150321104031 DOT 9dc198eb8aa4e7652e0a7a51 AT nifty DOT ne DOT jp> <20150323100823 DOT GE3017 AT calimero DOT vinschen DOT de> |
Mime-Version: | 1.0 |
X-IsSubscribed: | yes |
Hi Corinna, On Mon, 23 Mar 2015 11:08:23 +0100 Corinna Vinschen <corinna-cygwin AT cygwin DOT com> wrote: > With this out of the way, I'm just looking through your patch and it > looks good to me. I have only a few minor style nits: > > + rc ++; > > No space between the variable and the increment operator, please. > > + if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp ()->column == 0) > > Please try to keep lines <= 80 chars: > > + if ((get_ttyp ()->ti.c_oflag & ONOCR) > + && get_ttyp ()->column == 0) Thank you for checking my patch. > However, due to the changes in fhandler_tty.cc, this patch doesn't > apply cleanly anymore. Any chance you could resend it (ideally to the > cygwin-patches ML) diff'ed against git HEAD? I will post a revised patch to cygwin-patches ML soon. Thank you in advance. -- Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp> -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |