X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	q=dns; s=default; b=gLRd+8wALlKJegSiafT+H2UexsvoWj77tdh3fNN4Z9R
	j+OrGvUpaNCwHe10Z56884AJ1/TLH3Jf+MsRPwI4KNhWMDTh7V0bqFkvGu96RpNO
	9AUsUlEI8gybU9Ev/nz1J5cCaD+KIAgR/+2TC4zAdVdxAjSk9019Wk5w4xUtaysM
	=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	s=default; bh=HcMlOtN16eUrt64eYv1WpEyzPvs=; b=hqGJA4AMd2T960I4Q
	B5txVbp5H9hEy8reK33bTj/hmgDkeEUXk+1ZfgJBIIokUYMv4q1KhqsxV2VzfBU/
	OEMGdJgU2C+tc6TC8qN/DLxqEG4dX05YLQXe5U+TGQ60Av9xe4sPTmUEqtwfNlJh
	u6t4dNgx9YPNfx9NlSGVGMY9jA=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO:	mx1.redhat.com
Message-ID:	<543D910D.3060003@cygwin.com>
Date:	Tue, 14 Oct 2014 16:09:33 -0500
From:	Yaakov Selkowitz <yselkowitz AT cygwin DOT com>
User-Agent:	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: Crash in g_file_monitor on 32-bit Cygwin
References:	<53AB82AB DOT 5000304 AT cornell DOT edu> <53ADA5B5 DOT 10404 AT cornell DOT edu> <53ADAF68 DOT 2020703 AT cygwin DOT com> <53AEA23A DOT 8030306 AT cornell DOT edu> <543D4ED3 DOT 6020605 AT cornell DOT edu> <543D6BB9 DOT 3030009 AT cornell DOT edu> <20141014192803 DOT GE2681 AT calimero DOT vinschen DOT de>
In-Reply-To:	<20141014192803.GE2681@calimero.vinschen.de>
X-IsSubscribed:	yes

On 2014-10-14 14:28, Corinna Vinschen wrote:
> I know the code is not yours, but I have to vent while I see this code :)

Actually, this isn't the first time you're seeing this code, it's just 
been a while. :-)

> There's no reason to load GetVolumePathName from kernel32 since all supported
> platforms provide this entry point.

They didn't when this code was written.

> How old is this code?

2006.

> What *exactly* is this function trying to check?

gamin enforces permissions on its sockets, which will fail on FAT 
partitions for obvious reasons, so we need to bypass those checks in 
that case.

Obviously this code is overdue for an update, which I'll try to do later 
today.


Yaakov




--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -