X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=UU1kpFEIDRLXkkCnjP9YfzCCwDMrSdHOSpEyD7CVoCpGP3Ihl0D9u
	ifCS1MZJgqiSIc6jzlB2/f+2lC5kuYqK11c5zhlLPD1MKRzdVAvHzDtdG59ygDO7
	pIoY4fQDdpyZJtbUlhPFvi0pfPuPZLxpXnwIltPExhBwJG0NFq3t7c=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=McUV47hsQy7jmE9jYau7nPz2DGQ=; b=p6mPOABi6g+oS7hmmC8g+y4NGyDn
	4qxYyVocKHpJiUfyfY8AtOlo+MGHVF+apDSuv77rD+S+p+2Ym/Vs9rKLxvIVmXi3
	MEjPMgxv75TzMygl22UsecZl3nsv/DhMcUgQrXVJooxsNSzY6y9dDmFvNu7f2Lbr
	UB/32fg75PH6c8A=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-5.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO:	calimero.vinschen.de
Date:	Fri, 11 Jul 2014 12:35:40 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Severe performance degradation of writev
Message-ID:	<20140711103540.GA18114@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<lpciht$pc5$1 AT ger DOT gmane DOT org> <20140707101049 DOT GI1803 AT calimero DOT vinschen DOT de> <20140707134137 DOT GK1803 AT calimero DOT vinschen DOT de> <53BD7161 DOT 5030209 AT acm DOT org> <20140709170321 DOT GA9946 AT calimero DOT vinschen DOT de> <53BD791F DOT 6040807 AT acm DOT org>
MIME-Version:	1.0
In-Reply-To:	<53BD791F.6040807@acm.org>
User-Agent:	Mutt/1.5.23 (2014-03-12)

--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul  9 10:17, David Rothenberger wrote:
> Corinna Vinschen wrote:
> > On Jul  9 09:44, David Rothenberger wrote:
> >> Corinna Vinschen wrote:
> >>> On Jul  7 12:10, Corinna Vinschen wrote:
> >>>> On Jul  7 07:28, jojelino wrote:
> >>>>> 2008-07-27  Corinna Vinschen  <corinna AT vinschen DOT de>
> >>>>>=20
> >>>>> * fhandler_socket.cc (fhandler_socket::send_internal):
> >>>>> Send never more then 64K bytes at once.  For blocking
> >>>>> sockets, loop until entire data has been sent or an error
> >>>>> occurs. (fhandler_socket::sendto): Drop code which sends on
> >>>>> 64K bytes. (fhandler_socket::sendmsg): Ditto.
> >>>>>=20
> >>>>> This commit added workaround for KB823764. but it has
> >>>>> brought another performance issue when writev sends <64k of
> >>>>> data.
> >>>>=20
> >>>> That's why the code contains that FIXME comment.  If you have
> >>>> a good idea for simple code to split a message into the
> >>>> least number of pieces to minimize the number of WsaSendTo
> >>>> calls...
> >>>=20
> >>> I took a stab at the code and I think the new version improves=20
> >>> writing multiple small buffers a lot.  In my testing it still
> >>> works in other scenarios, too, but I would be very grateful if
> >>> somebody could have a critical look into my code changes as
> >>> posted in=20
> >>> https://cygwin.com/ml/cygwin-cvs/2014-q3/msg00003.html
> >>>=20
> >>> I uploaded a new developer snapshot to=20
> >>> http://cygwin.com/snapshots/ Please give it a thorough try.
> >>=20
> >> FWIW, this snapshot fixed a recent performance degradation for me
> >> when doing ssh/rsync transfers within my local network at work.
> >> These transfers had run at about 25 MB/s but recently degraded to
> >> about 500 kB/s. The snapshot restored the original performance.
> >=20
> > Cool.  Is the result still intact?  It's kind of simple to have=20
> > lots of performance if the code just doesn't send everything... :}
>=20
> Details, details. :)

Yeah, yeah, I know, I'm nitpicking here ;)

> Yeah, I just tried a transfer and verified the checksum of the
> transferred file. It worked fine.

Thanks!


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJTv738AAoJEPU2Bp2uRE+gYlAP/3olYKWnV3C1TmTZetS1SnPD
VkaQ51KmooAprL51uCXZRL14HghMKzp+bbDhptUf7hvJzgswUZF464/FjE77zMPx
PDtKic8BRLC/uhPdrVKDqlghR9nbWoqQBptNQrfG6AmhajIU0HnhLvII1e4+ajU4
PzEGwKkzYiH1OyKtUuZUpLnMNdJ6wxqavL/n6YmVDjF84Q+MGg49EgEwAAgVpZKa
p1N9iZ0FaDsGrPkPhiaeQp0pVxG888ipGuKIIrm2ymXNPfBxfzYd+PRWg7Q48ZH9
9azT85fAtE0ogGVnzbYtsyFmekyTgFfo+XKQOYjiA9bkuaviQ3Z/cDP27cMGeq8h
A0aLz/tIj8sD4PO5XH8ftcyHWGcyiIfw/newjftwPGib2EUxunjU08WGupRBPj3s
Pcmpq2r1juR7xEVTGh0Goa1O4VLUC4WN1x6MGc2JlzhD7albnupUy8MJaME1eWOL
5ynozZa+BVfooE1tAOVjAQgGhkbUSEX/0bHOhFmY13IHbXPi2cpsDvnUSmTAW7wx
6QhirZM5Lv0IB9RsnGZ+fBeTJt6RY8jW5NjeSlPKm9WCXOWOyDjpmNldfbclkQuF
EmYAHFeghdtdLMslCaA6Pjsn7Fo0p0464ZnYG54iAoW4SxCbswsQrjNn6JaHQhZp
USUJnUq1ZTHzchn5y9bk
=S62M
-----END PGP SIGNATURE-----

--bp/iNruPH9dso1Pn--

- Raw text -