X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=F6pe3cIcnpcciZV/LhoD5LKHAinfJApE6PQvFle44aOFj9tnIQ5MO
	/sB++YulF57R9nyGIw/oQlbK3/tvQ8aIGzo223stwaajsiGZXdRE5WeUXSd//DfQ
	MqjK7kfQLVLVK+wE0jyfUEE/RgQ/N9s5A1NyxTbHZInOz5Tx5k0ObI=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=PBeJQntLH/QQEXSWxm/Hpe1RvqU=; b=y1smjwqIeZEA7ICf1mtmxOL3tbbP
	dmtYLYtF1coGuWjrwztVHZqRqDIuPoRQEYq3Pz6cMUYglhpCT443wQZ3drECRzR9
	ZlUQUyA6C7fU32R4ZLnEDKSU/i3xgnU+p0D9o6IzXeTs/agE8mo//MNfVLdw3P4f
	psdp1QJtt+SOcvA=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
Authentication-Results:	sourceware.org; auth=none
X-Virus-Found:	No
X-Spam-SWARE-Status:	No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2
X-HELO:	calimero.vinschen.de
Date:	Sat, 26 Oct 2013 11:47:04 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
Message-ID:	<20131026094704.GA15394@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<52692BAC DOT 5060800 AT mandriva DOT com> <20131024150921 DOT GB24229 AT calimero DOT vinschen DOT de> <CABEPuQJrD6e2xy18utjm2WqAoVc6seAKR88ocWhiqot3W54m5g AT mail DOT gmail DOT com> <CABEPuQLku+UFmoF2Wb6dUBvUEQw8sbmgG4mv-UiMgdSC=t+0TQ AT mail DOT gmail DOT com> <20131026062530 DOT GA5850 AT ednor DOT casa DOT cgf DOT cx>
MIME-Version:	1.0
In-Reply-To:	<20131026062530.GA5850@ednor.casa.cgf.cx>
User-Agent:	Mutt/1.5.21 (2010-09-15)

--CE+1k2dSO48ffgeK
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Oct 26 02:25, Christopher Faylor wrote:
> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
> >/usr/include/w32api/winnt.h:3541:20: error: previous definition of
> >?struct _EXCEPTION_REGISTRATION_RECORD?
> >     typedef struct _EXCEPTION_REGISTRATION_RECORD {
> >                    ^
> >In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
> >                 from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
> >/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
> >type in declaration before ?;? token
> > } exception_list;
> >                 ^
> >/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
> >'cygtls.o' failed
> >make[3]: *** [cygtls.o] Error 1
>=20
> Feel free to provide patches.  Simple compilation issues do not
> require copyright assignment.

I applied a patch.  The redefinition of _exception_list to
_EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early
"just build, goddammit" porting stage.  Later on it turned out that
x86_64 doesn't use frame based exception handling anyway so all the
code using _exception_list is unused on x86_64 anyway.

I also changed the public header <exceptions.h> so that it only
applies if !x86_64.

That leads to a question:

Why on earth do we have a *public* header exposing the exception
handling on a certain CPU?  This isn't a standard header, neither POSIX
nor Linux nor BSD systems have it.

If there isn't a compelling reason to keep the header, I would opt
for folding the content into the private Cygwin header exception.h
and drop the public header entirely.


Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--CE+1k2dSO48ffgeK
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQIcBAEBAgAGBQJSa4+YAAoJEPU2Bp2uRE+gyVoP/R7aB+1IfHJkQyd/doteM+he
5GrmB0oSKu+PBFjJ88Wk8zYLGTz4BTAEJuplZ2tGvQLUVF4UrqUs7FGgkXdVsroK
KsQQMMSZ5KcQKzVfx5NfrE0HSSCphKt5SLBXqmQBnj2yVoAHq4fLhF/Wm/RXVm2i
krE2w8N5diAYnLCEwQ0BpYfs3I7aGghVuTPCM/FP3AsHCVbU0XO3bxtt1nV7Y5cq
j8+1p/6GAbfCx0OjNKqXSv+qNLt2H992AyJTs7DjWsftJrvQQnmaZWk3Kthg/C9K
p4+P2Ty2c0ZfpKoaVdCpQRP6Ii7qgP2EtjhIAHX55+rIs0DkBRSc/xOL8XX66sJF
7WcJPhG8QxBoiaJfM6FdKLmTr1GLoH/ilMovEjMrGhEwz18yh9eL9LxGAPjoVVGz
OGcoiqMxv3YqztzrM3W0tpc9N0+nNZEhrF52LSDekVe4hQFeNzNvSoIodpf62so2
qOHX9kTveNB2tgrGJsHbRihtz1ZA0fYY7MCcWrjhCxVuzZ/ADfIRTVO4YhegSTCN
Ck8YG/qVJLgZSJn60m6I6PABay0TjRr2lEywhB+LXKUVFiAbPzAixuEXQhmwXS6a
3wFFYpE/CCL478eqB6bgS/veMT2Z0caXyfb2vj++l/fjaMHfqnv68tEqvu7kknwD
+ESy506HksjrpGPzxtaG
=NPLt
-----END PGP SIGNATURE-----

--CE+1k2dSO48ffgeK--

- Raw text -