X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:references
	:mime-version:content-type:content-transfer-encoding; q=dns; s=
	default; b=m8lYbEO8NrGrJOn0K+BgtLvZz26conD/7YCAiAF7mnxCQ8rhFIbwK
	EZCdUopN+fTGZyA4sXBWGbOqseDtmSLywf/ilYSLgYI8GPy1fWQz2hmU33B1Cm+i
	6cWx9qq2ikToa3Gy4l71ATn2HhBMDWxx75wipXoJazk6KV1LU5KeA8=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:to:from:subject:date:message-id:references
	:mime-version:content-type:content-transfer-encoding; s=default;
	bh=srRjZ/1mzlV7zBxGjS3j4SONlt4=; b=d5fa+PaMajTfeWRA8Tg8AKy31xxA
	CgSh0sA6r1lfVUvsXRykX0Q9sIz3K4IFVzLVnEBKUhfXVHOdaoHCPh63fIJka7Ls
	t/aj+nGrYW5xQIDbRskVUpnpEXTZi1KCgVHu9UL46kSwVo7nHhrXBxXeP0XQfu6A
	rJ2G2hs8r31Lgkc=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
X-Spam-SWARE-Status:	No, score=-1.6 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1
To:	cygwin AT cygwin DOT com
From:	Andrew Schulman <schulman DOT andrew AT epa DOT gov>
Subject:	Re: [PATCH] Fix optional variables in libargp
Date:	Tue, 23 Jul 2013 10:21:42 -0400
Lines:	15
Message-ID:	<0a2tu8p6ddvgut5nqgc12292oqtihs9du5@4ax.com>
References:	<000001ce7e08$2b866830$82933890$%fedin AT samsung DOT com> <u4ett8due4p6h9ku1iumscvulp0g688tgk AT 4ax DOT com> <4q4ut8had25hqmo8b0752i8asuv6ism2qh AT 4ax DOT com> <002901ce7f0a$9da99420$d8fcbc60$%fedin AT samsung DOT com> <tq50u89pa1s7us0cff5rnu8k5ocumac510 AT 4ax DOT com> <002601ce82b7$63229580$2967c080$%fedin AT samsung DOT com> <oksou81bta580gufa1d28k45c1ismdn2o3 AT 4ax DOT com> <002a01ce86c6$ba32a190$2e97e4b0$%fedin AT samsung DOT com>
Mime-Version:	1.0
X-Archive:	encrypt

>  Hello!
>  I have successfully tested it on i386. Really, just remove PREFIX
> completely and it's okay. GetProcAddress() appears to be "clever" and adds
> the leading underscope by itself on i386. I don't know what you did wrong
> and why you could not reproduce the solution.
>  However, i have one idea. After patching libargp you need to recompile your
> test case. Because it needs to pick up __declspec(dllexport).

Sorry, this was my fault.  I accidentally mangled your patch when I took
PREFIX out.  I fixed that, and it works fine in x86 now.

So, I'll put a new release out shortly that includes your patch.  Nice
work, and thank you.

Andrew


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -