X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=b6aypVxToyLDWJr3bBbN7ScmyvTXQ0TuV5poRNhcpYqzuujHBxt3O
	E/MlXYrm72B9lF583knvoEgzCNmTnQncus2jfWVd5gtTgV4YpNjBFOESSjms9Vmz
	sC5/jAaGS3yVPiYW1NatXOI8JhQyajRbxiYaaZvfLeLDQ56t7zPMmQ=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=v6In8KT48kVSQ/YfyQzl710ZD/s=; b=b0Lkp5ThnUaaKqiq3wIUw+3gEw9y
	VLnLhSaWEmPy9fGR4TFj1JsdSx4jpx+LfQuaYGm5wB9krYoHWUNgwBtxSSTMQGba
	9MXWjAssTxkwdYXDYOJwBFBziKk/JyKZwYc9y+WKfYE6mshdoicusy0SQCR+Q8mE
	7MCFNPAAIYRKp0o=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
X-Spam-SWARE-Status:	No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1
Date:	Tue, 11 Jun 2013 19:30:08 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: [PATCH] Check for existence of the path before processing '..'
Message-ID:	<20130611173008.GJ9484@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<001401ce66a4$bb9029a0$32b07ce0$%fedin AT samsung DOT com> <20130611142002 DOT GA1927 AT ednor DOT casa DOT cgf DOT cx> <20130611150446 DOT GB9484 AT calimero DOT vinschen DOT de> <20130611151708 DOT GB2235 AT ednor DOT casa DOT cgf DOT cx>
MIME-Version:	1.0
In-Reply-To:	<20130611151708.GB2235@ednor.casa.cgf.cx>
User-Agent:	Mutt/1.5.21 (2010-09-15)

On Jun 11 11:17, Christopher Faylor wrote:
> On Tue, Jun 11, 2013 at 05:04:46PM +0200, Corinna Vinschen wrote:
> >On Jun 11 10:20, Christopher Faylor wrote:
> >> You introduce a check_parent flag which is set every time a non-slash
> >> character is found.  That doesn't seem right.  It seems like it should
> >> be set whenever you see a slash.
> >
> >Indeed.  I moved setting check_parent before the while expression in
> >the else branch instead and it still works.
> 
> I'll bet you wouldn't see much of a hit if you just got rid of the
> check_parent flag entirely.

Actually, to my own surprise, it does.  I removed the flag and the code
takes 3 seconds longer on average to build coreutils:  136.2 vs. 133.4
vs. 132.3.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -