X-Recipient:	archive-cygwin AT delorie DOT com
DomainKey-Signature:	a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=gvZDI9BFgcQHbtkuODg7OoyTo6tR86kECLedNP5SOtqCjr4G2agd0
	xX9voJyNSu/nOcFqX0VQI27oFLkhtemHduczvBbO8yMcSWf1XAehy2YLmbJhVyk/
	evRD52e2pR1JQwbc04vlESInfBDMVoxnPaFW2vXtAW5U1WhrLza+3Q=
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	bh=0ip/zupdy7R24SngJKl1y2qYbBE=; b=QTNmhUlLjaozjqOjzXy0aMb7g4cD
	KCvBOUSt64aHS1Vee/1aipFk2x20po9oIpMpfJUek6Ph0x98Y7Rw3wTnHwjpNQZL
	47xqrGhOzp3/6VOa9xHDQlDyh1lP0cmVWh0Sn54xsML0eB3JPPoPi1mbqRXN5qJC
	sk6hFI61x/8N1hU=
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com
X-Spam-SWARE-Status:	No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1
Date:	Tue, 11 Jun 2013 15:48:07 +0200
From:	Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To:	cygwin AT cygwin DOT com
Subject:	Re: [PATCH] Check for existence of the path before processing '..'
Message-ID:	<20130611134807.GG23332@calimero.vinschen.de>
Reply-To:	cygwin AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
References:	<001401ce66a4$bb9029a0$32b07ce0$%fedin AT samsung DOT com>
MIME-Version:	1.0
In-Reply-To:	<001401ce66a4$bb9029a0$32b07ce0$%fedin@samsung.com>
User-Agent:	Mutt/1.5.21 (2010-09-15)

Hi Ferdin,

On Jun 11 17:08, Fedin Pavel wrote:
>  Hello!
> 
>  Some time ago i reported ability to access things like
> "/usr/nonexistent/..bin". I still had this problem and i tried my hands on
> fixing it.
>  The patch works by checking the actual existence of the path before
> removing the last component from it. For performance reasons, only one check
> is done for things like "../..". Because, obviously, if "/foo/bar/baz"
> exists, then "/foo/bar" exists too. Also, the check is done only after some
> components have been added to the path. So, for example, current directory
> (obtained when processing relative paths), will not be checked.
>  I tried to add a similar test also to normalize_win32_path() function,
> however this broke things like "cd /usr/src/..". For some reason, a POSIX
> version of the path (but with reversed slashes) is passed to this routine
> when expanding mount points, so, consequently, test for "\usr\src" using
> GetFileType() fails.
>  I think it's ok, at least POSIX paths now behave in POSIX way. I have
> tested against performance, there is some loss (~0.2 seconds), but only for
> referencing '..'.

Thanks for the patch.  The idea sounds good, and I think it's the right
thing to do *not* to add this to normalize_win32_path, because the ..
semantics on WINdows are so that a .. is allowed even if the parent
doesn't exist.

I didn't test your patch so far, but I'm a bit puzzled about your
performance claim: ~0.2 secs compared to what?  What's your test case?
I mean, this tiny code snippet can't take 0.2 secs per single call,
right?


Corinna


> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -