delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2012/08/21/23:41:21

X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_RX,TW_YG
X-Spam-Check-By: sourceware.org
Message-ID: <503454B1.2050709@cwilson.fastmail.fm>
Date: Tue, 21 Aug 2012 23:40:33 -0400
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: Oddity with cygport, debuginfo generation, and rxvt-unicode
References: <5033C360 DOT 1060007 AT cwilson DOT fastmail DOT fm> <5033F431 DOT 5040402 AT users DOT sourceforge DOT net>
In-Reply-To: <5033F431.5040402@users.sourceforge.net>
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On 8/21/2012 4:48 PM, Yaakov (Cygwin/X) wrote:
> On 2012-08-21 12:20, Charles Wilson wrote:
>> In the meantime, I think a fix like this for cygport would be
>> appropriate:
>
> Could you confirm that just this change fixes this:
>
> - case $(realpath -m ${dbgsrc}) in
> + case $(readlink -m -- "${dbgsrc}") in

Yes, that change, by itself, fixes the problem.

>> ...although I'm not sure if this might cause a problem if a filename
>> actually contains a shell redirection metacharacter (and the originating
>> project is always careful to appropriate quote that filename).
>
> And when was the last time you saw that?

Oh, let me think...never. I'm still (re)training people that spaces are 
evil.  Don't even get me started on hashes and shell metas in filenames...

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019