X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By:	sourceware.org
Message-ID:	<4F342570.8060709@redhat.com>
Date:	Thu, 09 Feb 2012 12:58:40 -0700
From:	Eric Blake <eblake AT redhat DOT com>
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com, newlib AT sourceware DOT org
Subject:	Re: <sys/sysmacros.h> is broken
References:	<4F3279AC DOT 2010705 AT redhat DOT com> <20120208140657 DOT GJ25129 AT calimero DOT vinschen DOT de> <4F32DB30 DOT 8080807 AT redhat DOT com> <3862C5643B15B6468269546753EB2A92064F5CDF AT BLTSXVS01 DOT govsolutions DOT com> <20120209102612 DOT GE23481 AT calimero DOT vinschen DOT de>
In-Reply-To:	<20120209102612.GE23481@calimero.vinschen.de>
OpenPGP:	url=http://people.redhat.com/eblake/eblake.gpg
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

--------------enig65A9DB49E911AF24713857C1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 02/09/2012 03:26 AM, Corinna Vinschen wrote:
> On Feb  8 19:41, Howland Craig D (Craig) wrote:
>> Eric:
>>      I suggest adding a brief comment explaining the need for the
>> static.
>>      (For the lists, we had a brief off-list discussion, where Eric
>> quoted
>> C99 section 6.2.2 paragraph 5 and section 6.7.4 paragraph 6.  Together
>> they give the details needed for understanding.  In short, the compiler
>> can
>> choose not to in-line the function, but without the static it would emit
>> an
>> external function call--which can fail at link if that function does not
>> exist.  With the static, it can still choose to not in-line, but is
>> required
>> to provide a local function call within that translation unit.  I
>> apologize
>=20
> Adding such a comment sounds like a good idea.  With this change the
> patch s ok to go in, Eric.

Done.

--=20
Eric Blake   eblake AT redhat DOT com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig65A9DB49E911AF24713857C1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPNCVwAAoJEKeha0olJ0Nq/GgH/iNwnqOgaprGn35LuqmOyegG
RVO7Vz/xqdUs5bmTlXyhSALW7t2YwLi7gHw2/fu9QwVfUXZFgCf2wcfVfH/XXTpb
qEBTa6yTme2WRdh1KPC/E9jOz7tCXohFlMQlDOWbMKL/MrTTzrRgdooxDUhHHgsx
W9YD7tq+reGlvmmdYceskDNYzQjtdutMP7SPCovGbOliTq00BX0KrBtfioQpgIyN
MRSi2oBLeb2yQYWnsh2jwzmIYGjBgkPUjV61/Kw87s5XoxZ/QIRgVuimXuJtMurE
tNGhJYgDzNC2qgBSMb3dI2hOHt7laIrcCPqGqbnkMu4SRR8+yE7OQRbCLtt3xxs=
=A+gG
-----END PGP SIGNATURE-----

--------------enig65A9DB49E911AF24713857C1--

- Raw text -